All of lore.kernel.org
 help / color / mirror / Atom feed
From: "'Christoph Hellwig'" <hch@infradead.org>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: 'Andrew Morton' <akpm@osdl.org>,
	Dmitriy Monakhov <dmonakhov@sw.ru>,
	'Christoph Hellwig' <hch@infradead.org>,
	Dmitriy Monakhov <dmonakhov@openvz.org>,
	linux-kernel@vger.kernel.org,
	Linux Memory Management <linux-mm@kvack.org>,
	devel@openvz.org, xfs@oss.sgi.com
Subject: Re: [PATCH]  incorrect error handling inside generic_file_direct_write
Date: Fri, 15 Dec 2006 10:43:41 +0000	[thread overview]
Message-ID: <20061215104341.GA20089@infradead.org> (raw)
In-Reply-To: <000001c71e60$7df9e010$e434030a@amr.corp.intel.com>

> +ssize_t
> +__generic_file_aio_write(struct kiocb *iocb, const struct iovec *iov,
> +				unsigned long nr_segs, loff_t pos)

I'd still call this generic_file_aio_write_nolock.

> +	loff_t		*ppos = &iocb->ki_pos;

I'd rather use iocb->ki_pos directly in the few places ppos is referenced
currently.

>  	if (ret > 0 && ((file->f_flags & O_SYNC) || IS_SYNC(inode))) {
> -		ssize_t err;
> -
>  		err = sync_page_range_nolock(inode, mapping, pos, ret);
>  		if (err < 0)
>  			ret = err;
>  	}

So we're doing the sync_page_range once in __generic_file_aio_write
with i_mutex held.


>  	mutex_lock(&inode->i_mutex);
> -	ret = __generic_file_aio_write_nolock(iocb, iov, nr_segs,
> -			&iocb->ki_pos);
> +	ret = __generic_file_aio_write(iocb, iov, nr_segs, pos);
>  	mutex_unlock(&inode->i_mutex);
>  
>  	if (ret > 0 && ((file->f_flags & O_SYNC) || IS_SYNC(inode))) {

And then another time after it's unlocked, this seems wrong.

WARNING: multiple messages have this Message-ID (diff)
From: 'Christoph Hellwig' <hch@infradead.org>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: 'Andrew Morton' <akpm@osdl.org>,
	Dmitriy Monakhov <dmonakhov@sw.ru>,
	'Christoph Hellwig' <hch@infradead.org>,
	Dmitriy Monakhov <dmonakhov@openvz.org>,
	linux-kernel@vger.kernel.org,
	Linux Memory Management <linux-mm@kvack.org>,
	devel@openvz.org, xfs@oss.sgi.com
Subject: Re: [PATCH]  incorrect error handling inside generic_file_direct_write
Date: Fri, 15 Dec 2006 10:43:41 +0000	[thread overview]
Message-ID: <20061215104341.GA20089@infradead.org> (raw)
In-Reply-To: <000001c71e60$7df9e010$e434030a@amr.corp.intel.com>

> +ssize_t
> +__generic_file_aio_write(struct kiocb *iocb, const struct iovec *iov,
> +				unsigned long nr_segs, loff_t pos)

I'd still call this generic_file_aio_write_nolock.

> +	loff_t		*ppos = &iocb->ki_pos;

I'd rather use iocb->ki_pos directly in the few places ppos is referenced
currently.

>  	if (ret > 0 && ((file->f_flags & O_SYNC) || IS_SYNC(inode))) {
> -		ssize_t err;
> -
>  		err = sync_page_range_nolock(inode, mapping, pos, ret);
>  		if (err < 0)
>  			ret = err;
>  	}

So we're doing the sync_page_range once in __generic_file_aio_write
with i_mutex held.


>  	mutex_lock(&inode->i_mutex);
> -	ret = __generic_file_aio_write_nolock(iocb, iov, nr_segs,
> -			&iocb->ki_pos);
> +	ret = __generic_file_aio_write(iocb, iov, nr_segs, pos);
>  	mutex_unlock(&inode->i_mutex);
>  
>  	if (ret > 0 && ((file->f_flags & O_SYNC) || IS_SYNC(inode))) {

And then another time after it's unlocked, this seems wrong.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-12-15 10:44 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-11 13:34 [PATCH] incorrect error handling inside generic_file_direct_write Dmitriy Monakhov
2006-12-11 13:34 ` Dmitriy Monakhov
2006-12-11 12:38 ` [Devel] " Kirill Korotaev
2006-12-11 12:38   ` Kirill Korotaev
2006-12-11 20:40 ` Andrew Morton
2006-12-11 20:40   ` Andrew Morton
2006-12-11 20:40   ` Andrew Morton
2006-12-12  9:22   ` Dmitriy Monakhov
2006-12-12  9:22     ` Dmitriy Monakhov
2006-12-12  9:22     ` Dmitriy Monakhov
2006-12-12  6:36     ` Andrew Morton
2006-12-12  6:36       ` Andrew Morton
2006-12-12  6:36       ` Andrew Morton
2006-12-12 12:20   ` Dmitriy Monakhov
2006-12-12 12:20     ` Dmitriy Monakhov
2006-12-12 12:20     ` Dmitriy Monakhov
2006-12-12  9:52     ` Andrew Morton
2006-12-12  9:52       ` Andrew Morton
2006-12-12  9:52       ` Andrew Morton
2006-12-12 13:18       ` Dmitriy Monakhov
2006-12-12 13:18         ` Dmitriy Monakhov
2006-12-12 10:40         ` Andrew Morton
2006-12-12 10:40           ` Andrew Morton
2006-12-12 10:40           ` Andrew Morton
2006-12-12 23:14           ` Dmitriy Monakhov
2006-12-12 23:14             ` Dmitriy Monakhov
2006-12-13  2:43           ` Chen, Kenneth W
2006-12-13  2:43             ` Chen, Kenneth W
2006-12-13  2:43             ` Chen, Kenneth W
2006-12-15 10:43             ` 'Christoph Hellwig' [this message]
2006-12-15 10:43               ` 'Christoph Hellwig'
2006-12-15 18:53               ` Chen, Kenneth W
2006-12-15 18:53                 ` Chen, Kenneth W
2006-12-15 18:53                 ` Chen, Kenneth W
2007-01-02 11:17                 ` 'Christoph Hellwig'
2007-01-02 11:17                   ` 'Christoph Hellwig'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061215104341.GA20089@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@osdl.org \
    --cc=devel@openvz.org \
    --cc=dmonakhov@openvz.org \
    --cc=dmonakhov@sw.ru \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.