[PATCH] qemu-dm monitor doesn't support the quit command

[PATCH] qemu-dm monitor doesn't support the quit command

[Kasai Takanori]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Hi All,

It is natural that there is quit command in original QEMU. 
However, I don't think that the HVM domain on Xen is necessary.
Because there is a possibility of shutting down GuestOS due to the mistake. 
I think that I should prohibit the quit command of qemu-dm. 

Thanks

--
Takanori Kasai

[-- Attachment #2: qemu-monitor-quit.patch --]
[-- Type: application/octet-stream, Size: 643 bytes --]

# HG changeset patch
# User kasai.takanori@jp.fujitsu.com
# Node ID ef195d27a54ef7d5e256788d5a1a51ee55e2bcf6
# Parent  360eb996fa38319867a74bf581c734a80bf6839d
qemu-dm monitor doesn't support the quit command.

diff -r 360eb996fa38 -r ef195d27a54e tools/ioemu/monitor.c
--- a/tools/ioemu/monitor.c	Wed Dec 13 16:13:26 2006 +0000
+++ b/tools/ioemu/monitor.c	Thu Dec 21 12:08:18 2006 +0900
@@ -309,8 +309,7 @@ static void do_info_history (void)
 
 static void do_quit(void)
 {
-    destroy_hvm_domain();
-    exit(0);
+    term_printf("quit is not supported\n");
 }
 
 static int eject_device(BlockDriverState *bs, int force)

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] qemu-dm monitor doesn't support the quit command

[Kasai Takanori]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi All,

> It is natural that there is quit command in original QEMU. 
> However, I don't think that the HVM domain on Xen is necessary.
> Because there is a possibility of shutting down GuestOS due to the mistake. 
> I think that I should prohibit the quit command of qemu-dm. 

So as to refuse the quit command, the patch was corrected. 
If there is any problem, please let me know.

Thanks

--
Takanori Kasai

[-- Attachment #2: qemu-monitor-quit.patch --]
[-- Type: application/octet-stream, Size: 1173 bytes --]

# HG changeset patch
# User kasai.takanori@jp.fujitsu.com
# Node ID 333949ed3a785141e4ae046d95483fcf185e5836
# Parent  367f0c6efe2178e26ba0194ca795ff098e22a80b
qemu-dm monitor does not support the quit command

Signed-off-by: Takanori Kasai <Kasai.Takanori@jp.fujitsu.com>

diff -r 367f0c6efe21 -r 333949ed3a78 tools/ioemu/monitor.c
--- a/tools/ioemu/monitor.c	Sat Dec 23 21:32:05 2006 +0000
+++ b/tools/ioemu/monitor.c	Mon Dec 25 09:23:01 2006 +0900
@@ -305,12 +305,6 @@ static void do_info_history (void)
 	term_printf("%d: '%s'\n", i, str);
         i++;
     }
-}
-
-static void do_quit(void)
-{
-    destroy_hvm_domain();
-    exit(0);
 }
 
 static int eject_device(BlockDriverState *bs, int force)
@@ -1158,8 +1152,6 @@ static term_cmd_t term_cmds[] = {
       "", "commit changes to the disk images (if -snapshot is used)" },
     { "info", "s?", do_info,
       "subcommand", "show various information about the system state" },
-    { "q|quit", "", do_quit,
-      "", "quit the emulator" },
     { "eject", "-fB", do_eject,
       "[-f] device", "eject a removable media (use -f to force it)" },
     { "change", "BF", do_change,

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] qemu-dm monitor doesn't support the quit command

[Kasai Takanori]

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

Hi All,

I sent the following patches the other day.
This patch makes qemu-dm monitor not support the quit command.
Because there is a possibility of shutting down HVM Domain by mistake.
We think that the HVM domain should shut down by xm shutdown/destroy command.
Could you apply this patch?


Thanks,

--
Takanori Kasai


----- Original Message ----- 
From: "Kasai Takanori" <kasai.takanori@jp.fujitsu.com>
To: "xen-devel" <xen-devel@lists.xensource.com>
Sent: Monday, December 25, 2006 10:47 AM
Subject: Re: [Xen-devel] [PATCH] qemu-dm monitor doesn't support the quit 
command


> Hi All,
>
>> It is natural that there is quit command in original QEMU.
>> However, I don't think that the HVM domain on Xen is necessary.
>> Because there is a possibility of shutting down GuestOS due to the mistake.
>> I think that I should prohibit the quit command of qemu-dm.
>
> So as to refuse the quit command, the patch was corrected.
> If there is any problem, please let me know.
>
> Thanks
>
> --
> Takanori Kasai

[-- Attachment #2: qemu-monitor-quit.patch --]
[-- Type: application/octet-stream, Size: 1173 bytes --]

# HG changeset patch
# User kasai.takanori@jp.fujitsu.com
# Node ID 333949ed3a785141e4ae046d95483fcf185e5836
# Parent  367f0c6efe2178e26ba0194ca795ff098e22a80b
qemu-dm monitor does not support the quit command

Signed-off-by: Takanori Kasai <Kasai.Takanori@jp.fujitsu.com>

diff -r 367f0c6efe21 -r 333949ed3a78 tools/ioemu/monitor.c
--- a/tools/ioemu/monitor.c	Sat Dec 23 21:32:05 2006 +0000
+++ b/tools/ioemu/monitor.c	Mon Dec 25 09:23:01 2006 +0900
@@ -305,12 +305,6 @@ static void do_info_history (void)
 	term_printf("%d: '%s'\n", i, str);
         i++;
     }
-}
-
-static void do_quit(void)
-{
-    destroy_hvm_domain();
-    exit(0);
 }
 
 static int eject_device(BlockDriverState *bs, int force)
@@ -1158,8 +1152,6 @@ static term_cmd_t term_cmds[] = {
       "", "commit changes to the disk images (if -snapshot is used)" },
     { "info", "s?", do_info,
       "subcommand", "show various information about the system state" },
-    { "q|quit", "", do_quit,
-      "", "quit the emulator" },
     { "eject", "-fB", do_eject,
       "[-f] device", "eject a removable media (use -f to force it)" },
     { "change", "BF", do_change,

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] qemu-dm monitor doesn't support the quit command

[Zhai, Edwin]

quit command is useful when we have no host console(e.g. qemu window on a remote 
X). and it's a normal exit that is different from xm destroy(by KILL sig).

maybe we can change "q" to "quit" to avoid typo? or provide confirm info?

BTW, "q" is most popular command when we debug qemu device model:)

On Wed, Jan 10, 2007 at 12:03:24PM +0900, Kasai Takanori wrote:
> Hi All,
> 
> I sent the following patches the other day.
> This patch makes qemu-dm monitor not support the quit command.
> Because there is a possibility of shutting down HVM Domain by mistake.
> We think that the HVM domain should shut down by xm shutdown/destroy 
> command.
> Could you apply this patch?
> 
> 
> Thanks,
> 
> --
> Takanori Kasai
> 
> 
> ----- Original Message ----- 
> From: "Kasai Takanori" <kasai.takanori@jp.fujitsu.com>
> To: "xen-devel" <xen-devel@lists.xensource.com>
> Sent: Monday, December 25, 2006 10:47 AM
> Subject: Re: [Xen-devel] [PATCH] qemu-dm monitor doesn't support the quit 
> command
> 
> 
> >Hi All,
> >
> >>It is natural that there is quit command in original QEMU.
> >>However, I don't think that the HVM domain on Xen is necessary.
> >>Because there is a possibility of shutting down GuestOS due to the 
> >>mistake.
> >>I think that I should prohibit the quit command of qemu-dm.
> >
> >So as to refuse the quit command, the patch was corrected.
> >If there is any problem, please let me know.
> >
> >Thanks
> >
> >--
> >Takanori Kasai


> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel


-- 
best rgds,
edwin

Re: [PATCH] qemu-dm monitor doesn't support the quit command

[Kasai Takanori]

Hi Edwin,

Thank you for reply.

> quit command is useful when we have no host console(e.g. qemu window on a 
> remote
> X). and it's a normal exit that is different from xm destroy(by KILL sig).
>
> maybe we can change "q" to "quit" to avoid typo? or provide confirm info?
>
> BTW, "q" is most popular command when we debug qemu device model:)

I understood the "quit" or "q" command was necessary for debugging.
However, there is a possibility that the user shuts down the HVM domain by 
mistake.

Cannot you change "quit" or "q" to "quitdomain"?

Thanks,

--
Takanori Kasai

Re: [PATCH] qemu-dm monitor doesn't support the quit command

[Kasai Takanori]

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

Hi All,

I made the patch that changed it from quit or q to quitdomain. 
I think that the HVM domain can be prevented being shutted down 
by the mistake in this patch. 
If there is any problem, please let me know.

>> quit command is useful when we have no host console(e.g. qemu window on a 
>> remote
>> X). and it's a normal exit that is different from xm destroy(by KILL sig).
>>
>> maybe we can change "q" to "quit" to avoid typo? or provide confirm info?
>>
>> BTW, "q" is most popular command when we debug qemu device model:)
> 
> I understood the "quit" or "q" command was necessary for debugging.
> However, there is a possibility that the user shuts down the HVM domain by 
> mistake.
> 
> Cannot you change "quit" or "q" to "quitdomain"?

Thanks,

--
Takanori Kasai

[-- Attachment #2: qemu-monitor-quitdomain.patch --]
[-- Type: application/octet-stream, Size: 949 bytes --]

# HG changeset patch
# User kasai.takanori@jp.fujitsu.com
# Date 1169002068 -32400
# Node ID fa6a0785562dc576933f82aceab43628a877dbc0
# Parent  895d873a00b47cb7b0edf3d0b6a42f47a3f4854c
quit or q command is changed to the quitdomain on qemu-dm monitor

Signed-off-by: Takanori Kasai <Kasai.Takanori@jp.fujitsu.com>

diff -r 895d873a00b4 -r fa6a0785562d tools/ioemu/monitor.c
--- a/tools/ioemu/monitor.c	Tue Jan 16 10:02:50 2007 +0000
+++ b/tools/ioemu/monitor.c	Wed Jan 17 11:47:48 2007 +0900
@@ -1158,7 +1158,7 @@ static term_cmd_t term_cmds[] = {
       "", "commit changes to the disk images (if -snapshot is used)" },
     { "info", "s?", do_info,
       "subcommand", "show various information about the system state" },
-    { "q|quit", "", do_quit,
+    { "quitdomain", "", do_quit,
       "", "quit the emulator" },
     { "eject", "-fB", do_eject,
       "[-f] device", "eject a removable media (use -f to force it)" },

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] qemu-dm monitor doesn't support the quit command

[Anthony Liguori]

Kasai Takanori wrote:
> Hi All,
> 
> I made the patch that changed it from quit or q to quitdomain. I think 
> that the HVM domain can be prevented being shutted down by the mistake 
> in this patch. If there is any problem, please let me know.

It seems to me that this is just one more thing to get us further away
from the upstream QEMU tree and to me, that's a bad thing.  It's not
this one patch in particular but once you get enough of these, it starts
getting hairy.

If you really thing the q command is poorly named, I think you should
make that case to the QEMU community.  It really isn't a Xen specific issue.

If this really is a problem for you, couldn't you just keep the patch
around for your own use?  I haven't seen anyone else complain of this
issue before so I'm not sure it will do anything but confuse other people.

Regards,

Anthony Liguori

>>> quit command is useful when we have no host console(e.g. qemu window 
>>> on a remote
>>> X). and it's a normal exit that is different from xm destroy(by KILL 
>>> sig).
>>>
>>> maybe we can change "q" to "quit" to avoid typo? or provide confirm 
>>> info?
>>>
>>> BTW, "q" is most popular command when we debug qemu device model:)
>>
>> I understood the "quit" or "q" command was necessary for debugging.
>> However, there is a possibility that the user shuts down the HVM 
>> domain by mistake.
>>
>> Cannot you change "quit" or "q" to "quitdomain"?
> 
> Thanks,
> 
> -- 
> Takanori Kasai
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

Re: [PATCH] qemu-dm monitor doesn't support the quit command

[Kasai Takanori]

Hi Anthony,

Thank you for reply.
I want to achieve it by other methods.

>> I made the patch that changed it from quit or q to quitdomain. I think
>> that the HVM domain can be prevented being shutted down by the mistake
>> in this patch. If there is any problem, please let me know.
>
> It seems to me that this is just one more thing to get us further away
> from the upstream QEMU tree and to me, that's a bad thing.  It's not
> this one patch in particular but once you get enough of these, it starts
> getting hairy.

I also think certainly like that.

> If you really thing the q command is poorly named, I think you should
> make that case to the QEMU community.  It really isn't a Xen specific issue.

It is natural that there is quit command in original QEMU.
 I do not think the agreement in the QEMU community.

> If this really is a problem for you, couldn't you just keep the patch
> around for your own use?  I haven't seen anyone else complain of this
> issue before so I'm not sure it will do anything but confuse other people.

It was thought that it was necessary for the user's using by the operational 
aspect.

Thanks,

--
Takanori Kasai