All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Kristian Hoegsberg <krh@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Stefan Richter <stefanr@s5r6.in-berlin.de>,
	linux1394-devel@lists.sourceforge.net
Subject: [-mm patch] drivers/firewire/: cleanups
Date: Mon, 22 Jan 2007 19:17:37 +0100	[thread overview]
Message-ID: <20070122181736.GU9093@stusta.de> (raw)
In-Reply-To: <20070111222627.66bb75ab.akpm@osdl.org>

On Thu, Jan 11, 2007 at 10:26:27PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.20-rc3-mm1:
>...
>  git-ieee1394.patch
>...
>  git trees
>...


This patch contains the following cleanups:
- "extern inline" -> "static inline"
- fw-topology.c: make struct fw_node_create static

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/firewire/fw-ohci.c        |    8 ++++----
 drivers/firewire/fw-topology.c    |    2 +-
 drivers/firewire/fw-topology.h    |    6 +++---
 drivers/firewire/fw-transaction.c |    2 +-
 drivers/firewire/fw-transaction.h |    2 +-
 5 files changed, 10 insertions(+), 10 deletions(-)

--- linux-2.6.20-rc4-mm1/drivers/firewire/fw-topology.c.old	2007-01-22 18:27:12.000000000 +0100
+++ linux-2.6.20-rc4-mm1/drivers/firewire/fw-topology.c	2007-01-22 18:27:21.000000000 +0100
@@ -92,7 +92,7 @@
 	return (sid[index] >> shift) & 0x03;
 }
 
-struct fw_node *fw_node_create(u32 sid, int port_count, int color)
+static struct fw_node *fw_node_create(u32 sid, int port_count, int color)
 {
 	struct fw_node *node;
 
--- linux-2.6.20-rc4-mm1/drivers/firewire/fw-transaction.c.old	2007-01-22 18:27:45.000000000 +0100
+++ linux-2.6.20-rc4-mm1/drivers/firewire/fw-transaction.c	2007-01-22 18:27:54.000000000 +0100
@@ -106,7 +106,7 @@
 	}
 }
 
-void
+static void
 fw_fill_packet(struct fw_packet *packet, int tcode, int tlabel,
 	       int node_id, int generation, int speed,
 	       unsigned long long offset, void *payload, size_t length)
--- linux-2.6.20-rc4-mm1/drivers/firewire/fw-transaction.h.old	2007-01-22 18:29:01.000000000 +0100
+++ linux-2.6.20-rc4-mm1/drivers/firewire/fw-transaction.h	2007-01-22 18:29:13.000000000 +0100
@@ -198,7 +198,7 @@
         void *callback_data;
 };
 
-extern inline struct fw_packet *
+static inline struct fw_packet *
 fw_packet(struct list_head *l)
 {
         return list_entry (l, struct fw_packet, link);
--- linux-2.6.20-rc4-mm1/drivers/firewire/fw-topology.h.old	2007-01-22 18:29:39.000000000 +0100
+++ linux-2.6.20-rc4-mm1/drivers/firewire/fw-topology.h	2007-01-22 18:29:43.000000000 +0100
@@ -57,13 +57,13 @@
         struct fw_port ports[0];
 };
 
-extern inline struct fw_node *
+static inline struct fw_node *
 fw_node(struct list_head *l)
 {
         return list_entry (l, struct fw_node, link);
 }
 
-extern inline struct fw_node *
+static inline struct fw_node *
 fw_node_get(struct fw_node *node)
 {
 	atomic_inc(&node->ref_count);
@@ -71,7 +71,7 @@
 	return node;
 }
 
-extern inline void
+static inline void
 fw_node_put(struct fw_node *node)
 {
 	if (atomic_dec_and_test(&node->ref_count))
--- linux-2.6.20-rc4-mm1/drivers/firewire/fw-ohci.c.old	2007-01-22 18:32:58.000000000 +0100
+++ linux-2.6.20-rc4-mm1/drivers/firewire/fw-ohci.c	2007-01-22 18:33:02.000000000 +0100
@@ -147,7 +147,7 @@
 	struct iso_context *ir_context_list;
 };
 
-extern inline struct fw_ohci *fw_ohci(struct fw_card *card)
+static inline struct fw_ohci *fw_ohci(struct fw_card *card)
 {
 	return container_of(card, struct fw_ohci, card);
 }
@@ -174,17 +174,17 @@
 
 static char ohci_driver_name[] = KBUILD_MODNAME;
 
-extern inline void reg_write(const struct fw_ohci *ohci, int offset, u32 data)
+static inline void reg_write(const struct fw_ohci *ohci, int offset, u32 data)
 {
 	writel(data, ohci->registers + offset);
 }
 
-extern inline u32 reg_read(const struct fw_ohci *ohci, int offset)
+static inline u32 reg_read(const struct fw_ohci *ohci, int offset)
 {
 	return readl(ohci->registers + offset);
 }
 
-extern inline void flush_writes(const struct fw_ohci *ohci)
+static inline void flush_writes(const struct fw_ohci *ohci)
 {
 	/* Do a dummy read to flush writes. */
 	reg_read(ohci, OHCI1394_Version);



  parent reply	other threads:[~2007-01-22 18:17 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-12  6:26 2.6.20-rc4-mm1 Andrew Morton
2007-01-12 10:20 ` Early ACPI lockup (was Re: 2.6.20-rc4-mm1) Frederik Deweerdt
2007-01-12 22:53   ` Len Brown
2007-01-12 23:10     ` Frederik Deweerdt
2007-01-12 23:36       ` Jiri Slaby
2007-01-13  0:08         ` Michal Piotrowski
2007-01-13  0:45           ` Frederik Deweerdt
2007-01-13  0:43         ` Jiri Slaby
2007-01-12 10:25 ` 2.6.20-rc4-mm1 Mariusz Kozlowski
2007-01-12 13:18   ` 2.6.20-rc4-mm1 Frederik Deweerdt
2007-01-12 15:13     ` 2.6.20-rc4-mm1 Mariusz Kozlowski
2007-01-12 15:16       ` 2.6.20-rc4-mm1 Michal Piotrowski
2007-01-12 16:12         ` 2.6.20-rc4-mm1 Mariusz Kozlowski
2007-01-12 10:52 ` 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1) Sander
2007-01-12 11:28   ` Paul Jackson
2007-01-12 19:25     ` Christoph Lameter
2007-01-12 21:20       ` Paul Jackson
2007-01-12 21:28         ` Christoph Lameter
2007-01-12 21:58           ` Paul Jackson
2007-01-12 22:00             ` Christoph Lameter
2007-01-12 22:10               ` Paul Jackson
2007-01-12 22:11               ` Andrew Morton
2007-01-12 11:55 ` spurious sparse warnings from linux/aio.h (was: 2.6.20-rc4-mm1) Tilman Schmidt
2007-01-12 13:11   ` Suparna Bhattacharya
2007-01-12 17:46     ` spurious sparse warnings from linux/aio.h Tilman Schmidt
2007-01-12 13:33 ` [-mm patch] remove tcp header from tcp_v4_check Frederik Deweerdt
2007-01-12 13:55   ` [-mm patch] remove tcp header from tcp_v4_check (take #2) Frederik Deweerdt
2007-02-05  0:44     ` David Miller
2007-01-13  7:27 ` 2.6.20-rc4-mm1: status of sn9c102_pas202bca? Adrian Bunk
2007-01-15 11:34   ` Mauro Carvalho Chehab
2007-01-13  9:56 ` [-mm patch] make mmc_sysfs.c:mmc_key_type static Adrian Bunk
2007-01-13 22:38   ` Pierre Ossman
2007-01-13  9:56 ` [Cluster-devel] [-mm patch] make gfs2_change_nlink_i() static Adrian Bunk
2007-01-13  9:56   ` Adrian Bunk
2007-01-15 10:31   ` [Cluster-devel] " Steven Whitehouse
2007-01-15 10:31     ` Steven Whitehouse
2007-01-16 21:04   ` [Cluster-devel] " Wendy Cheng
2007-01-16 21:04     ` Wendy Cheng
2007-01-16 21:29     ` Adrian Bunk
2007-01-16 21:29       ` Adrian Bunk
2007-01-14  9:10 ` 2.6.20-rc4-mm1: different values for OHCI_QUIRK_ZFMICRO Adrian Bunk
2007-01-14 14:36   ` David Brownell
2007-02-20  0:06     ` Adrian Bunk
2007-03-29 22:06       ` Randy Dunlap
2007-03-29 22:24         ` David Brownell
2007-05-08 22:17           ` [PATCH] " Randy Dunlap
2007-05-08 22:34             ` David Brownell
2007-05-08 22:37             ` Greg KH
2007-03-30 15:18         ` 2.6.20-rc4-mm1: " Tony Olech
2007-01-14  9:48 ` 2.6.20-rc4-mm1 Thomas Gleixner
2007-01-14 10:46   ` 2.6.20-rc4-mm1 Thomas Gleixner
2007-01-14 14:40     ` 2.6.20-rc4-mm1 Thomas Gleixner
2007-01-14 22:05       ` 2.6.20-rc4-mm1 Jens Axboe
2007-01-14 22:31         ` 2.6.20-rc4-mm1 Thomas Gleixner
2007-01-14 22:30           ` 2.6.20-rc4-mm1 Jens Axboe
2007-01-15  8:22             ` 2.6.20-rc4-mm1 Ingo Molnar
2007-01-15 23:55               ` 2.6.20-rc4-mm1 Jens Axboe
2007-01-14 22:20       ` 2.6.20-rc4-mm1 Jens Axboe
2007-01-14 23:52 ` i810fb fails to load (was: 2.6.20-rc4-mm1) Tilman Schmidt
2007-01-15  0:22   ` Andrew Morton
2007-01-15  0:22     ` Andrew Morton
2007-01-22 13:42     ` i810fb fails to load Thomas Hellström
2007-01-22 18:30       ` Tilman Schmidt
2007-01-22 21:50       ` Dave Airlie
2007-01-23  8:10         ` Thomas Hellström
2007-01-23  8:10           ` Thomas Hellström
2007-01-18 21:55 ` [-mm patch] fs/unionfs/: possible cleanups Adrian Bunk
2007-01-20 22:06   ` Josef Sipek
2007-01-19 18:40 ` [-mm patch] drivers/mtd/ubi/: " Adrian Bunk
2007-01-19 18:40   ` Adrian Bunk
2007-01-21 11:23   ` Artem Bityutskiy
2007-01-20 22:38 ` [-mm patch] oops in drivers/net/shaper.c Frederik Deweerdt
2007-01-21 19:13 ` [-mm patch] remove one remaining "#define BCM_TSO 1" Adrian Bunk
2007-01-22 18:17 ` Adrian Bunk [this message]
2007-01-22 19:41   ` [-mm patch] drivers/firewire/: cleanups Kristian Høgsberg
2007-01-22 20:04     ` Adrian Bunk
2007-01-22 20:04       ` Kristian Høgsberg
2007-01-22 20:44         ` Stefan Richter
2007-01-23  6:02 ` `make htmldocs` fails Don Mullis
2007-01-23  6:22   ` Randy Dunlap
2007-01-23  6:45     ` `make htmldocs` fails -- 2.6.20-rc4-mm1 Don Mullis
2007-01-23  6:35   ` `make htmldocs` fails Greg KH
2007-01-24 13:53 ` 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error Adrian Bunk
2007-01-24 14:12   ` Sergei Shtylyov
2007-02-17 19:26     ` Sergei Shtylyov
2007-02-17 19:32       ` Sergei Shtylyov
2007-02-26 13:22         ` Sergei Shtylyov
2007-02-26 17:26           ` Randy Dunlap
2007-02-26 21:14             ` Greg KH
2007-03-06 16:15               ` Sergei Shtylyov
2007-03-06 16:47                 ` Randy Dunlap
2007-03-09 12:54                   ` Tejun Heo
2007-01-24 22:36 ` [-mm patch] MTD_CK804XROM must depend on PCI Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070122181736.GU9093@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=krh@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.