From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>,
Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org
Subject: [-mm patch] drivers/mtd/ubi/: possible cleanups
Date: Fri, 19 Jan 2007 19:40:48 +0100 [thread overview]
Message-ID: <20070119184048.GR9093@stusta.de> (raw)
In-Reply-To: <20070111222627.66bb75ab.akpm@osdl.org>
On Thu, Jan 11, 2007 at 10:26:27PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.20-rc3-mm1:
>...
> git-ubi.patch
>...
> git trees
>...
This patch contains the following possible cleanups:
- make needlessly global code static
- remove the following unused variable:
- debug.c: alloc_prints
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
BTW: Do you really need that many different
CONFIG_MTD_UBI_DEBUG_* options?
drivers/mtd/ubi/cdev.c | 4 +-
drivers/mtd/ubi/debug.c | 57 ++++++++++++++++++----------------------
2 files changed, 28 insertions(+), 33 deletions(-)
--- linux-2.6.20-rc4-mm1/drivers/mtd/ubi/cdev.c.old 2007-01-19 17:49:47.000000000 +0100
+++ linux-2.6.20-rc4-mm1/drivers/mtd/ubi/cdev.c 2007-01-19 17:50:03.000000000 +0100
@@ -47,7 +47,7 @@
static int vol_cdev_open(struct inode *inode, struct file *file);
static int vol_cdev_release(struct inode *inode, struct file *file);
-loff_t vol_cdev_llseek(struct file *file, loff_t offset, int origin);
+static loff_t vol_cdev_llseek(struct file *file, loff_t offset, int origin);
static ssize_t vol_cdev_read(struct file *file, __user char *buf,
size_t count, loff_t * offp);
static ssize_t vol_cdev_write(struct file *file, const char __user *buf,
@@ -224,7 +224,7 @@
* positive offset in case of success and a negative error code in case of
* failure.
*/
-loff_t vol_cdev_llseek(struct file *file, loff_t offset, int origin)
+static loff_t vol_cdev_llseek(struct file *file, loff_t offset, int origin)
{
const struct ubi_vtbl_vtr *vtr;
struct ubi_vol_desc *desc = file->private_data;
--- linux-2.6.20-rc4-mm1/drivers/mtd/ubi/debug.c.old 2007-01-19 17:50:42.000000000 +0100
+++ linux-2.6.20-rc4-mm1/drivers/mtd/ubi/debug.c 2007-01-19 18:43:59.000000000 +0100
@@ -67,74 +67,69 @@
static int vb_err_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_UIF
-int uif_prints = 1;
+static int uif_prints = 1;
#else
-int uif_prints;
+static int uif_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_CDEV
-int cdev_prints = 1;
+static int cdev_prints = 1;
#else
-int cdev_prints;
+static int cdev_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_GLUEBI
-int gluebi_prints = 1;
+static int gluebi_prints = 1;
#else
-int gluebi_prints;
+static int gluebi_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_VMT
-int vmt_prints = 1;
+static int vmt_prints = 1;
#else
-int vmt_prints;
+static int vmt_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_UPD
-int upd_prints = 1;
+static int upd_prints = 1;
#else
-int upd_prints;
+static int upd_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_VTBL
-int vtbl_prints = 1;
+static int vtbl_prints = 1;
#else
-int vtbl_prints;
+static int vtbl_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_ACC
-int acc_prints = 1;
+static int acc_prints = 1;
#else
-int acc_prints;
+static int acc_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_EBA
-int eba_prints = 1;
+static int eba_prints = 1;
#else
-int eba_prints;
+static int eba_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_WL
-int wl_prints = 1;
+static int wl_prints = 1;
#else
-int wl_prints;
+static int wl_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_BGT
-int bgt_prints = 1;
+static int bgt_prints = 1;
#else
-int bgt_prints;
-#endif
-#ifdef CONFIG_MTD_UBI_DEBUG_MSG_ALLOC
-int alloc_prints = 1;
-#else
-int alloc_prints;
+static int bgt_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_IO
-int io_prints = 1;
+static int io_prints = 1;
#else
-int io_prints;
+static int io_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_BLD
-int bld_prints = 1;
+static int bld_prints = 1;
#else
-int bld_prints;
+static int bld_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_SCAN
-int scan_prints = 1;
+static int scan_prints = 1;
#else
-int scan_prints;
+static int scan_prints;
#endif
/* If debugging messages should also go to the console */
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>,
Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: linux-kernel@vger.kernel.org, dwmw2@infradead.org,
linux-mtd@lists.infradead.org
Subject: [-mm patch] drivers/mtd/ubi/: possible cleanups
Date: Fri, 19 Jan 2007 19:40:48 +0100 [thread overview]
Message-ID: <20070119184048.GR9093@stusta.de> (raw)
In-Reply-To: <20070111222627.66bb75ab.akpm@osdl.org>
On Thu, Jan 11, 2007 at 10:26:27PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.20-rc3-mm1:
>...
> git-ubi.patch
>...
> git trees
>...
This patch contains the following possible cleanups:
- make needlessly global code static
- remove the following unused variable:
- debug.c: alloc_prints
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
BTW: Do you really need that many different
CONFIG_MTD_UBI_DEBUG_* options?
drivers/mtd/ubi/cdev.c | 4 +-
drivers/mtd/ubi/debug.c | 57 ++++++++++++++++++----------------------
2 files changed, 28 insertions(+), 33 deletions(-)
--- linux-2.6.20-rc4-mm1/drivers/mtd/ubi/cdev.c.old 2007-01-19 17:49:47.000000000 +0100
+++ linux-2.6.20-rc4-mm1/drivers/mtd/ubi/cdev.c 2007-01-19 17:50:03.000000000 +0100
@@ -47,7 +47,7 @@
static int vol_cdev_open(struct inode *inode, struct file *file);
static int vol_cdev_release(struct inode *inode, struct file *file);
-loff_t vol_cdev_llseek(struct file *file, loff_t offset, int origin);
+static loff_t vol_cdev_llseek(struct file *file, loff_t offset, int origin);
static ssize_t vol_cdev_read(struct file *file, __user char *buf,
size_t count, loff_t * offp);
static ssize_t vol_cdev_write(struct file *file, const char __user *buf,
@@ -224,7 +224,7 @@
* positive offset in case of success and a negative error code in case of
* failure.
*/
-loff_t vol_cdev_llseek(struct file *file, loff_t offset, int origin)
+static loff_t vol_cdev_llseek(struct file *file, loff_t offset, int origin)
{
const struct ubi_vtbl_vtr *vtr;
struct ubi_vol_desc *desc = file->private_data;
--- linux-2.6.20-rc4-mm1/drivers/mtd/ubi/debug.c.old 2007-01-19 17:50:42.000000000 +0100
+++ linux-2.6.20-rc4-mm1/drivers/mtd/ubi/debug.c 2007-01-19 18:43:59.000000000 +0100
@@ -67,74 +67,69 @@
static int vb_err_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_UIF
-int uif_prints = 1;
+static int uif_prints = 1;
#else
-int uif_prints;
+static int uif_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_CDEV
-int cdev_prints = 1;
+static int cdev_prints = 1;
#else
-int cdev_prints;
+static int cdev_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_GLUEBI
-int gluebi_prints = 1;
+static int gluebi_prints = 1;
#else
-int gluebi_prints;
+static int gluebi_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_VMT
-int vmt_prints = 1;
+static int vmt_prints = 1;
#else
-int vmt_prints;
+static int vmt_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_UPD
-int upd_prints = 1;
+static int upd_prints = 1;
#else
-int upd_prints;
+static int upd_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_VTBL
-int vtbl_prints = 1;
+static int vtbl_prints = 1;
#else
-int vtbl_prints;
+static int vtbl_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_ACC
-int acc_prints = 1;
+static int acc_prints = 1;
#else
-int acc_prints;
+static int acc_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_EBA
-int eba_prints = 1;
+static int eba_prints = 1;
#else
-int eba_prints;
+static int eba_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_WL
-int wl_prints = 1;
+static int wl_prints = 1;
#else
-int wl_prints;
+static int wl_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_BGT
-int bgt_prints = 1;
+static int bgt_prints = 1;
#else
-int bgt_prints;
-#endif
-#ifdef CONFIG_MTD_UBI_DEBUG_MSG_ALLOC
-int alloc_prints = 1;
-#else
-int alloc_prints;
+static int bgt_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_IO
-int io_prints = 1;
+static int io_prints = 1;
#else
-int io_prints;
+static int io_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_BLD
-int bld_prints = 1;
+static int bld_prints = 1;
#else
-int bld_prints;
+static int bld_prints;
#endif
#ifdef CONFIG_MTD_UBI_DEBUG_MSG_SCAN
-int scan_prints = 1;
+static int scan_prints = 1;
#else
-int scan_prints;
+static int scan_prints;
#endif
/* If debugging messages should also go to the console */
next prev parent reply other threads:[~2007-01-19 18:41 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-12 6:26 2.6.20-rc4-mm1 Andrew Morton
2007-01-12 10:20 ` Early ACPI lockup (was Re: 2.6.20-rc4-mm1) Frederik Deweerdt
2007-01-12 22:53 ` Len Brown
2007-01-12 23:10 ` Frederik Deweerdt
2007-01-12 23:36 ` Jiri Slaby
2007-01-13 0:08 ` Michal Piotrowski
2007-01-13 0:45 ` Frederik Deweerdt
2007-01-13 0:43 ` Jiri Slaby
2007-01-12 10:25 ` 2.6.20-rc4-mm1 Mariusz Kozlowski
2007-01-12 13:18 ` 2.6.20-rc4-mm1 Frederik Deweerdt
2007-01-12 15:13 ` 2.6.20-rc4-mm1 Mariusz Kozlowski
2007-01-12 15:16 ` 2.6.20-rc4-mm1 Michal Piotrowski
2007-01-12 16:12 ` 2.6.20-rc4-mm1 Mariusz Kozlowski
2007-01-12 10:52 ` 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1) Sander
2007-01-12 11:28 ` Paul Jackson
2007-01-12 19:25 ` Christoph Lameter
2007-01-12 21:20 ` Paul Jackson
2007-01-12 21:28 ` Christoph Lameter
2007-01-12 21:58 ` Paul Jackson
2007-01-12 22:00 ` Christoph Lameter
2007-01-12 22:10 ` Paul Jackson
2007-01-12 22:11 ` Andrew Morton
2007-01-12 11:55 ` spurious sparse warnings from linux/aio.h (was: 2.6.20-rc4-mm1) Tilman Schmidt
2007-01-12 13:11 ` Suparna Bhattacharya
2007-01-12 17:46 ` spurious sparse warnings from linux/aio.h Tilman Schmidt
2007-01-12 13:33 ` [-mm patch] remove tcp header from tcp_v4_check Frederik Deweerdt
2007-01-12 13:55 ` [-mm patch] remove tcp header from tcp_v4_check (take #2) Frederik Deweerdt
2007-02-05 0:44 ` David Miller
2007-01-13 7:27 ` 2.6.20-rc4-mm1: status of sn9c102_pas202bca? Adrian Bunk
2007-01-15 11:34 ` Mauro Carvalho Chehab
2007-01-13 9:56 ` [-mm patch] make mmc_sysfs.c:mmc_key_type static Adrian Bunk
2007-01-13 22:38 ` Pierre Ossman
2007-01-13 9:56 ` [Cluster-devel] [-mm patch] make gfs2_change_nlink_i() static Adrian Bunk
2007-01-13 9:56 ` Adrian Bunk
2007-01-15 10:31 ` [Cluster-devel] " Steven Whitehouse
2007-01-15 10:31 ` Steven Whitehouse
2007-01-16 21:04 ` [Cluster-devel] " Wendy Cheng
2007-01-16 21:04 ` Wendy Cheng
2007-01-16 21:29 ` Adrian Bunk
2007-01-16 21:29 ` Adrian Bunk
2007-01-14 9:10 ` 2.6.20-rc4-mm1: different values for OHCI_QUIRK_ZFMICRO Adrian Bunk
2007-01-14 14:36 ` David Brownell
2007-02-20 0:06 ` Adrian Bunk
2007-03-29 22:06 ` Randy Dunlap
2007-03-29 22:24 ` David Brownell
2007-05-08 22:17 ` [PATCH] " Randy Dunlap
2007-05-08 22:34 ` David Brownell
2007-05-08 22:37 ` Greg KH
2007-03-30 15:18 ` 2.6.20-rc4-mm1: " Tony Olech
2007-01-14 9:48 ` 2.6.20-rc4-mm1 Thomas Gleixner
2007-01-14 10:46 ` 2.6.20-rc4-mm1 Thomas Gleixner
2007-01-14 14:40 ` 2.6.20-rc4-mm1 Thomas Gleixner
2007-01-14 22:05 ` 2.6.20-rc4-mm1 Jens Axboe
2007-01-14 22:31 ` 2.6.20-rc4-mm1 Thomas Gleixner
2007-01-14 22:30 ` 2.6.20-rc4-mm1 Jens Axboe
2007-01-15 8:22 ` 2.6.20-rc4-mm1 Ingo Molnar
2007-01-15 23:55 ` 2.6.20-rc4-mm1 Jens Axboe
2007-01-14 22:20 ` 2.6.20-rc4-mm1 Jens Axboe
2007-01-14 23:52 ` i810fb fails to load (was: 2.6.20-rc4-mm1) Tilman Schmidt
2007-01-15 0:22 ` Andrew Morton
2007-01-15 0:22 ` Andrew Morton
2007-01-22 13:42 ` i810fb fails to load Thomas Hellström
2007-01-22 18:30 ` Tilman Schmidt
2007-01-22 21:50 ` Dave Airlie
2007-01-23 8:10 ` Thomas Hellström
2007-01-23 8:10 ` Thomas Hellström
2007-01-18 21:55 ` [-mm patch] fs/unionfs/: possible cleanups Adrian Bunk
2007-01-20 22:06 ` Josef Sipek
2007-01-19 18:40 ` Adrian Bunk [this message]
2007-01-19 18:40 ` [-mm patch] drivers/mtd/ubi/: " Adrian Bunk
2007-01-21 11:23 ` Artem Bityutskiy
2007-01-20 22:38 ` [-mm patch] oops in drivers/net/shaper.c Frederik Deweerdt
2007-01-21 19:13 ` [-mm patch] remove one remaining "#define BCM_TSO 1" Adrian Bunk
2007-01-22 18:17 ` [-mm patch] drivers/firewire/: cleanups Adrian Bunk
2007-01-22 19:41 ` Kristian Høgsberg
2007-01-22 20:04 ` Adrian Bunk
2007-01-22 20:04 ` Kristian Høgsberg
2007-01-22 20:44 ` Stefan Richter
2007-01-23 6:02 ` `make htmldocs` fails Don Mullis
2007-01-23 6:22 ` Randy Dunlap
2007-01-23 6:45 ` `make htmldocs` fails -- 2.6.20-rc4-mm1 Don Mullis
2007-01-23 6:35 ` `make htmldocs` fails Greg KH
2007-01-24 13:53 ` 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error Adrian Bunk
2007-01-24 14:12 ` Sergei Shtylyov
2007-02-17 19:26 ` Sergei Shtylyov
2007-02-17 19:32 ` Sergei Shtylyov
2007-02-26 13:22 ` Sergei Shtylyov
2007-02-26 17:26 ` Randy Dunlap
2007-02-26 21:14 ` Greg KH
2007-03-06 16:15 ` Sergei Shtylyov
2007-03-06 16:47 ` Randy Dunlap
2007-03-09 12:54 ` Tejun Heo
2007-01-24 22:36 ` [-mm patch] MTD_CK804XROM must depend on PCI Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070119184048.GR9093@stusta.de \
--to=bunk@stusta.de \
--cc=Artem.Bityutskiy@nokia.com \
--cc=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.