From: Johannes Berg <johannes@sipsolutions.net>
To: linuxppc-dev@ozlabs.org
Cc: linux-pm@lists.osdl.org
Subject: [PATCH 04/12] powerpc: mark pages that dont exist as Nosave
Date: Wed, 07 Feb 2007 13:45:40 +0100 [thread overview]
Message-ID: <20070207124611.630390000@sipsolutions.net> (raw)
In-Reply-To: 20070207124536.963531000@sipsolutions.net
[-- Attachment #1: powerpc-mark-nonram-nosave.patch --]
[-- Type: text/plain, Size: 1664 bytes --]
On some powerpc architectures (notably 64-bit powermac) there is a memory
hole, for example on powermacs between 2G and 4G. Since we use the flat
memory model regardless, these pages must be marked as Nosave (for suspend
to disk.)
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
---
This replaces swsusp-dont-copy-pages-that-arent-ram.patch and works just as
well, except that it doesn't modify the generic code.
Tested on powerbook and powermac.
--- linux-2.6-git.orig/arch/powerpc/mm/mem.c 2007-02-07 02:55:03.319884289 +0100
+++ linux-2.6-git/arch/powerpc/mm/mem.c 2007-02-07 02:55:30.496884289 +0100
@@ -284,6 +284,27 @@ void __init do_init_bootmem(void)
init_bootmem_done = 1;
}
+/* mark lowmem pages that don't exist as nosave, highmem
+ * pages always exist but aren't treated as RAM pages */
+static int __init mark_nonram_nosave(void)
+{
+ struct zone *zone;
+ unsigned long pfn, max_zone_pfn;
+
+ for_each_zone(zone) {
+ if (is_highmem(zone))
+ continue;
+
+ max_zone_pfn = zone->zone_start_pfn + zone->spanned_pages;
+
+ for (pfn = zone->zone_start_pfn; pfn < max_zone_pfn; pfn++)
+ if (!page_is_ram(pfn))
+ SetPageNosave(pfn_to_page(pfn));
+ }
+
+ return 0;
+}
+
/*
* paging_init() sets up the page tables - in fact we've already done this.
*/
@@ -315,6 +336,8 @@ void __init paging_init(void)
max_zone_pfns[ZONE_DMA] = top_of_ram >> PAGE_SHIFT;
#endif
free_area_init_nodes(max_zone_pfns);
+
+ mark_nonram_nosave();
}
#endif /* ! CONFIG_NEED_MULTIPLE_NODES */
--
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: linuxppc-dev@ozlabs.org
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, linux-pm@lists.osdl.org
Subject: [PATCH 04/12] powerpc: mark pages that dont exist as Nosave
Date: Wed, 07 Feb 2007 13:45:40 +0100 [thread overview]
Message-ID: <20070207124611.630390000@sipsolutions.net> (raw)
In-Reply-To: 20070207124536.963531000@sipsolutions.net
On some powerpc architectures (notably 64-bit powermac) there is a memory
hole, for example on powermacs between 2G and 4G. Since we use the flat
memory model regardless, these pages must be marked as Nosave (for suspend
to disk.)
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
---
This replaces swsusp-dont-copy-pages-that-arent-ram.patch and works just as
well, except that it doesn't modify the generic code.
Tested on powerbook and powermac.
--- linux-2.6-git.orig/arch/powerpc/mm/mem.c 2007-02-07 02:55:03.319884289 +0100
+++ linux-2.6-git/arch/powerpc/mm/mem.c 2007-02-07 02:55:30.496884289 +0100
@@ -284,6 +284,27 @@ void __init do_init_bootmem(void)
init_bootmem_done = 1;
}
+/* mark lowmem pages that don't exist as nosave, highmem
+ * pages always exist but aren't treated as RAM pages */
+static int __init mark_nonram_nosave(void)
+{
+ struct zone *zone;
+ unsigned long pfn, max_zone_pfn;
+
+ for_each_zone(zone) {
+ if (is_highmem(zone))
+ continue;
+
+ max_zone_pfn = zone->zone_start_pfn + zone->spanned_pages;
+
+ for (pfn = zone->zone_start_pfn; pfn < max_zone_pfn; pfn++)
+ if (!page_is_ram(pfn))
+ SetPageNosave(pfn_to_page(pfn));
+ }
+
+ return 0;
+}
+
/*
* paging_init() sets up the page tables - in fact we've already done this.
*/
@@ -315,6 +336,8 @@ void __init paging_init(void)
max_zone_pfns[ZONE_DMA] = top_of_ram >> PAGE_SHIFT;
#endif
free_area_init_nodes(max_zone_pfns);
+
+ mark_nonram_nosave();
}
#endif /* ! CONFIG_NEED_MULTIPLE_NODES */
--
next prev parent reply other threads:[~2007-02-07 12:45 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-07 12:45 [PATCH 00/12] powerpc/powermac power management patches Johannes Berg
2007-02-07 12:45 ` [PATCH 01/12] powerpc: MPIC sys_device & suspend/resume Johannes Berg
2007-02-07 12:45 ` Johannes Berg
2007-02-07 12:45 ` [PATCH 02/12] powermac: support G5 CPU hotplug Johannes Berg
2007-02-07 12:45 ` Johannes Berg
2007-02-08 13:14 ` Johannes Berg
2007-02-08 13:14 ` Johannes Berg
2007-02-08 13:28 ` Johannes Berg
2007-02-08 15:38 ` Johannes Berg
2007-02-08 15:38 ` Johannes Berg
2007-02-08 21:59 ` Paul Mackerras
2007-02-08 21:59 ` [linux-pm] " Paul Mackerras
2007-02-08 22:33 ` Benjamin Herrenschmidt
2007-02-08 22:33 ` [linux-pm] " Benjamin Herrenschmidt
2007-02-09 15:39 ` Johannes Berg
2007-02-09 15:39 ` [linux-pm] " Johannes Berg
2007-02-08 22:24 ` Benjamin Herrenschmidt
2007-02-08 22:24 ` Benjamin Herrenschmidt
2007-02-09 15:36 ` Johannes Berg
2007-02-09 15:36 ` Johannes Berg
2007-02-12 15:15 ` Johannes Berg
2007-02-15 3:44 ` Paul Mackerras
2007-02-15 15:08 ` Johannes Berg
2007-02-15 15:08 ` Johannes Berg
2007-02-15 19:43 ` Johannes Berg
2007-02-14 14:45 ` Pavel Machek
2007-02-14 14:45 ` [linux-pm] " Pavel Machek
2007-02-14 19:11 ` Johannes Berg
2007-02-14 19:11 ` [linux-pm] " Johannes Berg
2007-02-14 21:27 ` Benjamin Herrenschmidt
2007-02-14 21:27 ` [linux-pm] " Benjamin Herrenschmidt
2007-02-07 12:45 ` [PATCH 03/12] powerpc: dart iommu suspend Johannes Berg
2007-02-07 12:45 ` Johannes Berg
2007-02-07 12:45 ` Johannes Berg [this message]
2007-02-07 12:45 ` [PATCH 04/12] powerpc: mark pages that dont exist as Nosave Johannes Berg
2007-02-07 12:45 ` [PATCH 05/12] power management: no valid states w/o pm_ops + docs Johannes Berg
2007-02-07 12:45 ` Johannes Berg
2007-02-13 12:12 ` Pavel Machek
2007-02-13 12:12 ` Pavel Machek
2007-02-13 16:08 ` Johannes Berg
2007-02-13 16:08 ` Johannes Berg
2007-02-13 16:14 ` Pavel Machek
2007-02-13 16:14 ` Pavel Machek
2007-02-07 12:45 ` [PATCH 06/12] powerpc: fix suspend states again Johannes Berg
2007-02-07 12:45 ` Johannes Berg
2007-02-07 12:45 ` [PATCH 07/12] powermac: suspend to disk on G5 Johannes Berg
2007-02-07 12:45 ` Johannes Berg
2007-02-07 12:45 ` [PATCH 08/12] powermac: fix G5-cpufreq for cpu on/offline Johannes Berg
2007-02-07 12:45 ` Johannes Berg
2007-02-07 12:45 ` [PATCH 09/12] powerpc: remove bogus comment about page_is_ram Johannes Berg
2007-02-07 12:45 ` Johannes Berg
2007-02-07 12:45 ` [PATCH 10/12] powerpc: remove unneeded exports in mem.c Johannes Berg
2007-02-07 12:45 ` Johannes Berg
2007-02-08 4:25 ` Paul Mackerras
2007-02-08 13:10 ` Johannes Berg
2007-02-08 13:10 ` Johannes Berg
2007-02-08 13:27 ` [PATCH 10/12] powerpc: remove unneeded page_is_ram export Johannes Berg
2007-02-07 12:45 ` [PATCH 11/12] powermac: disallow pmu sleep notifiers from aborting sleep Johannes Berg
2007-02-07 12:45 ` Johannes Berg
2007-02-07 22:52 ` Andreas Schwab
2007-02-08 13:08 ` Johannes Berg
2007-02-08 13:08 ` Johannes Berg
2007-02-08 13:16 ` Johannes Berg
2007-02-08 13:16 ` Johannes Berg
2007-02-07 12:45 ` [PATCH 12/12] powermac: proper sleep management Johannes Berg
2007-02-07 12:45 ` Johannes Berg
2007-02-08 13:16 ` [PATCH 13/12] mpic: add affinity callback for IPI "chip" Johannes Berg
2007-02-08 21:14 ` Benjamin Herrenschmidt
2007-02-09 15:41 ` Johannes Berg
2007-02-09 15:41 ` Johannes Berg
2007-02-12 15:20 ` [PATCH 13/12] mpic: set IPIs to be per-CPU Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070207124611.630390000@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-pm@lists.osdl.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.