All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@suse.cz>
To: Milind Choudhary <milindchoudhary@gmail.com>
Cc: kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org,
	dmitry.torokhov@gmail.com, linux-input@atrey.karlin.mff.cuni.cz,
	linux-joystick@atrey.karlin.mff.cuni.cz
Subject: Re: [KJ] [RFC][PATCH] BIT macro cleanup
Date: Sat, 24 Feb 2007 10:46:38 +0000	[thread overview]
Message-ID: <20070224104638.GA3609@suse.cz> (raw)
In-Reply-To: <3b44d3fb0702230014x4ee4a1dewdc624c54b3635e15@mail.gmail.com>

On Fri, Feb 23, 2007 at 01:44:41PM +0530, Milind Choudhary wrote:
> Hi all
> 	working towards the cleanup of BIT macro,
> I've added one to <linux/bitops.h> & cleaned some obvious users.
> 
> include/linux/input.h also has a BIT macro
> which does a wrap
> so currently i've done something like
> 
> +#undef BIT
> #define BIT(nr)        (1UL << ((nr) % BITS_PER_LONG))
 
Since the previous definition of

#define BIT(nr)		(1UL << (nr))

gives the same results as the above one for all reasonable usage
scenarios (you don't want to supply nr larger than BITS_PER_LONG),
why not just use the modulo version everywhere?

The only problem I see is that the compiler would not warn where nr IS
too large.

-- 
Vojtech Pavlik
Director SuSE Labs
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Vojtech Pavlik <vojtech@suse.cz>
To: Milind Choudhary <milindchoudhary@gmail.com>
Cc: kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org,
	dmitry.torokhov@gmail.com, linux-input@atrey.karlin.mff.cuni.cz,
	linux-joystick@atrey.karlin.mff.cuni.cz
Subject: Re: [KJ][RFC][PATCH] BIT macro cleanup
Date: Sat, 24 Feb 2007 11:46:38 +0100	[thread overview]
Message-ID: <20070224104638.GA3609@suse.cz> (raw)
In-Reply-To: <3b44d3fb0702230014x4ee4a1dewdc624c54b3635e15@mail.gmail.com>

On Fri, Feb 23, 2007 at 01:44:41PM +0530, Milind Choudhary wrote:
> Hi all
> 	working towards the cleanup of BIT macro,
> I've added one to <linux/bitops.h> & cleaned some obvious users.
> 
> include/linux/input.h also has a BIT macro
> which does a wrap
> so currently i've done something like
> 
> +#undef BIT
> #define BIT(nr)        (1UL << ((nr) % BITS_PER_LONG))
 
Since the previous definition of

#define BIT(nr)		(1UL << (nr))

gives the same results as the above one for all reasonable usage
scenarios (you don't want to supply nr larger than BITS_PER_LONG),
why not just use the modulo version everywhere?

The only problem I see is that the compiler would not warn where nr IS
too large.

-- 
Vojtech Pavlik
Director SuSE Labs

  parent reply	other threads:[~2007-02-24 10:46 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3b44d3fb0702222056k1d2a9b57q69a3555a09a9058e@mail.gmail.com>
2007-02-23  8:14 ` [KJ][RFC][PATCH] BIT macro cleanup Milind Choudhary
2007-02-23  8:26   ` [KJ] [RFC][PATCH] " Milind Choudhary
2007-02-23  8:56   ` Richard Knutsson
2007-02-23  8:56     ` [KJ][RFC][PATCH] " Richard Knutsson
2007-02-23 10:15     ` Milind Choudhary
2007-02-23 10:27       ` [KJ] [RFC][PATCH] " Milind Choudhary
2007-02-23 14:10       ` Richard Knutsson
2007-02-23 14:10         ` [KJ][RFC][PATCH] " Richard Knutsson
2007-02-23 14:57         ` [KJ] [RFC][PATCH] " Dmitry Torokhov
2007-02-23 14:57           ` [KJ][RFC][PATCH] " Dmitry Torokhov
2007-02-23 16:08           ` [KJ] [RFC][PATCH] " Richard Knutsson
2007-02-23 16:08             ` [KJ][RFC][PATCH] " Richard Knutsson
2007-02-23 17:05             ` [KJ] [RFC][PATCH] " Dmitry Torokhov
2007-02-23 17:05               ` [KJ][RFC][PATCH] " Dmitry Torokhov
2007-02-23 18:15               ` [KJ] [RFC][PATCH] " Richard Knutsson
2007-02-23 18:15                 ` [KJ][RFC][PATCH] " Richard Knutsson
2007-02-23 18:37                 ` [KJ] [RFC][PATCH] " Dmitry Torokhov
2007-02-23 18:37                   ` [KJ][RFC][PATCH] " Dmitry Torokhov
2007-02-23 19:11                   ` [KJ] [RFC][PATCH] " Richard Knutsson
2007-02-23 19:11                     ` [KJ][RFC][PATCH] " Richard Knutsson
2007-02-23 21:58                     ` [KJ] [RFC][PATCH] " Dmitry Torokhov
2007-02-23 21:58                       ` [KJ][RFC][PATCH] " Dmitry Torokhov
2007-02-23 22:43                       ` [KJ] [RFC][PATCH] " Richard Knutsson
2007-02-23 22:43                         ` [KJ][RFC][PATCH] " Richard Knutsson
2007-02-24 11:11                         ` [KJ] [RFC][PATCH] " Vojtech Pavlik
2007-02-24 11:11                           ` [KJ][RFC][PATCH] " Vojtech Pavlik
2007-02-24 12:59                           ` [KJ] [RFC][PATCH] " Richard Knutsson
2007-02-24 12:59                             ` [KJ][RFC][PATCH] " Richard Knutsson
2007-02-25  3:39                             ` [KJ] [RFC][PATCH] " Dmitry Torokhov
2007-02-25  3:39                               ` [KJ][RFC][PATCH] " Dmitry Torokhov
2007-02-24 19:11                           ` Milind Arun Choudhary
2007-02-24 19:23                             ` [KJ] [RFC][PATCH] " Milind Arun Choudhary
2007-02-25 15:45                             ` Richard Knutsson
2007-02-25 15:45                               ` [KJ][RFC][PATCH] " Richard Knutsson
2007-02-25  3:37                           ` [KJ] [RFC][PATCH] " Dmitry Torokhov
2007-02-25  3:37                             ` [KJ][RFC][PATCH] " Dmitry Torokhov
2007-02-24 10:46   ` Vojtech Pavlik [this message]
2007-02-24 10:46     ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070224104638.GA3609@suse.cz \
    --to=vojtech@suse.cz \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-joystick@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=milindchoudhary@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.