All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: ibm-acpi-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org,
	lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] RFC: conversion of ibm-acpi to hwmon sysfs
Date: Thu, 1 Mar 2007 08:10:59 +0100	[thread overview]
Message-ID: <20070301081059.ebe93462.khali@linux-fr.org> (raw)
In-Reply-To: <20070228143836.GC30168@khazad-dum.debian.net>

On Wed, 28 Feb 2007 11:38:36 -0300, Henrique de Moraes Holschuh wrote:
> Ok, I have fan*_* and temp*_input hanging directly from the device (no
> groups).  However, that device has a lot of other stuff that is not even
> remotely accounted for in hwmon, such as control of video outputs and
> hotkeys, the firmware action beeper, etc.
> 
> Does that cause problems for lm-sensors, or would it just ignore the extra
> attributes and groups?

As long as the other file names do not collide with the any of names in
Documentation/hwmon/sysfs-interface, it's OK. libsensors will ignore
the extra stuff.

> I can provide two devices, ibm-acpi.0 and ibm-acpi.1, and have the hwmon
> attributes in only one of them, and register just that one with the hwmon
> class.  Would that be better/safer?

A single device would be fine. In the long run we will probbaly have to
turn the hwmon attributes into class attributes anyway, so they will
get their own naming space.

-- 
Jean Delvare

WARNING: multiple messages have this Message-ID (diff)
From: khali@linux-fr.org (Jean Delvare)
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: ibm-acpi-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org,
	lm-sensors@lm-sensors.org
Subject: [lm-sensors] RFC: conversion of ibm-acpi to hwmon sysfs
Date: Thu, 01 Mar 2007 07:10:59 +0000	[thread overview]
Message-ID: <20070301081059.ebe93462.khali@linux-fr.org> (raw)
In-Reply-To: <20070228143836.GC30168@khazad-dum.debian.net>

On Wed, 28 Feb 2007 11:38:36 -0300, Henrique de Moraes Holschuh wrote:
> Ok, I have fan*_* and temp*_input hanging directly from the device (no
> groups).  However, that device has a lot of other stuff that is not even
> remotely accounted for in hwmon, such as control of video outputs and
> hotkeys, the firmware action beeper, etc.
> 
> Does that cause problems for lm-sensors, or would it just ignore the extra
> attributes and groups?

As long as the other file names do not collide with the any of names in
Documentation/hwmon/sysfs-interface, it's OK. libsensors will ignore
the extra stuff.

> I can provide two devices, ibm-acpi.0 and ibm-acpi.1, and have the hwmon
> attributes in only one of them, and register just that one with the hwmon
> class.  Would that be better/safer?

A single device would be fine. In the long run we will probbaly have to
turn the hwmon attributes into class attributes anyway, so they will
get their own naming space.

-- 
Jean Delvare


  reply	other threads:[~2007-03-01  7:12 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-24 18:20 RFC: conversion of ibm-acpi to hwmon sysfs Henrique de Moraes Holschuh
2007-02-24 18:20 ` [lm-sensors] " Henrique de Moraes Holschuh
2007-02-26 16:27 ` Jean Delvare
2007-02-26 16:27   ` Jean Delvare
     [not found]   ` <20070226172716.b2e956b7.khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
2007-02-26 18:06     ` Henrique de Moraes Holschuh
2007-02-26 18:06       ` Henrique de Moraes Holschuh
2007-02-27  9:01       ` Jean Delvare
2007-02-27  9:01         ` Jean Delvare
2007-02-27 15:41         ` Henrique de Moraes Holschuh
2007-02-27 15:41           ` Henrique de Moraes Holschuh
2007-02-28 14:38     ` Henrique de Moraes Holschuh
2007-02-28 14:38       ` Henrique de Moraes Holschuh
2007-03-01  7:10       ` Jean Delvare [this message]
2007-03-01  7:10         ` Jean Delvare
2007-02-28  9:31   ` Zhang Rui
2007-02-28  9:31     ` Zhang Rui
2007-02-28 14:34     ` Conversion of ACPI fan+thermal " Henrique de Moraes Holschuh
2007-02-28 14:34       ` [lm-sensors] " Henrique de Moraes Holschuh
2007-03-01  9:37       ` Zhang Rui
2007-03-02  1:12       ` Zhang Rui
2007-03-02  1:12         ` [lm-sensors] " Zhang Rui
2007-03-02 11:13         ` Jean Delvare
2007-03-02 11:13           ` [lm-sensors] " Jean Delvare
2007-03-02 11:43           ` Matthew Garrett
2007-03-02 11:43             ` [lm-sensors] " Matthew Garrett
2007-03-08  9:28           ` Zhang Rui
2007-03-08  9:28             ` [lm-sensors] " Zhang Rui
2007-03-08 11:13             ` Hans de Goede
2007-03-08 11:13               ` Hans de Goede
2007-03-08 13:13             ` Henrique de Moraes Holschuh
2007-03-08 13:13               ` [lm-sensors] " Henrique de Moraes Holschuh
2007-03-09  8:53               ` Jean Delvare
2007-03-09  8:53                 ` [lm-sensors] " Jean Delvare
2007-03-01  7:06     ` [lm-sensors] RFC: conversion of ibm-acpi " Jean Delvare
2007-03-01  7:06       ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070301081059.ebe93462.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.