All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH] Fix typo on variable name $newref should be $newrev in sample update hook
Date: Fri, 2 Mar 2007 10:27:00 +0000	[thread overview]
Message-ID: <200703021027.00203.andyparkins@gmail.com> (raw)

The log message would be empty for new branches because git-rev-list was
being passed $newref instead of the correct variable $newrev.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
 templates/hooks--update |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/templates/hooks--update b/templates/hooks--update
index fd1f73d..2a707e5 100644
--- a/templates/hooks--update
+++ b/templates/hooks--update
@@ -148,7 +148,7 @@ case "$refname_type" in
 			# This shows all log entries that are not already covered by
 			# another ref - i.e. commits that are now accessible from this
 			# ref that were previously not accessible
-			git-rev-parse --not --all | git-rev-list --stdin --pretty $newref
+			git-rev-parse --not --all | git-rev-list --stdin --pretty $newrev
 			echo $LOGEND
 		else
 			# oldrev is valid
-- 
1.5.0.2.205.g74e20

             reply	other threads:[~2007-03-02 12:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-02 10:27 Andy Parkins [this message]
2007-03-02 16:44 ` [PATCH] Fix typo on variable name $newref should be $newrev in sample update hook Linus Torvalds
2007-03-02 19:25   ` Andy Parkins
2007-03-02 19:29   ` [PATCH] Remove use of git-rev-parse and replace git-rev-list --pretty with git-log Andy Parkins
2007-03-02 20:48     ` Linus Torvalds
2007-03-02 23:10     ` Junio C Hamano
2007-03-03  8:25       ` Andy Parkins
2007-03-03 11:52         ` Junio C Hamano
2007-03-04 21:44           ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200703021027.00203.andyparkins@gmail.com \
    --to=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.