From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH] Remove use of git-rev-parse and replace git-rev-list --pretty with git-log
Date: Fri, 2 Mar 2007 19:29:20 +0000 [thread overview]
Message-ID: <200703021929.20969.andyparkins@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703020839350.3953@woody.linux-foundation.org>
Linus noticed:
--- >8 ---
it should just avoid git-rev-parse these days and do
git rev-list --pretty $newrev --not --all
instead. And quite frankly, rather than "git rev-list --pretty", there's
no real reason not to do
git log $newrev --not --all
--- 8< ---
This patch makes those changes.
Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
templates/hooks--update | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/templates/hooks--update b/templates/hooks--update
index 2a707e5..f580360 100644
--- a/templates/hooks--update
+++ b/templates/hooks--update
@@ -148,7 +148,7 @@ case "$refname_type" in
# This shows all log entries that are not already covered by
# another ref - i.e. commits that are now accessible from this
# ref that were previously not accessible
- git-rev-parse --not --all | git-rev-list --stdin --pretty $newrev
+ git log $newrev --not --all
echo $LOGEND
else
# oldrev is valid
@@ -165,7 +165,7 @@ case "$refname_type" in
baserev=$(git-merge-base $oldrev $newrev)
# Commit with a parent
- for rev in $(git-rev-parse --not --all | git-rev-list --stdin $newrev ^$baserev)
+ for rev in $(git-rev-list $newrev ^$baserev --not --all)
do
revtype=$(git-cat-file -t "$rev")
echo " via $rev ($revtype)"
@@ -190,8 +190,7 @@ case "$refname_type" in
fi
echo ""
echo $LOGBEGIN
- git-rev-parse --not --all |
- git-rev-list --stdin --pretty $newrev ^$baserev
+ git log $newrev ^$baserev --not --all
echo $LOGEND
echo ""
echo "Diffstat:"
--
1.5.0.rc4.gb4d2
next prev parent reply other threads:[~2007-03-02 19:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 10:27 [PATCH] Fix typo on variable name $newref should be $newrev in sample update hook Andy Parkins
2007-03-02 16:44 ` Linus Torvalds
2007-03-02 19:25 ` Andy Parkins
2007-03-02 19:29 ` Andy Parkins [this message]
2007-03-02 20:48 ` [PATCH] Remove use of git-rev-parse and replace git-rev-list --pretty with git-log Linus Torvalds
2007-03-02 23:10 ` Junio C Hamano
2007-03-03 8:25 ` Andy Parkins
2007-03-03 11:52 ` Junio C Hamano
2007-03-04 21:44 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703021929.20969.andyparkins@gmail.com \
--to=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.