All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Remove use of git-rev-parse and replace git-rev-list --pretty with git-log
Date: Fri, 02 Mar 2007 15:10:39 -0800	[thread overview]
Message-ID: <7vbqjbdyxc.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 200703021929.20969.andyparkins@gmail.com

Andy Parkins <andyparkins@gmail.com> writes:

> Linus noticed:
>
> --- >8 ---
> it should just avoid git-rev-parse these days and do
>
>   git rev-list --pretty $newrev --not --all
>
> instead. And quite frankly, rather than "git rev-list --pretty", there's
> no real reason not to do
>
>   git log $newrev --not --all
> --- 8< ---
>
> This patch makes those changes.
>
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>

Please look at your Subject: line above and ponder how it would
look in the next issue of "What's cooking in git.git".  Do I
have to spend extra brain cycles to go back to "git log --stat"
and realize that this one only updates a sample hook script?

Also, please don't do "--- >8 ---".  If you want to, please use
two dashes; this is purely for technical reasons.

I'll massage the log message and move "^$base --not" around as
Linus suggested, but next time please be a bit more careful.

  parent reply	other threads:[~2007-03-02 23:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-02 10:27 [PATCH] Fix typo on variable name $newref should be $newrev in sample update hook Andy Parkins
2007-03-02 16:44 ` Linus Torvalds
2007-03-02 19:25   ` Andy Parkins
2007-03-02 19:29   ` [PATCH] Remove use of git-rev-parse and replace git-rev-list --pretty with git-log Andy Parkins
2007-03-02 20:48     ` Linus Torvalds
2007-03-02 23:10     ` Junio C Hamano [this message]
2007-03-03  8:25       ` Andy Parkins
2007-03-03 11:52         ` Junio C Hamano
2007-03-04 21:44           ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbqjbdyxc.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.