All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Roland McGrath <roland@redhat.com>,
	Andi Kleen <ak@suse.de>, Rusty Russell <rusty@rustcorp.com.au>
Subject: [patch] paravirt: VDSO page is essential
Date: Mon, 5 Mar 2007 13:06:31 +0100	[thread overview]
Message-ID: <20070305120631.GA14105@elte.hu> (raw)

Subject: [patch] paravirt: VDSO page is essential
From: Ingo Molnar <mingo@elte.hu>

commit 3bbf54725467d604698721384d858b5983b87e8f disables the VDSO for 
CONFIG_PARAVIRT kernels. This #ifdeffery was a bad change: the VDSO is 
an essential component of Linux, and this change forces all of them to 
use int $0x80 - including sane ones like KVM. (If a hypervisor does not 
handle the VDSO properly then it can work things around via the vdso=0 
boot option. Or CONFIG_PARAVIRT should not have been merged. But in any 
case, it is a basic taste issue: we DO NOT #ifdef around core features 
like this!)

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/i386/kernel/sysenter.c |    4 ----
 1 file changed, 4 deletions(-)

Index: linux/arch/i386/kernel/sysenter.c
===================================================================
--- linux.orig/arch/i386/kernel/sysenter.c
+++ linux/arch/i386/kernel/sysenter.c
@@ -27,11 +27,7 @@
  * Should the kernel map a VDSO page into processes and pass its
  * address down to glibc upon exec()?
  */
-#ifdef CONFIG_PARAVIRT
-unsigned int __read_mostly vdso_enabled = 0;
-#else
 unsigned int __read_mostly vdso_enabled = 1;
-#endif
 
 EXPORT_SYMBOL_GPL(vdso_enabled);
 

             reply	other threads:[~2007-03-05 12:14 UTC|newest]

Thread overview: 123+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-05 12:06 Ingo Molnar [this message]
2007-03-05 12:36 ` [patch] paravirt: VDSO page is essential Avi Kivity
2007-03-05 12:40   ` Ingo Molnar
2007-03-05 13:00     ` Avi Kivity
2007-03-05 13:32       ` Rusty Russell
2007-03-05 14:28   ` Andi Kleen
2007-03-05 13:48     ` Ingo Molnar
2007-03-05 14:58       ` Andi Kleen
2007-03-05 13:59         ` Ingo Molnar
2007-03-05 14:10           ` Avi Kivity
2007-03-05 14:10             ` Ingo Molnar
2007-03-05 13:28 ` Rusty Russell
2007-03-05 13:38   ` Ingo Molnar
2007-03-05 14:34   ` Andi Kleen
2007-03-05 13:46     ` [patch] paravirt: re-enable COMPAT_VDSO Ingo Molnar
2007-03-05 13:48     ` [patch] paravirt: VDSO page is essential Ingo Molnar
2007-03-05 20:11     ` Zachary Amsden
2007-03-05 20:11       ` Zachary Amsden
2007-03-05 20:16       ` Andi Kleen
2007-03-05 20:33         ` Zachary Amsden
2007-03-05 20:19       ` Ingo Molnar
2007-03-05 20:19         ` Ingo Molnar
2007-03-05 20:42         ` Zachary Amsden
2007-03-05 20:42           ` Zachary Amsden
2007-03-06  0:57   ` Rusty Russell
2007-03-06  1:03     ` Zachary Amsden
2007-03-06  1:11       ` Rusty Russell
2007-03-06  1:11         ` Rusty Russell
2007-03-06  1:14       ` Jeremy Fitzhardinge
2007-03-06  1:51         ` Zachary Amsden
2007-03-06  1:53           ` Jeremy Fitzhardinge
2007-03-06  1:53             ` Jeremy Fitzhardinge
2007-03-06  8:19             ` Xen & VMI? Ingo Molnar
2007-03-06  8:19               ` Ingo Molnar
2007-03-06  8:37               ` Gerd Hoffmann
2007-03-06  8:48                 ` Zachary Amsden
2007-03-06  8:52                 ` Ingo Molnar
2007-03-06  8:52                   ` Ingo Molnar
2007-03-06  9:03                   ` Zachary Amsden
2007-03-06  9:03                     ` Zachary Amsden
2007-03-06  9:10                     ` Ingo Molnar
2007-03-06  9:10                       ` Ingo Molnar
2007-03-06  9:15                   ` Gerd Hoffmann
2007-03-06  9:15                     ` Gerd Hoffmann
2007-03-06  9:34                     ` Ingo Molnar
2007-03-06 10:15                       ` Gerd Hoffmann
2007-03-06 10:15                         ` Gerd Hoffmann
2007-03-06 10:26                         ` Ingo Molnar
2007-03-06 10:26                           ` Ingo Molnar
2007-03-06 11:04                           ` Gerd Hoffmann
2007-03-06 11:59                             ` Ingo Molnar
2007-03-06 12:34                               ` Gerd Hoffmann
2007-03-06 15:03                               ` Anthony Liguori
2007-03-06 15:03                                 ` Anthony Liguori
2007-03-06 17:17                                 ` Nakajima, Jun
2007-03-06 17:17                                   ` Nakajima, Jun
2007-03-06 17:32                                   ` Anthony Liguori
2007-03-06 20:37                                   ` Ingo Molnar
2007-03-06 21:02                                     ` Jeremy Fitzhardinge
2007-03-06 21:02                                       ` Jeremy Fitzhardinge
2007-03-06 21:11                                       ` Ingo Molnar
2007-03-06 21:11                                         ` Ingo Molnar
2007-03-06 21:13                                         ` Jeremy Fitzhardinge
2007-03-06 21:13                                           ` Jeremy Fitzhardinge
2007-03-06 21:20                                           ` Ingo Molnar
2007-03-06 21:20                                             ` Ingo Molnar
2007-03-06 21:46                                             ` Jeremy Fitzhardinge
2007-03-06 21:46                                               ` Jeremy Fitzhardinge
2007-03-06 21:35                                     ` Nakajima, Jun
2007-03-06 21:35                                       ` Nakajima, Jun
2007-03-07  0:44                                     ` Rusty Russell
2007-03-07  0:54                                       ` Anthony Liguori
2007-03-07  0:54                                         ` Anthony Liguori
2007-03-07  3:06                                       ` Zachary Amsden
2007-03-07  8:15                                       ` Ingo Molnar
2007-03-07  8:15                                         ` Ingo Molnar
2007-03-07  9:17                                         ` Zachary Amsden
2007-03-07 11:15                                           ` Thomas Gleixner
2007-03-07 19:14                                         ` Dan Hecht
2007-03-06 16:27                               ` Jeremy Fitzhardinge
2007-03-06 17:11                                 ` Ingo Molnar
2007-03-06 17:33                                   ` Jeremy Fitzhardinge
2007-03-07  2:16                                   ` Zachary Amsden
2007-03-07  2:16                                     ` Zachary Amsden
2007-03-06  9:55                     ` Avi Kivity
2007-03-06 10:23                       ` Gerd Hoffmann
2007-03-06 10:31                         ` Ingo Molnar
2007-03-06 19:46                   ` Chris Wright
2007-03-06 19:46                     ` Chris Wright
2007-03-06 20:30                     ` Ingo Molnar
2007-03-06 20:30                       ` Ingo Molnar
2007-03-06 20:53                       ` Chris Wright
2007-03-06 21:03                         ` Ingo Molnar
2007-03-06 21:03                           ` Ingo Molnar
2007-03-06 21:28                           ` Chris Wright
2007-03-06 21:28                             ` Chris Wright
2007-03-07  2:35                             ` Zachary Amsden
2007-03-07  2:35                               ` Zachary Amsden
2007-03-06  9:07               ` Jeremy Fitzhardinge
2007-03-06  9:07                 ` Jeremy Fitzhardinge
2007-03-06  9:26                 ` Ingo Molnar
2007-03-06  9:26                   ` Ingo Molnar
2007-03-06 16:42                   ` Jeremy Fitzhardinge
2007-03-06 16:42                     ` Jeremy Fitzhardinge
2007-03-06 17:18                     ` Ingo Molnar
2007-03-06 17:18                       ` Ingo Molnar
2007-03-06 18:04                       ` Jeremy Fitzhardinge
2007-03-06 18:04                         ` Jeremy Fitzhardinge
2007-03-06  7:35         ` [patch] paravirt: VDSO page is essential Ingo Molnar
2007-03-06  7:35           ` Ingo Molnar
2007-03-06  7:42           ` Zachary Amsden
2007-03-06  7:50             ` Ingo Molnar
2007-03-06  7:50               ` Ingo Molnar
2007-03-06 18:48             ` Jeremy Fitzhardinge
2007-03-06 18:48               ` Jeremy Fitzhardinge
2007-03-05 14:27 ` Andi Kleen
2007-03-05 21:58   ` Roland McGrath
2007-03-05 22:01     ` Jeremy Fitzhardinge
2007-03-05 22:58       ` Roland McGrath
2007-03-05 23:03         ` Jeremy Fitzhardinge
2007-03-06  8:34         ` Ingo Molnar
2007-03-06  9:13           ` Roland McGrath
2007-03-06  9:14             ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070305120631.GA14105@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.