From: Alan Cox <alan@redhat.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
akpm@linux-foundation.org, jeff@garzik.org,
linux-ide@vger.kernel.org, alan@redhat.com, lenb@kernel.org
Subject: Re: [patch 04/30] ACPI driver support for pata
Date: Tue, 6 Mar 2007 09:29:10 -0500 [thread overview]
Message-ID: <20070306142910.GB3732@devserv.devel.redhat.com> (raw)
In-Reply-To: <45ED783C.6060604@gmail.com>
On Tue, Mar 06, 2007 at 11:18:36PM +0900, Tejun Heo wrote:
> Actually, I have. I was thinking of higher level helpers. e.g.
> pacpi_cable_detect() in libata-acpi.c such that sata_nv's cable_detect
> can do.
There is no cable detect feature in ACPI, you try and set a mode and if it
lets you then the cable is probably there. That means you can't do
"pacpi_cable_detect" easily as a helper because you will corrupt all the timing
set up so far, and potentially on both drives.
I guess we could carefully set PIO 0 back on both and stick big warning signs
on the function about where to use it.
> So that it's more robust && we don't have to alternate between sata_nv,
> pata_acpi depending on BIOS/kernel configuration, and possibly combine
> other low level features with ACPI support.
Makes sense and its easy to move the code around once you are ready to do so.
next prev parent reply other threads:[~2007-03-06 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 10:37 [patch 04/30] ACPI driver support for pata akpm
2007-03-06 12:54 ` Tejun Heo
2007-03-06 15:14 ` Alan Cox
2007-03-06 14:18 ` Tejun Heo
2007-03-06 14:29 ` Alan Cox [this message]
2007-03-06 14:26 ` Jeff Garzik
2007-03-06 16:29 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070306142910.GB3732@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=lenb@kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.