All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Tejun Heo <htejun@gmail.com>,
	akpm@linux-foundation.org, linux-ide@vger.kernel.org,
	alan@redhat.com, lenb@kernel.org
Subject: Re: [patch 04/30] ACPI driver support for pata
Date: Tue, 06 Mar 2007 09:26:47 -0500	[thread overview]
Message-ID: <45ED7A27.3030504@garzik.org> (raw)
In-Reply-To: <20070306151415.45db1d52@lxorguk.ukuu.org.uk>

Alan Cox wrote:
>> using separate pata_acpi driver (we can definitely implement pata_acpi
>> using the helpers).  It will reduce general confusion and allow
>> combining acpi cable detection with specialized device handling (e.g.
>> ACPI cable detection combined with ADMA command operation).
> 
> Read the code Tejun, I did exactly that. pata_acpi is a driver which uses
> a nice clean set of helper methods I added to libata-acpi. pata_acpi
> itself knows nothing about ACPI other than calling into libata-acpi.

Tejun is just repeating what I've been saying:  you don't need a 
separate driver, call out from sata_nv or whereever instead.

	Jeff




  parent reply	other threads:[~2007-03-06 14:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-06 10:37 [patch 04/30] ACPI driver support for pata akpm
2007-03-06 12:54 ` Tejun Heo
2007-03-06 15:14   ` Alan Cox
2007-03-06 14:18     ` Tejun Heo
2007-03-06 14:29       ` Alan Cox
2007-03-06 14:26     ` Jeff Garzik [this message]
2007-03-06 16:29       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45ED7A27.3030504@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alan@redhat.com \
    --cc=htejun@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.