Re: [patch 04/30] ACPI driver support for pata

[Tejun Heo <htejun@gmail.com>]

Hello,

akpm@linux-foundation.org wrote:
> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> 
> - Add a driver for motherboard ACPI method devices
> 
> - Link it after normal drivers so ACPI is not preferred
> 
> - Hook the AMD driver to prefer ACPI for the Nvidia devices if ACPI is
>   active
> 
> - While we are at it fix up the simplex clear the AMD driver.
> 
> Depends upon the set_mode -> do_set_mode wrapper patch
> 
> Signed-off-by: Alan Cox <alan@redhat.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Cc: Tejun Heo <htejun@gmail.com>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---

Can't find the original posting, so replying here.  Alan, Jeff, can you
guys hold a bit with pata_acpi?  I think it's better to implement
helpers in libata-acpi and use them as necessary in sata_nv rather than
using separate pata_acpi driver (we can definitely implement pata_acpi
using the helpers).  It will reduce general confusion and allow
combining acpi cable detection with specialized device handling (e.g.
ACPI cable detection combined with ADMA command operation).

libata-acpi also needs quite some amount of other improvements.  I'll
post prototype code and things to discuss about later this week.

Thanks.

-- 
tejun