* [PATCH] drivers/usb/serial/mos7840.c: check kmalloc() return value.
@ 2007-03-09 7:18 Amit Choudhary
2007-03-09 8:14 ` Oliver Neukum
0 siblings, 1 reply; 2+ messages in thread
From: Amit Choudhary @ 2007-03-09 7:18 UTC (permalink / raw)
To: Linux Kernel
Description: Check the return value of kmalloc() in function mos7840_get_reg(), in file drivers/usb/serial/mos7840.c.
Signed-off-by: Amit Choudhary <amit2030@gmail.com>
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 021be39..91d474b 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -475,6 +475,14 @@ static int mos7840_get_reg(struct moschi
int ret = 0;
buffer = (__u8 *) mcs->ctrl_buf;
+ /* The memory for ctrl_buf is allocated in
+ * mos7840_startup(), but it is not checked if
+ * kmalloc failed. So, mcs->ctrl_buf might be NULL.
+ * So, it should be checked here.
+ */
+ if (!buffer)
+ return -ENOMEM;
+
// dr=(struct usb_ctrlrequest *)(buffer);
dr = (void *)(buffer + 2);
dr->bRequestType = MCS_RD_RTYPE;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/usb/serial/mos7840.c: check kmalloc() return value.
2007-03-09 7:18 [PATCH] drivers/usb/serial/mos7840.c: check kmalloc() return value Amit Choudhary
@ 2007-03-09 8:14 ` Oliver Neukum
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Neukum @ 2007-03-09 8:14 UTC (permalink / raw)
To: Amit Choudhary; +Cc: Linux Kernel
Am Freitag, 9. März 2007 08:18 schrieb Amit Choudhary:
> Description: Check the return value of kmalloc() in function mos7840_get_reg(), in file drivers/usb/serial/mos7840.c.
No, this is wrong. You must catch this at the source. The driver
cannot function if this function always returns -ENOMEM. It makes
no sense to start up the device under these circumstances.
Regards
Oliver
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-09 8:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-09 7:18 [PATCH] drivers/usb/serial/mos7840.c: check kmalloc() return value Amit Choudhary
2007-03-09 8:14 ` Oliver Neukum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.