[PATCH] drivers/usb/serial/mos7840.c: check kmalloc() return value.

[PATCH] drivers/usb/serial/mos7840.c: check kmalloc() return value.

[Amit Choudhary]

Description: Check the return value of kmalloc() in function mos7840_get_reg(), in file drivers/usb/serial/mos7840.c.

Signed-off-by: Amit Choudhary <amit2030@gmail.com>

diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 021be39..91d474b 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -475,6 +475,14 @@ static int mos7840_get_reg(struct moschi
 	int ret = 0;
 	buffer = (__u8 *) mcs->ctrl_buf;
 
+	/* The memory for ctrl_buf is allocated in
+	 * mos7840_startup(), but it is not checked if
+	 * kmalloc failed. So, mcs->ctrl_buf might be NULL.
+	 * So, it should be checked here.
+	 */
+	if (!buffer)
+		return -ENOMEM;
+
 //      dr=(struct usb_ctrlrequest *)(buffer);
 	dr = (void *)(buffer + 2);
 	dr->bRequestType = MCS_RD_RTYPE;

Re: [PATCH] drivers/usb/serial/mos7840.c: check kmalloc() return value.

[Oliver Neukum]

Am Freitag, 9. März 2007 08:18 schrieb Amit Choudhary:
> Description: Check the return value of kmalloc() in function mos7840_get_reg(), in file drivers/usb/serial/mos7840.c.

No, this is wrong. You must catch this at the source. The driver
cannot function if this function always returns -ENOMEM. It makes
no sense to start up the device under these circumstances.

	Regards
		Oliver