From: Andrew Morton <akpm@linux-foundation.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: virtualization@lists.osdl.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2/4] clean up identify_cpu
Date: Sat, 7 Apr 2007 02:14:01 -0700 [thread overview]
Message-ID: <20070407021401.a993892b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070406224204.782242327@goop.org>
On Fri, 06 Apr 2007 15:41:54 -0700 Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> identify_cpu() is used to identify both the boot CPU and secondary
> CPUs, but it performs some actions which only apply to the boot CPU.
> Those functions are therefore really __init functions, but because
> they're called by identify_cpu(), they must be marked __cpuinit.
>
> This patch splits identify_cpu() into identify_boot_cpu() and
> identify_secondary_cpu(), and calls the appropriate init functions
> from each. Also, identify_boot_cpu() and all the functions it
> dominates are marked __init.
x86_64 uses this too.
WARNING: arch/x86_64/kernel/built-in.o - Section mismatch: reference to .init.text:mtrr_bp_init from .text.identify_cpu after 'identify_cpu' (at offset 0x655)
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andi Kleen <ak@suse.de>,
virtualization@lists.osdl.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2/4] clean up identify_cpu
Date: Sat, 7 Apr 2007 02:14:01 -0700 [thread overview]
Message-ID: <20070407021401.a993892b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070406224204.782242327@goop.org>
On Fri, 06 Apr 2007 15:41:54 -0700 Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> identify_cpu() is used to identify both the boot CPU and secondary
> CPUs, but it performs some actions which only apply to the boot CPU.
> Those functions are therefore really __init functions, but because
> they're called by identify_cpu(), they must be marked __cpuinit.
>
> This patch splits identify_cpu() into identify_boot_cpu() and
> identify_secondary_cpu(), and calls the appropriate init functions
> from each. Also, identify_boot_cpu() and all the functions it
> dominates are marked __init.
x86_64 uses this too.
WARNING: arch/x86_64/kernel/built-in.o - Section mismatch: reference to .init.text:mtrr_bp_init from .text.identify_cpu after 'identify_cpu' (at offset 0x655)
next prev parent reply other threads:[~2007-04-07 9:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 22:41 [patch 0/4] Clean up asm/bugs.h, identify_cpu() and update COMPAT_VDSO Jeremy Fitzhardinge
2007-04-06 22:41 ` Jeremy Fitzhardinge
2007-04-06 22:41 ` [patch 1/4] Clean up asm-i386/bugs.h Jeremy Fitzhardinge
2007-04-06 22:41 ` Jeremy Fitzhardinge
2007-04-06 22:41 ` [patch 2/4] clean up identify_cpu Jeremy Fitzhardinge
2007-04-06 22:41 ` Jeremy Fitzhardinge
2007-04-07 9:14 ` Andrew Morton [this message]
2007-04-07 9:14 ` Andrew Morton
2007-04-07 17:20 ` Jeremy Fitzhardinge
2007-04-07 17:20 ` Jeremy Fitzhardinge
2007-04-07 17:59 ` Andrew Morton
2007-04-07 18:39 ` Sam Ravnborg
2007-04-07 18:39 ` Sam Ravnborg
2007-04-07 19:06 ` Andrew Morton
2007-04-06 22:41 ` [patch 3/4] Relocate VDSO ELF headers to match mapped location with COMPAT_VDSO Jeremy Fitzhardinge
2007-04-06 22:41 ` Jeremy Fitzhardinge
2007-04-06 22:41 ` [patch 4/4] Make COMPAT_VDSO runtime selectable Jeremy Fitzhardinge
2007-04-06 22:41 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070407021401.a993892b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.