PATCH: Don't use -q flag to bootloader if activating text console

PATCH: Don't use -q flag to bootloader if activating text console

[Daniel P. Berrange]

[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]

In Xen 3.0.3 series release, if one did 'xm create -c someguest' then you
would be shown the pygrub boot menu, allowing one to pick a kernel. If
you didn't use the -c arg, then it'd just pick the default kernel.

In Xen 3.0.5 testing, xm is forcing the addition of the '-q' flag whenever
the 'bootargs' parameter is not given in the config file. So if one does
not have 'bootargs' specified, and one uses 'xm create -c someguest' you
never get to see the pygrub boot menu.

The attached patch fixes 'xm create' so that it does not add the '-q' flag
to the bootloader args, if the '-c' flag is given to xm create. This makes
the default user experiance operate closer to user expectations

  Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

[-- Attachment #2: xen-bootloader-display.patch --]
[-- Type: text/plain, Size: 711 bytes --]

diff -r ee16cdeddade tools/python/xen/xm/create.py
--- a/tools/python/xen/xm/create.py	Wed Apr 25 10:39:08 2007 +0100
+++ b/tools/python/xen/xm/create.py	Thu Apr 26 17:10:50 2007 -0400
@@ -777,8 +777,11 @@ def make_config(vals):
         config.append(['bootloader', vals.bootloader])
         if vals.bootargs:
             config.append(['bootloader_args', vals.bootargs])
-        else: 
-            config.append(['bootloader_args', '-q'])        
+        else:
+            if vals.console_autoconnect:
+                config.append(['bootloader_args', ''])
+            else:
+                config.append(['bootloader_args', '-q'])
     config.append(['image', config_image])
 
     config_devs = []

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel