From: Andi Kleen <ak@novell.com>
To: Jeff Dike <jdike@addtoit.com>
Cc: akpm@osdl.org, LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [uml-devel] [PATCH 2/6] Create asm-i386/cmpxchg.h
Date: Wed, 2 May 2007 11:37:48 +0200 [thread overview]
Message-ID: <200705021137.48675.ak@novell.com> (raw)
In-Reply-To: <20070501182157.GA8348@c2.user-mode-linux.org>
On Tuesday 01 May 2007 20:21:57 Jeff Dike wrote:
> Rearrange the i386 cmpxchg code to allow atomic.h to get it without
> needing to include system.h. This kills warnings in the UML build
> from atomic.h about implicit declarations of cmpxchg symbols. The
> i386 build presumably isn't seeing this because a separate inclusion
> of system.h is covering it over.
>
> The cmpxchg stuff is moved to asm-i386/cmpxchg.h, with an include left
> in system.h for the benefit of generic code which expects cmpxchg
> there.
>
> Meanwhile, atomic.h includes cmpxchg.h.
Doesn't apply against the latest ff tree. Can you please regenerate,
not losing whatever change caused it to reject?
-Andi
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@novell.com>
To: Jeff Dike <jdike@addtoit.com>
Cc: akpm@osdl.org, LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [PATCH 2/6] Create asm-i386/cmpxchg.h
Date: Wed, 2 May 2007 11:37:48 +0200 [thread overview]
Message-ID: <200705021137.48675.ak@novell.com> (raw)
In-Reply-To: <20070501182157.GA8348@c2.user-mode-linux.org>
On Tuesday 01 May 2007 20:21:57 Jeff Dike wrote:
> Rearrange the i386 cmpxchg code to allow atomic.h to get it without
> needing to include system.h. This kills warnings in the UML build
> from atomic.h about implicit declarations of cmpxchg symbols. The
> i386 build presumably isn't seeing this because a separate inclusion
> of system.h is covering it over.
>
> The cmpxchg stuff is moved to asm-i386/cmpxchg.h, with an include left
> in system.h for the benefit of generic code which expects cmpxchg
> there.
>
> Meanwhile, atomic.h includes cmpxchg.h.
Doesn't apply against the latest ff tree. Can you please regenerate,
not losing whatever change caused it to reject?
-Andi
next prev parent reply other threads:[~2007-05-02 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 18:21 [uml-devel] [PATCH 2/6] Create asm-i386/cmpxchg.h Jeff Dike
2007-05-01 18:21 ` Jeff Dike
2007-05-02 9:37 ` Andi Kleen [this message]
2007-05-02 9:37 ` Andi Kleen
2007-05-02 15:38 ` [uml-devel] " Jeff Dike
2007-05-02 15:38 ` Jeff Dike
2007-05-02 15:55 ` [uml-devel] " Eric Dumazet
2007-05-02 15:55 ` Eric Dumazet
2007-05-03 21:23 ` [uml-devel] " Jeff Dike
2007-05-03 21:23 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705021137.48675.ak@novell.com \
--to=ak@novell.com \
--cc=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.