From: Dave Jones <davej@redhat.com>
To: Joshua Hoblitt <jhoblitt@ifa.hawaii.edu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver
Date: Wed, 16 May 2007 12:24:59 -0400 [thread overview]
Message-ID: <20070516162459.GD30166@redhat.com> (raw)
In-Reply-To: <20070516011711.GE15763@ifa.hawaii.edu>
<dropping trivial@ from cc: as this definitly isn't>
On Tue, May 15, 2007 at 03:17:11PM -1000, Joshua Hoblitt wrote:
> --- linux-2.6.21.1.orig/arch/i386/kernel/cpu/cpufreq/Kconfig 2007-04-27 11:49:26.000000000 -1000
> +++ linux-2.6.21.1/arch/i386/kernel/cpu/cpufreq/Kconfig 2007-05-15 14:48:50.000000000 -1000
> @@ -82,6 +82,7 @@ config X86_POWERNOW_K8
> tristate "AMD Opteron/Athlon64 PowerNow!"
> select CPU_FREQ_TABLE
> depends on EXPERIMENTAL
> + depends on X86_ACPI_CPUFREQ
> help
> This adds the CPUFreq driver for mobile AMD Opteron/Athlon64 processors.
This is completely the wrong thing to do.
There's no dependancy between these two modules, as they are two independant
cpufreq drivers. I think you may be confused with X86_POWERNOW_K8_ACPI
(Which should get set if you have ACPI_PROCESSOR enabled)
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-05-16 16:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 1:17 [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver Joshua Hoblitt
2007-05-16 14:55 ` Chuck Ebbert
2007-05-16 16:24 ` Dave Jones [this message]
2007-05-16 18:38 ` Prakash Punnoor
2007-05-16 19:53 ` Duane Griffin
2007-05-16 20:04 ` Daniel Drake
2007-05-16 21:27 ` Joshua Hoblitt
2007-05-16 22:39 ` Ed Sweetman
2007-05-16 23:18 ` Daniel Drake
2007-05-16 23:37 ` Ed Sweetman
2007-05-16 20:48 ` Dave Jones
2007-05-18 3:04 ` Joshua Hoblitt
2007-05-18 4:07 ` Ed Sweetman
2007-05-18 4:09 ` Ed Sweetman
2007-05-18 16:01 ` Dave Jones
2007-05-22 2:47 ` Joshua Hoblitt
2007-05-29 20:51 ` Dave Jones
2007-05-29 23:35 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070516162459.GD30166@redhat.com \
--to=davej@redhat.com \
--cc=jhoblitt@ifa.hawaii.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.