Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

[Dave Jones <davej@redhat.com>]

On Wed, May 16, 2007 at 08:53:13PM +0100, Duane Griffin wrote:
 > On 16/05/07, Prakash Punnoor <prakash@punnoor.de> wrote:
 > > Maybe you want to give a hint in the p states driver help text?
 > 
 > I think a hint is the right thing to do, but in the PowerNow! driver
 > rather than the p states one. How about adding something like this to
 > the X86_POWERNOW_K8 (and X86_POWERNOW_K7?) help text:

The mobile K7s which had powernow support weren't SMP capable, so they're
irrelevant.

 > "ACPI support is required for non-UP systems and requires ACPI_PROCESSOR
 >  to be selected. If ACPI_PROCESSOR is compiled as a module then this
 >  option must be too in order for ACPI support to be available."

X86_POWERNOW_K8_ACPI is already 'default y'. I think the problem lies in
that people aren't enabling its dependancy, ACPI_PROCESSOR.

We want something along the lines of..

config X86_POWERNOW_K8_ACPI
	bool
	if SMP & X86_POWERNOW_K8_ACPI
	  select ACPI_PROCESSOR

kconfig language quirks aside..


	Dave

-- 
http://www.codemonkey.org.uk