Re: [PATCH] Kconfig powernow-k8 driver should depend on ACPI P-States driver

[Chuck Ebbert <cebbert@redhat.com>]

[Copying maintainer.]

Joshua Hoblitt wrote:
> Hello,
> 
> Below is a one line patch to possibly fix this bug:
> 
> http://bugs.gentoo.org/show_bug.cgi?id=178585
> http://bugzilla.kernel.org/show_bug.cgi?id=8075
> 
> If the kernel is configured with:
> 
> CONFIG_X86_POWERNOW_K8=y
> CONFIG_X86_ACPI_CPUFREQ=m
> 
> Which is currently an allowed configuration, the powernow-k8 driver on
> an SMP system will fail with a warning like:
> 
> powernow-k8: Found 4 Dual Core AMD Opteron(tm) Processor 285 processors (version 2.00.00)
> powernow-k8: MP systems not supported by PSB BIOS structure
> powernow-k8: MP systems not supported by PSB BIOS structure
> powernow-k8: MP systems not supported by PSB BIOS structure
> powernow-k8: MP systems not supported by PSB BIOS structure
> 
> Which mimics that failure you get when powernow/cool'n'quiet is disabled
> in the BIOS.  I don't know if this config combination is valid on a
> uniprocessor system so this dependency may need to be enforced only if
> SMP in enabled.  The other powernow-* drivers likely have the same
> requirements as -k8 but I am unable to test them.
> 
> Signed-off-by: Joshua Hoblitt <jhoblitt@ifa.hawaii.edu>
> --
>  Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-2.6.21.1.orig/arch/i386/kernel/cpu/cpufreq/Kconfig    2007-04-27 11:49:26.000000000 -1000
> +++ linux-2.6.21.1/arch/i386/kernel/cpu/cpufreq/Kconfig 2007-05-15 14:48:50.000000000 -1000
> @@ -82,6 +82,7 @@ config X86_POWERNOW_K8
>         tristate "AMD Opteron/Athlon64 PowerNow!"
>         select CPU_FREQ_TABLE
>         depends on EXPERIMENTAL
> +       depends on X86_ACPI_CPUFREQ
>         help
>           This adds the CPUFreq driver for mobile AMD Opteron/Athlon64 processors.
> 
>