From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@osdl.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: [uml-devel] [PATCH 2/2] UML - Fix ubd_add error reporting
Date: Wed, 23 May 2007 12:33:01 -0400 [thread overview]
Message-ID: <20070523163301.GA5563@c2.user-mode-linux.org> (raw)
ubd_add returns 0 when there could actually be an error to report.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
--
arch/um/drivers/ubd_kern.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.21-mm/arch/um/drivers/ubd_kern.c
===================================================================
--- linux-2.6.21-mm.orig/arch/um/drivers/ubd_kern.c 2007-05-22 11:55:48.000000000 -0400
+++ linux-2.6.21-mm/arch/um/drivers/ubd_kern.c 2007-05-22 12:03:48.000000000 -0400
@@ -766,7 +766,7 @@ static int ubd_add(int n, char **error_o
make_ide_entries(ubd_gendisk[n]->disk_name);
out:
- return 0;
+ return err;
out_cleanup:
blk_cleanup_queue(ubd_dev->queue);
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@osdl.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: [PATCH 2/2] UML - Fix ubd_add error reporting
Date: Wed, 23 May 2007 12:33:01 -0400 [thread overview]
Message-ID: <20070523163301.GA5563@c2.user-mode-linux.org> (raw)
ubd_add returns 0 when there could actually be an error to report.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
--
arch/um/drivers/ubd_kern.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.21-mm/arch/um/drivers/ubd_kern.c
===================================================================
--- linux-2.6.21-mm.orig/arch/um/drivers/ubd_kern.c 2007-05-22 11:55:48.000000000 -0400
+++ linux-2.6.21-mm/arch/um/drivers/ubd_kern.c 2007-05-22 12:03:48.000000000 -0400
@@ -766,7 +766,7 @@ static int ubd_add(int n, char **error_o
make_ide_entries(ubd_gendisk[n]->disk_name);
out:
- return 0;
+ return err;
out_cleanup:
blk_cleanup_queue(ubd_dev->queue);
next reply other threads:[~2007-05-23 16:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 16:33 Jeff Dike [this message]
2007-05-23 16:33 ` [PATCH 2/2] UML - Fix ubd_add error reporting Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070523163301.GA5563@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.