All of lore.kernel.org
 help / color / mirror / Atom feed
* [uml-devel] [PATCH 2/2] UML - Fix ubd_add error reporting
@ 2007-05-23 16:33 ` Jeff Dike
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Dike @ 2007-05-23 16:33 UTC (permalink / raw)
  To: Andrew Morton; +Cc: LKML, uml-devel

ubd_add returns 0 when there could actually be an error to report.

Signed-off-by: Jeff Dike <jdike@linux.intel.com>
--
 arch/um/drivers/ubd_kern.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.21-mm/arch/um/drivers/ubd_kern.c
===================================================================
--- linux-2.6.21-mm.orig/arch/um/drivers/ubd_kern.c	2007-05-22 11:55:48.000000000 -0400
+++ linux-2.6.21-mm/arch/um/drivers/ubd_kern.c	2007-05-22 12:03:48.000000000 -0400
@@ -766,7 +766,7 @@ static int ubd_add(int n, char **error_o
 		make_ide_entries(ubd_gendisk[n]->disk_name);
 
 out:
-	return 0;
+	return err;
 
 out_cleanup:
 	blk_cleanup_queue(ubd_dev->queue);

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 2/2] UML - Fix ubd_add error reporting
@ 2007-05-23 16:33 ` Jeff Dike
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Dike @ 2007-05-23 16:33 UTC (permalink / raw)
  To: Andrew Morton; +Cc: LKML, uml-devel

ubd_add returns 0 when there could actually be an error to report.

Signed-off-by: Jeff Dike <jdike@linux.intel.com>
--
 arch/um/drivers/ubd_kern.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.21-mm/arch/um/drivers/ubd_kern.c
===================================================================
--- linux-2.6.21-mm.orig/arch/um/drivers/ubd_kern.c	2007-05-22 11:55:48.000000000 -0400
+++ linux-2.6.21-mm/arch/um/drivers/ubd_kern.c	2007-05-22 12:03:48.000000000 -0400
@@ -766,7 +766,7 @@ static int ubd_add(int n, char **error_o
 		make_ide_entries(ubd_gendisk[n]->disk_name);
 
 out:
-	return 0;
+	return err;
 
 out_cleanup:
 	blk_cleanup_queue(ubd_dev->queue);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-05-23 16:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-23 16:33 [uml-devel] [PATCH 2/2] UML - Fix ubd_add error reporting Jeff Dike
2007-05-23 16:33 ` Jeff Dike

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.