All of lore.kernel.org
 help / color / mirror / Atom feed
From: Folkert van Heusden <folkert@vanheusden.com>
To: Satyam Sharma <satyam.sharma@gmail.com>
Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>,
	Andrea Righi <righiandr@users.sourceforge.net>,
	Andi Kleen <ak@suse.de>,
	Stephen Hemminger <shemminger@linux-foundation.org>,
	Eric Dumazet <dada1@cosmosbay.com>,
	Rik van Riel <riel@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: signals logged / [RFC] log out-of-virtual-memory events
Date: Wed, 23 May 2007 20:45:35 +0200	[thread overview]
Message-ID: <20070523184535.GE21655@vanheusden.com> (raw)
In-Reply-To: <a781481a0705231100q333a589at6c025eb1292019cd@mail.gmail.com>

> >> >+    {
> >> if (sig_fatal(t, sig)) {
> >> >+            printk(KERN_WARNING "Sig %d send to %d owned by %d.%d 
> >(%s)\n",
> >> s/send/sent/;
> >> >+            sig, t -> pid, t -> uid, t -> gid, t -> comm);
> >> t->pid, t->uid, t->gid, t->comm);
> >
> 
> Gargh ... why does this want to be in the *kernel*'s logs? In any case, can
> you please make this KERN_INFO (or lower) instead of KERN_WARNING.

Description:
This patch adds code to the signal-sender making it log a message when
an unhandled fatal signal will be delivered.

Signed-of by: Folkert van Heusden <folkert@vanheusden.com

--- kernel/signal.c.org	2007-05-20 22:47:13.000000000 +0200
+++ kernel/signal.c	2007-05-21 14:46:05.000000000 +0200
@@ -739,6 +739,12 @@
 	struct sigqueue * q = NULL;
 	int ret = 0;
 
+	/* unhandled fatal signals are logged */
+	if (sig_fatal(t, sig)) {
+		printk(KERN_INFO "Sig %d sent to %d owned by %d.%d (%s)\n",
+		sig, t->pid, t->uid, t->gid, t->comm);
+	}
+
 	/*
 	 * fast-pathed signals for kernel-internal things like SIGSTOP
 	 * or SIGKILL.


Folkert van Heusden

-- 
Temperature outside:    21.437500, temperature livingroom: 
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com

WARNING: multiple messages have this Message-ID (diff)
From: Folkert van Heusden <folkert@vanheusden.com>
To: Satyam Sharma <satyam.sharma@gmail.com>
Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>,
	Andrea Righi <righiandr@users.sourceforge.net>,
	Andi Kleen <ak@suse.de>,
	Stephen Hemminger <shemminger@linux-foundation.org>,
	Eric Dumazet <dada1@cosmosbay.com>,
	Rik van Riel <riel@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: signals logged / [RFC] log out-of-virtual-memory events
Date: Wed, 23 May 2007 20:45:35 +0200	[thread overview]
Message-ID: <20070523184535.GE21655@vanheusden.com> (raw)
In-Reply-To: <a781481a0705231100q333a589at6c025eb1292019cd@mail.gmail.com>

> >> >+    {
> >> if (sig_fatal(t, sig)) {
> >> >+            printk(KERN_WARNING "Sig %d send to %d owned by %d.%d 
> >(%s)\n",
> >> s/send/sent/;
> >> >+            sig, t -> pid, t -> uid, t -> gid, t -> comm);
> >> t->pid, t->uid, t->gid, t->comm);
> >
> 
> Gargh ... why does this want to be in the *kernel*'s logs? In any case, can
> you please make this KERN_INFO (or lower) instead of KERN_WARNING.

Description:
This patch adds code to the signal-sender making it log a message when
an unhandled fatal signal will be delivered.

Signed-of by: Folkert van Heusden <folkert@vanheusden.com

--- kernel/signal.c.org	2007-05-20 22:47:13.000000000 +0200
+++ kernel/signal.c	2007-05-21 14:46:05.000000000 +0200
@@ -739,6 +739,12 @@
 	struct sigqueue * q = NULL;
 	int ret = 0;
 
+	/* unhandled fatal signals are logged */
+	if (sig_fatal(t, sig)) {
+		printk(KERN_INFO "Sig %d sent to %d owned by %d.%d (%s)\n",
+		sig, t->pid, t->uid, t->gid, t->comm);
+	}
+
 	/*
 	 * fast-pathed signals for kernel-internal things like SIGSTOP
 	 * or SIGKILL.


Folkert van Heusden

-- 
Temperature outside:    21.437500, temperature livingroom: 
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-05-23 18:45 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-17 16:24 [RFC] log out-of-virtual-memory events Andrea Righi
2007-05-17 16:24 ` Andrea Righi
2007-05-17 18:22 ` Rik van Riel
2007-05-17 18:22   ` Rik van Riel
2007-05-18  6:28   ` signals logged / " Jan Engelhardt
2007-05-18  6:28     ` Jan Engelhardt
2007-05-18 11:47     ` Andi Kleen
2007-05-18 11:47       ` Andi Kleen
2007-05-19  7:46       ` Jan Engelhardt
2007-05-19  7:46         ` Jan Engelhardt
2007-05-19  9:35         ` Andrea Righi
2007-05-19  9:35           ` Andrea Righi
2007-05-19 10:06           ` Jan Engelhardt
2007-05-19 10:06             ` Jan Engelhardt
2007-05-19 10:16             ` Andrea Righi
2007-05-19 10:16               ` Andrea Righi
2007-05-20  0:14         ` Folkert van Heusden
2007-05-20  0:14           ` Folkert van Heusden
2007-05-20  3:55           ` Eric Dumazet
2007-05-20  3:55             ` Eric Dumazet
2007-05-20 11:21             ` Folkert van Heusden
2007-05-20 11:21               ` Folkert van Heusden
2007-05-20 16:08               ` Stephen Hemminger
2007-05-20 16:08                 ` Stephen Hemminger
2007-05-20 16:12                 ` Folkert van Heusden
2007-05-20 16:12                   ` Folkert van Heusden
2007-05-20 20:38                   ` Jan Engelhardt
2007-05-20 20:38                     ` Jan Engelhardt
2007-05-20 20:55                     ` Folkert van Heusden
2007-05-20 20:55                       ` Folkert van Heusden
2007-05-20 21:14                       ` Andi Kleen
2007-05-20 21:14                         ` Andi Kleen
2007-05-20 21:20                         ` Folkert van Heusden
2007-05-20 21:20                           ` Folkert van Heusden
2007-05-20 21:23                           ` Folkert van Heusden
2007-05-20 21:23                             ` Folkert van Heusden
2007-05-20 22:24                           ` Andi Kleen
2007-05-20 22:24                             ` Andi Kleen
2007-05-20 22:22                             ` Jeff Dike
2007-05-20 22:22                               ` Jeff Dike
2007-05-21 11:26                           ` Gábor Lénárt
2007-05-21 10:45                         ` Andrea Righi
2007-05-21 10:45                           ` Andrea Righi
2007-05-21 11:04                           ` Folkert van Heusden
2007-05-21 11:04                             ` Folkert van Heusden
2007-05-21 12:30                             ` Jan Engelhardt
2007-05-21 12:30                               ` Jan Engelhardt
2007-05-21 12:47                               ` Folkert van Heusden
2007-05-21 12:47                                 ` Folkert van Heusden
2007-05-21 13:58                                 ` Andrea Righi
2007-05-21 13:58                                   ` Andrea Righi
2007-05-21 18:59                                   ` Folkert van Heusden
2007-05-21 18:59                                     ` Folkert van Heusden
2007-05-21 22:15                                     ` Andrea Righi
2007-05-21 22:15                                       ` Andrea Righi
2007-05-23 18:00                                 ` Satyam Sharma
2007-05-23 18:00                                   ` Satyam Sharma
2007-05-23 18:45                                   ` Folkert van Heusden [this message]
2007-05-23 18:45                                     ` Folkert van Heusden
2007-06-10 19:53                                     ` Folkert van Heusden
2007-06-10 19:53                                       ` Folkert van Heusden
2007-06-10 20:06                                       ` Jiri Kosina
2007-06-10 20:06                                         ` Jiri Kosina
2007-06-10 20:37                                         ` Jan Engelhardt
2007-06-10 20:37                                           ` Jan Engelhardt
2007-05-18  7:50   ` Andrea Righi
2007-05-18  7:50     ` Andrea Righi
2007-05-18  9:16     ` Robin Holt
2007-05-18  9:16       ` Robin Holt
2007-05-18 15:55       ` Andrea Righi
2007-05-18 15:55         ` Andrea Righi
2007-05-18 16:05         ` Andrea Righi
2007-05-18 16:05           ` Andrea Righi
2007-05-18 16:34           ` Bernd Eckenfels
2007-05-19 10:33             ` [PATCH 1/2] limit print_fatal_signal() rate (was: [RFC] log out-of-virtual-memory events) Andrea Righi
2007-05-19 10:33               ` Andrea Righi
2007-05-21  3:31               ` Andrew Morton
2007-05-21  3:31                 ` Andrew Morton
2007-05-21 10:44                 ` [PATCH 1/2] limit print_fatal_signal() rate Andrea Righi
2007-05-21 10:44                   ` Andrea Righi
2007-05-24  7:58                 ` [PATCH 1/2] limit print_fatal_signal() rate (was: [RFC] log out-of-virtual-memory events) Ingo Molnar
2007-05-24  7:58                   ` Ingo Molnar
2007-05-24  8:15                   ` Andrew Morton
2007-05-24  8:15                     ` Andrew Morton
2007-05-24  9:55                     ` Ingo Molnar
2007-05-24  9:55                       ` Ingo Molnar
2007-05-24 16:23                       ` Andrew Morton
2007-05-24 16:23                         ` Andrew Morton
2007-05-24  8:50                   ` [PATCH 1/2] limit print_fatal_signal() rate Andrea Righi
2007-05-24  8:50                     ` Andrea Righi
2007-05-24  9:58                     ` Ingo Molnar
2007-05-24  9:58                       ` Ingo Molnar
2007-05-24  9:57                   ` [PATCH 1/2] limit print_fatal_signal() rate (was: [RFC] log out-of-virtual-memory events) Ingo Molnar
2007-05-24  9:57                     ` Ingo Molnar
2007-05-18 16:36         ` [RFC] log out-of-virtual-memory events Bernd Eckenfels
2007-05-19 10:34           ` [PATCH 2/2] log out-of-virtual-memory events (was: [RFC] log out-of-virtual-memory events) Andrea Righi
2007-05-19 10:34             ` Andrea Righi
2007-05-21  3:32             ` Andrew Morton
2007-05-21  3:32               ` Andrew Morton
2007-05-21 10:48               ` [PATCH 2/2] log out-of-virtual-memory events Andrea Righi
2007-05-21 10:48                 ` Andrea Righi
2007-05-20  0:15     ` [RFC] " Folkert van Heusden
2007-05-20  0:15       ` Folkert van Heusden
  -- strict thread matches above, loose matches on Subject: below --
2007-05-20 22:21 signals logged / " Mikael Pettersson
2007-05-20 22:21 ` Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070523184535.GE21655@vanheusden.com \
    --to=folkert@vanheusden.com \
    --cc=ak@suse.de \
    --cc=dada1@cosmosbay.com \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    --cc=righiandr@users.sourceforge.net \
    --cc=satyam.sharma@gmail.com \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.