From: Andrea Righi <righiandr@users.sourceforge.net>
To: Folkert van Heusden <folkert@vanheusden.com>
Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>, Andi Kleen <ak@suse.de>,
Stephen Hemminger <shemminger@linux-foundation.org>,
Eric Dumazet <dada1@cosmosbay.com>,
Rik van Riel <riel@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: signals logged / [RFC] log out-of-virtual-memory events
Date: Tue, 22 May 2007 00:15:55 +0200 (MEST) [thread overview]
Message-ID: <465219FA.7080305@users.sourceforge.net> (raw)
In-Reply-To: <20070521185947.GF14802@vanheusden.com>
Folkert van Heusden wrote:
>>>>> What about the following enhancement: I check with sig_fatal if it would
>>>>> kill the process and only then emit a message. So when an application
>>>>> takes care itself of handling it nothing is printed.
>>>>> + /* emit some logging for unhandled signals
>>>>> + */
>>>>> + if (sig_fatal(t, sig))
>>>> Not unhandled_signal()?
>>> Can we already use that one in send_signal? As the signal needs to be
>>> send first I think before we know if it was handled or not? sig_fatal
>>> checks if the handler is set to default - which is it is not taken care
>>> of.
>> What about ptrace()'d processes? I don't think we should log signals for them...
>
> Why not?
Maybe sometimes it's useful, maybe not, but I suppose that usually only the
controlling process should care about the critical signals received by the
controlled process. I simply don't think it should be a system issue. For
example I wouldn't like to have a lot of messages in the kernel logs just
because I'm debugging some segfaulting programs with gdb.
-Andrea
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Righi <righiandr@users.sourceforge.net>
To: Folkert van Heusden <folkert@vanheusden.com>
Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>, Andi Kleen <ak@suse.de>,
Stephen Hemminger <shemminger@linux-foundation.org>,
Eric Dumazet <dada1@cosmosbay.com>,
Rik van Riel <riel@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: signals logged / [RFC] log out-of-virtual-memory events
Date: Tue, 22 May 2007 00:15:55 +0200 (MEST) [thread overview]
Message-ID: <465219FA.7080305@users.sourceforge.net> (raw)
In-Reply-To: <20070521185947.GF14802@vanheusden.com>
Folkert van Heusden wrote:
>>>>> What about the following enhancement: I check with sig_fatal if it would
>>>>> kill the process and only then emit a message. So when an application
>>>>> takes care itself of handling it nothing is printed.
>>>>> + /* emit some logging for unhandled signals
>>>>> + */
>>>>> + if (sig_fatal(t, sig))
>>>> Not unhandled_signal()?
>>> Can we already use that one in send_signal? As the signal needs to be
>>> send first I think before we know if it was handled or not? sig_fatal
>>> checks if the handler is set to default - which is it is not taken care
>>> of.
>> What about ptrace()'d processes? I don't think we should log signals for them...
>
> Why not?
Maybe sometimes it's useful, maybe not, but I suppose that usually only the
controlling process should care about the critical signals received by the
controlled process. I simply don't think it should be a system issue. For
example I wouldn't like to have a lot of messages in the kernel logs just
because I'm debugging some segfaulting programs with gdb.
-Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-05-21 22:16 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 16:24 [RFC] log out-of-virtual-memory events Andrea Righi
2007-05-17 16:24 ` Andrea Righi
2007-05-17 18:22 ` Rik van Riel
2007-05-17 18:22 ` Rik van Riel
2007-05-18 6:28 ` signals logged / " Jan Engelhardt
2007-05-18 6:28 ` Jan Engelhardt
2007-05-18 11:47 ` Andi Kleen
2007-05-18 11:47 ` Andi Kleen
2007-05-19 7:46 ` Jan Engelhardt
2007-05-19 7:46 ` Jan Engelhardt
2007-05-19 9:35 ` Andrea Righi
2007-05-19 9:35 ` Andrea Righi
2007-05-19 10:06 ` Jan Engelhardt
2007-05-19 10:06 ` Jan Engelhardt
2007-05-19 10:16 ` Andrea Righi
2007-05-19 10:16 ` Andrea Righi
2007-05-20 0:14 ` Folkert van Heusden
2007-05-20 0:14 ` Folkert van Heusden
2007-05-20 3:55 ` Eric Dumazet
2007-05-20 3:55 ` Eric Dumazet
2007-05-20 11:21 ` Folkert van Heusden
2007-05-20 11:21 ` Folkert van Heusden
2007-05-20 16:08 ` Stephen Hemminger
2007-05-20 16:08 ` Stephen Hemminger
2007-05-20 16:12 ` Folkert van Heusden
2007-05-20 16:12 ` Folkert van Heusden
2007-05-20 20:38 ` Jan Engelhardt
2007-05-20 20:38 ` Jan Engelhardt
2007-05-20 20:55 ` Folkert van Heusden
2007-05-20 20:55 ` Folkert van Heusden
2007-05-20 21:14 ` Andi Kleen
2007-05-20 21:14 ` Andi Kleen
2007-05-20 21:20 ` Folkert van Heusden
2007-05-20 21:20 ` Folkert van Heusden
2007-05-20 21:23 ` Folkert van Heusden
2007-05-20 21:23 ` Folkert van Heusden
2007-05-20 22:24 ` Andi Kleen
2007-05-20 22:24 ` Andi Kleen
2007-05-20 22:22 ` Jeff Dike
2007-05-20 22:22 ` Jeff Dike
2007-05-21 11:26 ` Gábor Lénárt
2007-05-21 10:45 ` Andrea Righi
2007-05-21 10:45 ` Andrea Righi
2007-05-21 11:04 ` Folkert van Heusden
2007-05-21 11:04 ` Folkert van Heusden
2007-05-21 12:30 ` Jan Engelhardt
2007-05-21 12:30 ` Jan Engelhardt
2007-05-21 12:47 ` Folkert van Heusden
2007-05-21 12:47 ` Folkert van Heusden
2007-05-21 13:58 ` Andrea Righi
2007-05-21 13:58 ` Andrea Righi
2007-05-21 18:59 ` Folkert van Heusden
2007-05-21 18:59 ` Folkert van Heusden
2007-05-21 22:15 ` Andrea Righi [this message]
2007-05-21 22:15 ` Andrea Righi
2007-05-23 18:00 ` Satyam Sharma
2007-05-23 18:00 ` Satyam Sharma
2007-05-23 18:45 ` Folkert van Heusden
2007-05-23 18:45 ` Folkert van Heusden
2007-06-10 19:53 ` Folkert van Heusden
2007-06-10 19:53 ` Folkert van Heusden
2007-06-10 20:06 ` Jiri Kosina
2007-06-10 20:06 ` Jiri Kosina
2007-06-10 20:37 ` Jan Engelhardt
2007-06-10 20:37 ` Jan Engelhardt
2007-05-18 7:50 ` Andrea Righi
2007-05-18 7:50 ` Andrea Righi
2007-05-18 9:16 ` Robin Holt
2007-05-18 9:16 ` Robin Holt
2007-05-18 15:55 ` Andrea Righi
2007-05-18 15:55 ` Andrea Righi
2007-05-18 16:05 ` Andrea Righi
2007-05-18 16:05 ` Andrea Righi
2007-05-18 16:34 ` Bernd Eckenfels
2007-05-19 10:33 ` [PATCH 1/2] limit print_fatal_signal() rate (was: [RFC] log out-of-virtual-memory events) Andrea Righi
2007-05-19 10:33 ` Andrea Righi
2007-05-21 3:31 ` Andrew Morton
2007-05-21 3:31 ` Andrew Morton
2007-05-21 10:44 ` [PATCH 1/2] limit print_fatal_signal() rate Andrea Righi
2007-05-21 10:44 ` Andrea Righi
2007-05-24 7:58 ` [PATCH 1/2] limit print_fatal_signal() rate (was: [RFC] log out-of-virtual-memory events) Ingo Molnar
2007-05-24 7:58 ` Ingo Molnar
2007-05-24 8:15 ` Andrew Morton
2007-05-24 8:15 ` Andrew Morton
2007-05-24 9:55 ` Ingo Molnar
2007-05-24 9:55 ` Ingo Molnar
2007-05-24 16:23 ` Andrew Morton
2007-05-24 16:23 ` Andrew Morton
2007-05-24 8:50 ` [PATCH 1/2] limit print_fatal_signal() rate Andrea Righi
2007-05-24 8:50 ` Andrea Righi
2007-05-24 9:58 ` Ingo Molnar
2007-05-24 9:58 ` Ingo Molnar
2007-05-24 9:57 ` [PATCH 1/2] limit print_fatal_signal() rate (was: [RFC] log out-of-virtual-memory events) Ingo Molnar
2007-05-24 9:57 ` Ingo Molnar
2007-05-18 16:36 ` [RFC] log out-of-virtual-memory events Bernd Eckenfels
2007-05-19 10:34 ` [PATCH 2/2] log out-of-virtual-memory events (was: [RFC] log out-of-virtual-memory events) Andrea Righi
2007-05-19 10:34 ` Andrea Righi
2007-05-21 3:32 ` Andrew Morton
2007-05-21 3:32 ` Andrew Morton
2007-05-21 10:48 ` [PATCH 2/2] log out-of-virtual-memory events Andrea Righi
2007-05-21 10:48 ` Andrea Righi
2007-05-20 0:15 ` [RFC] " Folkert van Heusden
2007-05-20 0:15 ` Folkert van Heusden
-- strict thread matches above, loose matches on Subject: below --
2007-05-20 22:21 signals logged / " Mikael Pettersson
2007-05-20 22:21 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465219FA.7080305@users.sourceforge.net \
--to=righiandr@users.sourceforge.net \
--cc=ak@suse.de \
--cc=dada1@cosmosbay.com \
--cc=folkert@vanheusden.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.