[PATCH - 1/1] Documentation/HOWTO

[PATCH - 1/1] Documentation/HOWTO

[debian developer]

Heres a patch. It's my first. so any mistakes to be pardoned. :)

--- linux-2.6.21.1/Documentation/HOWTO.orig	2007-05-18 18:54:18.000000000 +0530
+++ linux-2.6.21.1/Documentation/HOWTO	2007-05-18 18:55:03.000000000 +0530
@@ -383,26 +383,6 @@ One of the best ways to put into practic
 bugs reported by other people. Not only you will help to make the kernel
 more stable, you'll learn to fix real world problems and you will improve
 your skills, and other developers will be aware of your presence. Fixing
-bugs is one of the best ways to earn merit amongst the developers, because
-not many people like wasting time fixing other people's bugs.
-
-To work in the already reported bug reports, go to http://bugzilla.kernel.org.
-If you want to be advised of the future bug reports, you can subscribe to the
-bugme-new mailing list (only new bug reports are mailed here) or to the
-bugme-janitor mailing list (every change in the bugzilla is mailed here)
-
-	http://lists.osdl.org/mailman/listinfo/bugme-new
-	http://lists.osdl.org/mailman/listinfo/bugme-janitors
-
-
-
-Managing bug reports
---------------------
-
-One of the best ways to put into practice your hacking skills is by fixing
-bugs reported by other people. Not only you will help to make the kernel
-more stable, you'll learn to fix real world problems and you will improve
-your skills, and other developers will be aware of your presence. Fixing
 bugs is one of the best ways to get merits among other developers, because
 not many people like wasting time fixing other people's bugs.

Re: [PATCH - 1/1] Documentation/HOWTO

[Pekka Enberg]

Hi "Debian Developer",

On 5/18/07, debian developer <debiandev@gmail.com> wrote:
> Heres a patch. It's my first. so any mistakes to be pardoned. :)

Three major problems: (1) no real name in the email, (2) no patch
description and (3) no signed-off-by line. Please see the following
URL for details:

http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

Re: [PATCH - 1/1] Documentation/HOWTO

[Robert P. J. Day]

On Fri, 18 May 2007, debian developer wrote:
...
> -Managing bug reports
> ---------------------
> -
> -One of the best ways to put into practice your hacking skills is by fixing
> -bugs reported by other people. Not only you will help to make the kernel
> -more stable, you'll learn to fix real world problems and you will improve
> -your skills, and other developers will be aware of your presence. Fixing
> bugs is one of the best ways to get merits among other developers, because
> not many people like wasting time fixing other people's bugs.
                       ^^^^^^^ ^^^^

you might want to find a less demeaning term for debugging than
"wasting time."  just a thought.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [PATCH - 1/1] Documentation/HOWTO

[Bernd Eckenfels]

In article <Pine.LNX.4.64.0705181200440.18186@localhost.localdomain> you wrote:
>> bugs is one of the best ways to get merits among other developers, because
>> not many people like wasting time fixing other people's bugs.
>                       ^^^^^^^ ^^^^
> 
> you might want to find a less demeaning term for debugging than
> "wasting time."  just a thought.

and it is not even correct.

Gruss
Bernd

Re: [PATCH - 1/1] Documentation/HOWTO

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

On Fri, 18 May 2007 12:01:41 EDT, "Robert P. J. Day" said:
> On Fri, 18 May 2007, debian developer wrote:

> > -your skills, and other developers will be aware of your presence. Fixing
> > bugs is one of the best ways to get merits among other developers, because
> > not many people like wasting time fixing other people's bugs.
>                        ^^^^^^^ ^^^^
> you might want to find a less demeaning term for debugging than
> "wasting time."  just a thought.

Wasn't his text, not his fault.  At least his patch is an improvement - now
HOWTO only equates it with "wasting time" once, rather than twice. ;)

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: [PATCH - 1/1] Documentation/HOWTO

[Qi Yong]

On 19/05/07, Valdis.Kletnieks@vt.edu <Valdis.Kletnieks@vt.edu> wrote:
> On Fri, 18 May 2007 12:01:41 EDT, "Robert P. J. Day" said:
> > On Fri, 18 May 2007, debian developer wrote:
>
> > > -your skills, and other developers will be aware of your presence. Fixing
> > > bugs is one of the best ways to get merits among other developers, because
> > > not many people like wasting time fixing other people's bugs.
> >                        ^^^^^^^ ^^^^
> > you might want to find a less demeaning term for debugging than
> > "wasting time."  just a thought.
>
> Wasn't his text, not his fault.  At least his patch is an improvement - now
> HOWTO only equates it with "wasting time" once, rather than twice. ;)

Hello,

This duplicated paragraph problem was introduced by the following two
commits. They are one patch actually.

bughunting patch adds bug; isn't it a vivid ironic example.

and also
> +not many people like wasting time fixing other people's bugs.

Torvalds, Care to revert one commit?

commit 722385f75efd82d9f480f0765a1e97a4d83cac0d
Author: Diego Calleja <diegocg@gmail.com>
Date:   Thu Sep 21 22:37:10 2006 +0200

    HOWTO: bug report addition

    I suspect that not many people is subscribed to the bugzilla mailing list,
    not surprising since the URLs doesn't seem to be in the tree :)

    After fixing my english, I wonder if the following patch could be applied...

    Signed-off-by: Diego Calleja <diegocg@gmail.com>
    Acked-by: Randy Dunlap <rdunlap@xenotime.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

commit 3f27100872b21e4cc70d07b96eeb3611b30bce63
Author: Diego Calleja <diegocg@gmail.com>
Date:   Sat Sep 30 23:27:49 2006 -0700

    [PATCH] HOWTO: mention bughunting

    Signed-off-by: Diego Calleja <diegocg@gmail.com>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>


-- 
Qi Yong

Re: [PATCH - 1/1] Documentation/HOWTO

[Diego Calleja]

El Thu, 24 May 2007 17:45:04 +0800, "Qi Yong" <qiyong@fc-cn.com> escribió:

> Hello,
> 
> This duplicated paragraph problem was introduced by the following two
> commits. They are one patch actually.

D'oh, it seems the patch was picked from the mailing list and merged twice,
and I didn't notice it.

> Torvalds, Care to revert one commit?

Agreed, one of them can be removed.


> commit 722385f75efd82d9f480f0765a1e97a4d83cac0d
> Author: Diego Calleja <diegocg@gmail.com>
> Date:   Thu Sep 21 22:37:10 2006 +0200
> 
>     HOWTO: bug report addition
> 
>     I suspect that not many people is subscribed to the bugzilla mailing list,
>     not surprising since the URLs doesn't seem to be in the tree :)
> 
>     After fixing my english, I wonder if the following patch could be applied...
> 
>     Signed-off-by: Diego Calleja <diegocg@gmail.com>
>     Acked-by: Randy Dunlap <rdunlap@xenotime.net>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> 
> commit 3f27100872b21e4cc70d07b96eeb3611b30bce63
> Author: Diego Calleja <diegocg@gmail.com>
> Date:   Sat Sep 30 23:27:49 2006 -0700
> 
>     [PATCH] HOWTO: mention bughunting
> 
>     Signed-off-by: Diego Calleja <diegocg@gmail.com>
>     Signed-off-by: Andrew Morton <akpm@osdl.org>
>     Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Re: [PATCH - 1/1] Documentation/HOWTO

[Linus Torvalds]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 572 bytes --]



On Thu, 24 May 2007, Diego Calleja wrote:
> El Thu, 24 May 2007 17:45:04 +0800, "Qi Yong" <qiyong@fc-cn.com> escribió:
> 
> D'oh, it seems the patch was picked from the mailing list and merged twice,
> and I didn't notice it.
> 
> > Torvalds, Care to revert one commit?
> 
> Agreed, one of them can be removed.

Yes, done.

Andrew - can you check that it's also removed from your queues, since it 
might be there still just because it keeps applying cleanly.

You might have it described as "HOWTO: mention bughunting" rather than 
"HOWTO: bug report addition".

		Linus

Re: [PATCH - 1/1] Documentation/HOWTO

[debian developer]

sept. 2006! its been there since quite a long time.
now what happens to my patch submitted to Greg???

On 5/24/07, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
>
> On Thu, 24 May 2007, Diego Calleja wrote:
> > El Thu, 24 May 2007 17:45:04 +0800, "Qi Yong" <qiyong@fc-cn.com> escribió:
> >
> > D'oh, it seems the patch was picked from the mailing list and merged twice,
> > and I didn't notice it.
> >
> > > Torvalds, Care to revert one commit?
> >
> > Agreed, one of them can be removed.
>
> Yes, done.
>
> Andrew - can you check that it's also removed from your queues, since it
> might be there still just because it keeps applying cleanly.
>
> You might have it described as "HOWTO: mention bughunting" rather than
> "HOWTO: bug report addition".
>
>                 Linus

Re: [PATCH - 1/1] Documentation/HOWTO

[Qi Yong]

On Thu, May 24, 2007 at 08:49:12AM -0700, Linus Torvalds wrote:
> 
> 
> On Thu, 24 May 2007, Diego Calleja wrote:
> > El Thu, 24 May 2007 17:45:04 +0800, "Qi Yong" <qiyong@fc-cn.com> escribió:
> > 
> > D'oh, it seems the patch was picked from the mailing list and merged twice,
> > and I didn't notice it.
> > 
> > > Torvalds, Care to revert one commit?
> > 
> > Agreed, one of them can be removed.
> 
> Yes, done.
> 
> Andrew - can you check that it's also removed from your queues, since it 
> might be there still just because it keeps applying cleanly.

People's fault, not tools'.

> 
> You might have it described as "HOWTO: mention bughunting" rather than 
> "HOWTO: bug report addition".
> 
> 		Linus

Sorry, my previous comment was not accurate.  The two patches are different,
not identical:


diff -u howto-mention-bughunting howto-bug-report-addition 
--- howto-mention-bughunting	2007-05-25 09:12:47.513596296 +0800
+++ howto-bug-report-addition	2007-05-25 09:12:58.914245983 +0800
@@ -1,7 +1,7 @@
 --- a/Documentation/HOWTO
 +++ b/Documentation/HOWTO
-@@ -375,6 +375,26 @@ of information is needed by the kernel developers to help track down the
- problem.
+@@ -395,6 +395,26 @@ bugme-janitor mailing list (every change in the bugzilla is mailed here)
+ 
  
  
 +Managing bug reports
@@ -11,7 +11,7 @@
 +bugs reported by other people. Not only you will help to make the kernel
 +more stable, you'll learn to fix real world problems and you will improve
 +your skills, and other developers will be aware of your presence. Fixing
-+bugs is one of the best ways to earn merit amongst the developers, because
++bugs is one of the best ways to get merits among other developers, because
 +not many people like wasting time fixing other people's bugs.
 +
 +To work in the already reported bug reports, go to http://bugzilla.kernel.org.


The second patch howto-bug-report-addition was an improvement, but was made
wrongly, thus added the duplication.

We should go with howto-bug-report-addition. Please take this:

Signed-off-by: Qi Yong <qiyong@fc-cn.com>
---

diff --git a/Documentation/HOWTO b/Documentation/HOWTO
index ced9207..f5e1b6d 100644
--- a/Documentation/HOWTO
+++ b/Documentation/HOWTO
@@ -383,7 +383,7 @@ One of the best ways to put into practice your hacking skills is by fixing
 bugs reported by other people. Not only you will help to make the kernel
 more stable, you'll learn to fix real world problems and you will improve
 your skills, and other developers will be aware of your presence. Fixing
-bugs is one of the best ways to earn merit amongst the developers, because
+bugs is one of the best ways to get merits among other developers, because
 not many people like wasting time fixing other people's bugs.
 
 To work in the already reported bug reports, go to http://bugzilla.kernel.org.


-- 
Qi Yong

Re: [PATCH - 1/1] Documentation/HOWTO

[Scott Preece]

On 5/18/07, Bernd Eckenfels <ecki@lina.inka.de> wrote:
> In article <Pine.LNX.4.64.0705181200440.18186@localhost.localdomain> you wrote:
> >> bugs is one of the best ways to get merits among other developers, because
> >> not many people like wasting time fixing other people's bugs.
> >                       ^^^^^^^ ^^^^
> >
> > you might want to find a less demeaning term for debugging than
---

I'm pretty sure an economist would describe debugging as wasted time
(non-value-add). The point being, of course, that the original coder's
mistakes caused someone else to have to waste time, time that could
otherwise have been spent adding value, fixing the problem.

However, it might be phrased more diplomatically in this context, like
"because you are sacrificing time that could be spent adding features,
to fix somebody else's mistakes".

scott

Re: [PATCH - 1/1] Documentation/HOWTO

[Bernd Eckenfels]

On Fri, May 25, 2007 at 11:24:46AM -0500, Scott Preece wrote:
> However, it might be phrased more diplomatically in this context, like
> "because you are sacrificing time that could be spent adding features,
> to fix somebody else's mistakes".

Not all Bugs are mistakes of the coder. I still think it is not correct to
blame developers. And it is also not a good idea to treat helping hands as
second class only because they improve instead of create things.

Linux Kernel is developed in a collaborative evolutionary process. The
documentation change is completely wrong worded.

(However the idea to ask ppl to look for small clear tasks, especially if
not everybody has the option to work on it (hardware) is good) - and very
rewarding.

Gruss
Bernd