All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amin Azez <azez@ufomechanic.net>
To: Patrick McHardy <kaber@trash.net>,
	Jan Engelhardt <jengelh@computergmbh.de>
Cc: Netfilter Developer Mailing List
	<netfilter-devel@lists.netfilter.org>,
	Amin Azez <azez@ufomechanic.net>
Subject: RE: xt_gateway 20070605 (kernel)
Date: Fri, 15 Jun 2007 18:20:19 +0100	[thread overview]
Message-ID: <200706151843.l5FIhLv18998@server1.secure-linux-server.com> (raw)

I agree that pointless checks are not needed at runtime.

I am not sure what other changes I should make to stop people crashing the kernel by using this match in places I have not forseen.

I am not certain that my anticpated crashes are actually possible.

Patrick, If I merely remove these unnecessary tests, will you be satisfied with the result?

Sam

-----Original Message-----
From: "Patrick McHardy" <kaber@trash.net>
To: "Jan Engelhardt" <jengelh@computergmbh.de>
Cc: "Amin Azez" <azez@ufomechanic.net>; "Netfilter Developer Mailing List" <netfilter-devel@lists.netfilter.org>
Sent: 15/06/07 17:15
Subject: Re: xt_gateway 20070605 (kernel)

Jan Engelhardt wrote:
> On Jun 15 2007 12:30, Amin Azez wrote:
> 
>>>and the neighbour table family is always AF_INET since the
>>>match is only registered for AF_INET.
>>>  
>>
>>Maybe if I take out these checks, I should restrict the match to FORWARD
>>and POSTROUTING?
> 
> 
> Leaving them in does not cost too much.


Thats no reason to keep pointless checks around.

             reply	other threads:[~2007-06-15 17:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-15 17:20 Amin Azez [this message]
2007-06-15 17:27 ` xt_gateway 20070605 (kernel) Patrick McHardy
2007-06-15 19:21   ` Jan Engelhardt
  -- strict thread matches above, loose matches on Subject: below --
2007-06-16  9:29 Amin Azez
2007-06-16 12:00 ` Jan Engelhardt
2007-06-16 12:14   ` Amin Azex
2007-06-16 16:31     ` Amin Azex
2007-06-16  7:34 Amin Azez
2007-06-16  7:59 ` Jan Engelhardt
2007-06-06 15:58 Amin Azez
2007-06-06 16:06 ` Patrick McHardy
2007-06-06  7:01 Amin Azez
2007-06-05 11:17 xt_gateway 20070605 Jan Engelhardt
2007-06-05 11:17 ` xt_gateway 20070605 (kernel) Jan Engelhardt
2007-06-05 12:08   ` Jan Engelhardt
2007-06-05 15:15     ` Patrick McHardy
2007-06-05 15:20       ` Jan Engelhardt
2007-06-06 11:31         ` Patrick McHardy
     [not found]       ` <46727873.20503@ufomechanic.net>
2007-06-15 16:11         ` Jan Engelhardt
2007-06-15 16:15           ` Patrick McHardy
2007-06-05 22:24   ` Phil Oester

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706151843.l5FIhLv18998@server1.secure-linux-server.com \
    --to=azez@ufomechanic.net \
    --cc=jengelh@computergmbh.de \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.