From: Patrick McHardy <kaber@trash.net>
To: Amin Azez <azez@ufomechanic.net>
Cc: Netfilter Developer Mailing List
<netfilter-devel@lists.netfilter.org>,
Jan Engelhardt <jengelh@linux01.gwdg.de>
Subject: Re: xt_gateway 20070605 (kernel)
Date: Wed, 06 Jun 2007 18:06:38 +0200 [thread overview]
Message-ID: <4666DB8E.1070205@trash.net> (raw)
In-Reply-To: <200706061718.l56HIjv08406@server1.secure-linux-server.com>
Amin Azez wrote:
> So is it necessary to resubmit the kernel patch with the un-necessary matches turned into explanatory comments?
I'd call them useless comments, so please no :) No, seriously,
I don't want to start that, people copy too much useless comments
around already. I don't want every match to state that skb is
never NULL and that its only called for AF_INET packets since
it only registered for AF_INET.
Please just remove them.
next prev parent reply other threads:[~2007-06-06 16:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 15:58 xt_gateway 20070605 (kernel) Amin Azez
2007-06-06 16:06 ` Patrick McHardy [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-06-16 9:29 Amin Azez
2007-06-16 12:00 ` Jan Engelhardt
2007-06-16 12:14 ` Amin Azex
2007-06-16 16:31 ` Amin Azex
2007-06-16 7:34 Amin Azez
2007-06-16 7:59 ` Jan Engelhardt
2007-06-15 17:20 Amin Azez
2007-06-15 17:27 ` Patrick McHardy
2007-06-15 19:21 ` Jan Engelhardt
2007-06-06 7:01 Amin Azez
2007-06-05 11:17 xt_gateway 20070605 Jan Engelhardt
2007-06-05 11:17 ` xt_gateway 20070605 (kernel) Jan Engelhardt
2007-06-05 12:08 ` Jan Engelhardt
2007-06-05 15:15 ` Patrick McHardy
2007-06-05 15:20 ` Jan Engelhardt
2007-06-06 11:31 ` Patrick McHardy
[not found] ` <46727873.20503@ufomechanic.net>
2007-06-15 16:11 ` Jan Engelhardt
2007-06-15 16:15 ` Patrick McHardy
2007-06-05 22:24 ` Phil Oester
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4666DB8E.1070205@trash.net \
--to=kaber@trash.net \
--cc=azez@ufomechanic.net \
--cc=jengelh@linux01.gwdg.de \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.