From: Patrick McHardy <kaber@trash.net>
To: Amin Azez <azez@ufomechanic.net>
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
Netfilter Developer Mailing List
<netfilter-devel@lists.netfilter.org>
Subject: Re: xt_gateway 20070605 (kernel)
Date: Fri, 15 Jun 2007 19:27:31 +0200 [thread overview]
Message-ID: <4672CC03.9070906@trash.net> (raw)
In-Reply-To: <200706151843.l5FIhLv18998@server1.secure-linux-server.com>
Amin Azez wrote:
> I agree that pointless checks are not needed at runtime.
>
> I am not sure what other changes I should make to stop people crashing the kernel by using this match in places I have not forseen.
I can look over it again to make sure thats not possible.
> I am not certain that my anticpated crashes are actually possible.
>
> Patrick, If I merely remove these unnecessary tests, will you be satisfied with the result?
Probably, I don't have the patch handy to look at it right now.
So far I don't intend to merge it, but I'm also not very opposed
to it (only reason against it is that its another file to take
care of when changing say function signatures and it doesn't
offer anything that we can't already do). Its up to you to
convince me :)
next prev parent reply other threads:[~2007-06-15 17:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-15 17:20 xt_gateway 20070605 (kernel) Amin Azez
2007-06-15 17:27 ` Patrick McHardy [this message]
2007-06-15 19:21 ` Jan Engelhardt
-- strict thread matches above, loose matches on Subject: below --
2007-06-16 9:29 Amin Azez
2007-06-16 12:00 ` Jan Engelhardt
2007-06-16 12:14 ` Amin Azex
2007-06-16 16:31 ` Amin Azex
2007-06-16 7:34 Amin Azez
2007-06-16 7:59 ` Jan Engelhardt
2007-06-06 15:58 Amin Azez
2007-06-06 16:06 ` Patrick McHardy
2007-06-06 7:01 Amin Azez
2007-06-05 11:17 xt_gateway 20070605 Jan Engelhardt
2007-06-05 11:17 ` xt_gateway 20070605 (kernel) Jan Engelhardt
2007-06-05 12:08 ` Jan Engelhardt
2007-06-05 15:15 ` Patrick McHardy
2007-06-05 15:20 ` Jan Engelhardt
2007-06-06 11:31 ` Patrick McHardy
[not found] ` <46727873.20503@ufomechanic.net>
2007-06-15 16:11 ` Jan Engelhardt
2007-06-15 16:15 ` Patrick McHardy
2007-06-05 22:24 ` Phil Oester
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4672CC03.9070906@trash.net \
--to=kaber@trash.net \
--cc=azez@ufomechanic.net \
--cc=jengelh@computergmbh.de \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.