From: Paul Mundt <lethal@linux-sh.org>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Sam Ravnborg <sam@ravnborg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: More __meminit annotations.
Date: Mon, 18 Jun 2007 14:58:42 +0900 [thread overview]
Message-ID: <20070618055842.GA17858@linux-sh.org> (raw)
In-Reply-To: <20070618143943.B108.Y-GOTO@jp.fujitsu.com>
On Mon, Jun 18, 2007 at 02:49:24PM +0900, Yasunori Goto wrote:
> > -static inline unsigned long zone_absent_pages_in_node(int nid,
> > +static inline unsigned long __meminit zone_absent_pages_in_node(int nid,
> > unsigned long zone_type,
> > unsigned long *zholes_size)
> > {
>
> I thought __meminit is not effective for these static functions,
> because they are inlined function. So, it depends on caller's
> defenition. Is it wrong?
>
Ah, that's possible, I hadn't considered that. It seems to be a bit more
obvious what the intention is if it's annotated, especially as this is
the convention that's used by the rest of mm/page_alloc.c. A bit more
consistent, if nothing more.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Sam Ravnborg <sam@ravnborg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: More __meminit annotations.
Date: Mon, 18 Jun 2007 14:58:42 +0900 [thread overview]
Message-ID: <20070618055842.GA17858@linux-sh.org> (raw)
In-Reply-To: <20070618143943.B108.Y-GOTO@jp.fujitsu.com>
On Mon, Jun 18, 2007 at 02:49:24PM +0900, Yasunori Goto wrote:
> > -static inline unsigned long zone_absent_pages_in_node(int nid,
> > +static inline unsigned long __meminit zone_absent_pages_in_node(int nid,
> > unsigned long zone_type,
> > unsigned long *zholes_size)
> > {
>
> I thought __meminit is not effective for these static functions,
> because they are inlined function. So, it depends on caller's
> defenition. Is it wrong?
>
Ah, that's possible, I hadn't considered that. It seems to be a bit more
obvious what the intention is if it's annotated, especially as this is
the convention that's used by the rest of mm/page_alloc.c. A bit more
consistent, if nothing more.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-06-18 6:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 4:52 [PATCH] mm: More __meminit annotations Paul Mundt
2007-06-18 4:52 ` Paul Mundt
2007-06-18 5:49 ` Yasunori Goto
2007-06-18 5:49 ` Yasunori Goto
2007-06-18 5:58 ` Paul Mundt [this message]
2007-06-18 5:58 ` Paul Mundt
2007-06-18 6:33 ` Yasunori Goto
2007-06-18 6:33 ` Yasunori Goto
2007-06-18 6:57 ` Satyam Sharma
2007-06-18 6:57 ` Satyam Sharma
2007-06-18 7:28 ` Satyam Sharma
2007-06-18 7:28 ` Satyam Sharma
2007-06-18 7:48 ` Sam Ravnborg
2007-06-18 7:48 ` Sam Ravnborg
2007-06-18 7:45 ` Sam Ravnborg
2007-06-18 7:45 ` Sam Ravnborg
2007-06-18 10:29 ` Satyam Sharma
2007-06-18 10:29 ` Satyam Sharma
2007-06-18 10:54 ` Sam Ravnborg
2007-06-18 10:54 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070618055842.GA17858@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sam@ravnborg.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.