From: Sam Ravnborg <sam@ravnborg.org>
To: Satyam Sharma <satyam.sharma@gmail.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
Paul Mundt <lethal@linux-sh.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: More __meminit annotations.
Date: Mon, 18 Jun 2007 12:54:52 +0200 [thread overview]
Message-ID: <20070618105452.GA22386@uranus.ravnborg.org> (raw)
In-Reply-To: <a781481a0706180329i688ece9fm4607c273ed3961bc@mail.gmail.com>
> But then what
> might happen is that everybody would think his particular use of inline
> is correct and beneficial and all users of inline in kernel would end up
> as __always_inline anyway.
You miss that there is a big difference between "beneficial" and "needs".
The latter is used when some assembly code has a specific knowlegde of
how parameters are passed or that the function signature for other good
reasons must not change.
It has nothing to do with "beneficial".
Any use of __always_inline outside arch/* is highly question able.
And most use of *inline* in drivers/* today is due to bad behaving gcc in the past.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Satyam Sharma <satyam.sharma@gmail.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
Paul Mundt <lethal@linux-sh.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: More __meminit annotations.
Date: Mon, 18 Jun 2007 12:54:52 +0200 [thread overview]
Message-ID: <20070618105452.GA22386@uranus.ravnborg.org> (raw)
In-Reply-To: <a781481a0706180329i688ece9fm4607c273ed3961bc@mail.gmail.com>
> But then what
> might happen is that everybody would think his particular use of inline
> is correct and beneficial and all users of inline in kernel would end up
> as __always_inline anyway.
You miss that there is a big difference between "beneficial" and "needs".
The latter is used when some assembly code has a specific knowlegde of
how parameters are passed or that the function signature for other good
reasons must not change.
It has nothing to do with "beneficial".
Any use of __always_inline outside arch/* is highly question able.
And most use of *inline* in drivers/* today is due to bad behaving gcc in the past.
Sam
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-06-18 10:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 4:52 [PATCH] mm: More __meminit annotations Paul Mundt
2007-06-18 4:52 ` Paul Mundt
2007-06-18 5:49 ` Yasunori Goto
2007-06-18 5:49 ` Yasunori Goto
2007-06-18 5:58 ` Paul Mundt
2007-06-18 5:58 ` Paul Mundt
2007-06-18 6:33 ` Yasunori Goto
2007-06-18 6:33 ` Yasunori Goto
2007-06-18 6:57 ` Satyam Sharma
2007-06-18 6:57 ` Satyam Sharma
2007-06-18 7:28 ` Satyam Sharma
2007-06-18 7:28 ` Satyam Sharma
2007-06-18 7:48 ` Sam Ravnborg
2007-06-18 7:48 ` Sam Ravnborg
2007-06-18 7:45 ` Sam Ravnborg
2007-06-18 7:45 ` Sam Ravnborg
2007-06-18 10:29 ` Satyam Sharma
2007-06-18 10:29 ` Satyam Sharma
2007-06-18 10:54 ` Sam Ravnborg [this message]
2007-06-18 10:54 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070618105452.GA22386@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=satyam.sharma@gmail.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.