[U-Boot-Users] [PATCH] ppc4xx: Remove sequoia/sequioa.h. Cleanup ppc440.h for PPC440EPX

[U-Boot-Users] [PATCH] ppc4xx: Remove sequoia/sequioa.h. Cleanup ppc440.h for PPC440EPX

[Niklaus Giger]

Signed-off-by: Niklaus Giger <niklaus.giger@netstal.com>
---
 board/amcc/sequoia/sequoia.c |   x 9 ++---
 board/amcc/sequoia/sequoia.h |   
67 ------------------------------------------
 include/ppc440.h             |    6 ++-
 3 files changed, 8 insertions(+), 74 deletions(-)
 delete mode 100644 board/amcc/sequoia/sequoia.h

diff --git a/board/amcc/sequoia/sequoia.c b/board/amcc/sequoia/sequoia.c
index ba365ae..748abef 100644
--- a/board/amcc/sequoia/sequoia.c
+++ b/board/amcc/sequoia/sequoia.c
@@ -25,7 +25,6 @@
 #include <common.h>
 #include <asm/processor.h>
 #include <ppc440.h>
-#include "sequoia.h"
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -226,7 +225,7 @@ int misc_init_r(void)
 	if (act == NULL || strcmp(act, "hostdev") == 0)	{
 		/* SDR Setting */
 		mfsdr(SDR0_PFC1, sdr0_pfc1);
-		mfsdr(SDR0_USB0, usb2d0cr);
+		mfsdr(SDR0_USB2D0CR, usb2d0cr);
 		mfsdr(SDR0_USB2PHY0CR, usb2phy0cr);
 		mfsdr(SDR0_USB2H0CR, usb2h0cr);
 
@@ -254,7 +253,7 @@ int misc_init_r(void)
 		sdr0_pfc1 = sdr0_pfc1 | SDR0_PFC1_UES_USB2D_SEL;		/*0*/
 
 		mtsdr(SDR0_PFC1, sdr0_pfc1);
-		mtsdr(SDR0_USB0, usb2d0cr);
+		mtsdr(SDR0_USB2D0CR, usb2d0cr);
 		mtsdr(SDR0_USB2PHY0CR, usb2phy0cr);
 		mtsdr(SDR0_USB2H0CR, usb2h0cr);
 
@@ -298,7 +297,7 @@ int misc_init_r(void)
 		/* SDR Setting */
 		mfsdr(SDR0_USB2PHY0CR, usb2phy0cr);
 		mfsdr(SDR0_USB2H0CR, usb2h0cr);
-		mfsdr(SDR0_USB0, usb2d0cr);
+		mfsdr(SDR0_USB2D0CR, usb2d0cr);
 		mfsdr(SDR0_PFC1, sdr0_pfc1);
 
 		usb2phy0cr = usb2phy0cr &~SDR0_USB2PHY0CR_XOCLK_MASK;
@@ -323,7 +322,7 @@ int misc_init_r(void)
 
 		mtsdr(SDR0_USB2H0CR, usb2h0cr);
 		mtsdr(SDR0_USB2PHY0CR, usb2phy0cr);
-		mtsdr(SDR0_USB0, usb2d0cr);
+		mtsdr(SDR0_USB2D0CR, usb2d0cr);
 		mtsdr(SDR0_PFC1, sdr0_pfc1);
 
 		/*clear resets*/
diff --git a/board/amcc/sequoia/sequoia.h b/board/amcc/sequoia/sequoia.h
deleted file mode 100644
index 1d44b16..0000000
--- a/board/amcc/sequoia/sequoia.h
+++ /dev/null
@@ -1,67 +0,0 @@
-/*
- * (C) Copyright 2006
- * Stefan Roese, DENX Software Engineering, sr at denx.de.
- *
- * (C) Copyright 2006
- * Jacqueline Pira-Ferriol, AMCC/IBM, jpira-ferriol at fr.ibm.com
- * Alain Saurel,            AMCC/IBM, alain.saurel at fr.ibm.com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- */
-
-
-/*----------------------------------------------------------------------------+
-  | EBC Configuration Register - EBC0_CFG
-  
+----------------------------------------------------------------------------*/
-/* External Bus Three-State Control */
-#define EBC0_CFG_EBTC_DRIVEN	    0x80000000
-/* Device-Paced Time-out Disable */
-#define EBC0_CFG_PTD_ENABLED	    0x00000000
-/* Ready Timeout Count */
-#define EBC0_CFG_RTC_MASK	    0x38000000
-#define EBC0_CFG_RTC_16PERCLK	    0x00000000
-#define EBC0_CFG_RTC_32PERCLK	    0x08000000
-#define EBC0_CFG_RTC_64PERCLK	    0x10000000
-#define EBC0_CFG_RTC_128PERCLK	    0x18000000
-#define EBC0_CFG_RTC_256PERCLK	    0x20000000
-#define EBC0_CFG_RTC_512PERCLK	    0x28000000
-#define EBC0_CFG_RTC_1024PERCLK	    0x30000000
-#define EBC0_CFG_RTC_2048PERCLK	    0x38000000
-/* External Master Priority Low */
-#define EBC0_CFG_EMPL_LOW	    0x00000000
-#define EBC0_CFG_EMPL_MEDIUM_LOW    0x02000000
-#define EBC0_CFG_EMPL_MEDIUM_HIGH   0x04000000
-#define EBC0_CFG_EMPL_HIGH	    0x06000000
-/* External Master Priority High */
-#define EBC0_CFG_EMPH_LOW	    0x00000000
-#define EBC0_CFG_EMPH_MEDIUM_LOW    0x00800000
-#define EBC0_CFG_EMPH_MEDIUM_HIGH   0x01000000
-#define EBC0_CFG_EMPH_HIGH	    0x01800000
-/* Chip Select Three-State Control */
-#define EBC0_CFG_CSTC_DRIVEN	    0x00400000
-/* Burst Prefetch */
-#define EBC0_CFG_BPF_ONEDW	    0x00000000
-#define EBC0_CFG_BPF_TWODW	    0x00100000
-#define EBC0_CFG_BPF_FOURDW	    0x00200000
-/* External Master Size */
-#define EBC0_CFG_EMS_8BIT	    0x00000000
-/* Power Management Enable */
-#define EBC0_CFG_PME_DISABLED	    0x00000000
-#define EBC0_CFG_PME_ENABLED	    0x00020000
-/* Power Management Timer */
-#define EBC0_CFG_PMT_ENCODE(n)		((((unsigned long)(n))&0x1F)<<12)
-
-#define SDR0_USB0                    0x0320     /* USB Control Register */
diff --git a/include/ppc440.h b/include/ppc440.h
index 09f8430..8d7781d 100644
--- a/include/ppc440.h
+++ b/include/ppc440.h
@@ -1023,7 +1023,7 @@
 #endif /* defined(CONFIG_440EP) || defined(CONFIG_440GR) */
 
 #if defined(CONFIG_440EPX) || defined(CONFIG_440GRX)
-#define SDR_USB2D0CR                 0x0320
+#define SDR0_USB2D0CR                 0x0320
 #define   SDR0_USB2D0CR_USB2DEV_EBC_SEL_MASK   0x00000004    /* USB 2.0 
Device/EBC Master Selection */
 #define   SDR0_USB2D0CR_USB2DEV_SELECTION      0x00000004    /* USB 2.0 
Device Selection */
 #define   SDR0_USB2D0CR_EBC_SELECTION          0x00000000    /* EBC Selection 
*/
@@ -1421,7 +1421,7 @@
 #define uicvr  uic0vr
 #define uicvcr uic0vcr
 
-#if defined(CONFIG_440SPE)
+#if defined(CONFIG_440SPE) || defined(CONFIG_440EPX)
 /*----------------------------------------------------------------------------+
 | Clock / Power-on-reset DCR's.
 
+----------------------------------------------------------------------------*/
@@ -1490,9 +1490,11 @@
 #define CPR0_OPBD_OPBDV0_DECODE(n)	((((((unsigned long)(n))>>24)-1)&0x03)+1)
 
 #define CPR0_PERD			0xE0
+#if !defined(CONFIG_440EPX)
 #define CPR0_PERD_PERDV0_MASK		0x03000000
 #define CPR0_PERD_PERDV0_ENCODE(n)	((((unsigned long)(n))&0x03)<<24)
 #define CPR0_PERD_PERDV0_DECODE(n)	((((((unsigned long)(n))>>24)-1)&0x03)+1)
+#endif
 
 #define CPR0_MALD			0x100
 #define CPR0_MALD_MALDV0_MASK		0x03000000
-- 
1.5.2

-- 
Niklaus Giger
Netstal Maschinen AG
CH-8752 N?fels

[U-Boot-Users] [PATCH] ppc4xx: Remove sequoia/sequioa.h. Cleanup ppc440.h for PPC440EPX

[Stefan Roese]

Hi Niklaus,

thanks. Unfortunately line wrapped (again). Please fix this and resubmit.

BTW: I'll be gone for a week beginning tomorrow. So don't expect new answers 
from me in this time.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot-Users] [PATCH] ppc4xx: Remove sequoia/sequioa.h. Cleanup ppc440.h for PPC440EPX

[Niklaus Giger]

On Monday 25 June 2007 17:05:45 Stefan Roese wrote:
> Hi Niklaus,
>
> thanks. Unfortunately line wrapped (again). Please fix this and resubmit.
Hi Stefan

The only lines which I exceed 80 characters are lines that my patch does not 
touch or removes them. Is it my duty to fix all lines which are too long in a 
source file? Or did I miss a line?

Does the limit of 80 characters also apply to *.h-files? If yes, we have about 
485 lines to fix in include/ppc*.h.

BTW: I'll be gone for three weeks next sunday. So don't expect an answer 
before end of July.

Best regards

Niklaus
> BTW: I'll be gone for a week beginning tomorrow. So don't expect new
> answers
>
> >from me in this time.
>
> Best regards,
> Stefan
>
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================



-- 
Niklaus Giger
Netstal Maschinen AG
CH-8752 N?fels

[U-Boot-Users] [PATCH] ppc4xx: Remove sequoia/sequioa.h. Cleanup ppc440.h for PPC440EPX

[Stefan Roese]

Hi Niklaus,

On Monday 25 June 2007, Niklaus Giger wrote:
> The only lines which I exceed 80 characters are lines that my patch does
> not touch or removes them. Is it my duty to fix all lines which are too
> long in a source file? Or did I miss a line?

I'm not talking about too long coding lines, but the line wrap most likely 
caused by your mail client. For example the sequoia.h file (even if removed) 
has some line wraps which case that the patch can't be applied clean.

> Does the limit of 80 characters also apply to *.h-files? If yes, we have
> about 485 lines to fix in include/ppc*.h.

Normally the 80 characters line length also apply the the headers (all source 
code files). But you don't have to clean up existing code. Please just make 
sure that your mail client doesn't warp the lines upon sending.

Hint: Please send the mail first to yourself and try to apply the patch to 
your repository. If this works without any problems you can send it to the 
list.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot-Users] [PATCH] ppc4xx: Remove sequoia/sequioa.h. Cleanup ppc440.h for PPC440EPX

[Niklaus Giger]

On Monday 25 June 2007 20:16:21 Stefan Roese wrote:
> Hi Niklaus,
> 
> On Monday 25 June 2007, Niklaus Giger wrote:
> > The only lines which I exceed 80 characters are lines that my patch does
> > not touch or removes them. Is it my duty to fix all lines which are too
> > long in a source file? Or did I miss a line?
> 
> I'm not talking about too long coding lines, but the line wrap most likely 
> caused by your mail client. For example the sequoia.h file (even if removed) 
> has some line wraps which case that the patch can't be applied clean.
> 
> > Does the limit of 80 characters also apply to *.h-files? If yes, we have
> > about 485 lines to fix in include/ppc*.h.
> 
> Normally the 80 characters line length also apply the the headers (all source 
> code files). But you don't have to clean up existing code. Please just make 
> sure that your mail client doesn't warp the lines upon sending.
> 
> Hint: Please send the mail first to yourself and try to apply the patch to 
> your repository. If this works without any problems you can send it to the 
> list.
a) disabled automatic line wrapping in my kmail settings.
b) Finally tracked down the problem, that kmail  changes the encoding from 
"us-ascii" to "iso-8859-1" as soon as it sees a signature with a "?" like in
N?fels. Then the lines with "---" get replaced by "=2d--" (as seen by vi).
Weird behaviour.

Resubmitted patch will follow

-- 
Niklaus Giger
Netstal Maschinen AG
CH-8752 Naefels