From: Andrew Morton <akpm@linux-foundation.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: bk@suse.de, michal.k.k.piotrowski@gmail.com, ak@suse.de,
linux-kernel@vger.kernel.org, linux@horizon.com,
linux-pm@lists.linux-foundation.org
Subject: Re: 2.6.22-rcX Transmeta/APM regression
Date: Sat, 30 Jun 2007 02:18:47 -0700 [thread overview]
Message-ID: <20070630021847.ec7ae2b6.akpm@linux-foundation.org> (raw)
In-Reply-To: <4685D6CC.9070007@zytor.com>
On Sat, 30 Jun 2007 00:06:36 -0400 "H. Peter Anvin" <hpa@zytor.com> wrote:
> linux@horizon.com wrote:
> >
> > Anyway, the patch which introduces the problem is the aptly named 3ebad:
> > 3ebad59056: [PATCH] x86: Save and restore the fixed-range MTRRs of the BSP when suspending
> >
> > 2.6.22-rc6 plus that one commit reverted successfully does APM suspend
> > (and resume) for me.
>
> Okay, I would guess that that patch probably touches MTRRs without
> actually verify that the CPU *has* MTRRs -- the Transmeta Crusoe CPU
> doesn't have MTRRs.
>
This?
--- a/arch/i386/kernel/cpu/mtrr/generic.c~i386-mtrr-crash-fix
+++ a/arch/i386/kernel/cpu/mtrr/generic.c
@@ -65,7 +65,8 @@ get_fixed_ranges(mtrr_type * frs)
void mtrr_save_fixed_ranges(void *info)
{
- get_fixed_ranges(mtrr_state.fixed_ranges);
+ if (cpu_has_mtrr)
+ get_fixed_ranges(mtrr_state.fixed_ranges);
}
static void print_fixed(unsigned base, unsigned step, const mtrr_type*types)
_
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux@horizon.com, linux-kernel@vger.kernel.org,
linux-pm@lists.linux-foundation.org, ak@suse.de, bk@suse.de,
michal.k.k.piotrowski@gmail.com
Subject: Re: 2.6.22-rcX Transmeta/APM regression
Date: Sat, 30 Jun 2007 02:18:47 -0700 [thread overview]
Message-ID: <20070630021847.ec7ae2b6.akpm@linux-foundation.org> (raw)
In-Reply-To: <4685D6CC.9070007@zytor.com>
On Sat, 30 Jun 2007 00:06:36 -0400 "H. Peter Anvin" <hpa@zytor.com> wrote:
> linux@horizon.com wrote:
> >
> > Anyway, the patch which introduces the problem is the aptly named 3ebad:
> > 3ebad59056: [PATCH] x86: Save and restore the fixed-range MTRRs of the BSP when suspending
> >
> > 2.6.22-rc6 plus that one commit reverted successfully does APM suspend
> > (and resume) for me.
>
> Okay, I would guess that that patch probably touches MTRRs without
> actually verify that the CPU *has* MTRRs -- the Transmeta Crusoe CPU
> doesn't have MTRRs.
>
This?
--- a/arch/i386/kernel/cpu/mtrr/generic.c~i386-mtrr-crash-fix
+++ a/arch/i386/kernel/cpu/mtrr/generic.c
@@ -65,7 +65,8 @@ get_fixed_ranges(mtrr_type * frs)
void mtrr_save_fixed_ranges(void *info)
{
- get_fixed_ranges(mtrr_state.fixed_ranges);
+ if (cpu_has_mtrr)
+ get_fixed_ranges(mtrr_state.fixed_ranges);
}
static void print_fixed(unsigned base, unsigned step, const mtrr_type*types)
_
next prev parent reply other threads:[~2007-06-30 9:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-27 15:31 2.6.22-rcX Transmeta/APM regression linux
2007-06-27 21:26 ` Chuck Ebbert
2007-06-27 23:44 ` linux
2007-06-30 3:03 ` linux
2007-06-30 4:06 ` H. Peter Anvin
2007-06-30 4:06 ` H. Peter Anvin
2007-06-30 9:18 ` Andrew Morton [this message]
2007-06-30 9:18 ` Andrew Morton
2007-06-30 9:26 ` Andi Kleen
2007-06-30 9:26 ` Andi Kleen
2007-06-30 18:57 ` linux
2007-06-30 18:57 ` linux
2007-06-30 19:08 ` Andrew Morton
2007-06-30 19:08 ` Andrew Morton
2007-06-30 3:03 ` linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070630021847.ec7ae2b6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=bk@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux@horizon.com \
--cc=michal.k.k.piotrowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.