From: Andi Kleen <ak@suse.de>
To: linux@horizon.com
Cc: bk@suse.de, linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, michal.k.k.piotrowski@gmail.com,
hpa@zytor.com
Subject: Re: 2.6.22-rcX Transmeta/APM regression
Date: Sat, 30 Jun 2007 11:26:40 +0200 [thread overview]
Message-ID: <200706301126.41179.ak@suse.de> (raw)
In-Reply-To: <20070630030343.31711.qmail@science.horizon.com>
On Saturday 30 June 2007 05:03, linux@horizon.com wrote:
> Anyway, the patch which introduces the problem is the aptly named 3ebad:
> 3ebad59056: [PATCH] x86: Save and restore the fixed-range MTRRs of the BSP
> when suspending
>
> 2.6.22-rc6 plus that one commit reverted successfully does APM suspend
> (and resume) for me.
Mr.Linux, Does that patch fix it?
-Andi
i386: Check if CPU has MTRRs before trying to save them
Signed-off-by: Andi Kleen <ak@suse.de>
Index: linux/arch/i386/kernel/cpu/mtrr/main.c
===================================================================
--- linux.orig/arch/i386/kernel/cpu/mtrr/main.c
+++ linux/arch/i386/kernel/cpu/mtrr/main.c
@@ -734,8 +734,11 @@ void mtrr_ap_init(void)
*/
void mtrr_save_state(void)
{
- int cpu = get_cpu();
+ int cpu;
+ if (!cpu_has_mtrr)
+ return;
+ cpu = get_cpu();
if (cpu == 0)
mtrr_save_fixed_ranges(NULL);
else
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: linux@horizon.com
Cc: linux-kernel@vger.kernel.org,
linux-pm@lists.linux-foundation.org, bk@suse.de, hpa@zytor.com,
michal.k.k.piotrowski@gmail.com
Subject: Re: 2.6.22-rcX Transmeta/APM regression
Date: Sat, 30 Jun 2007 11:26:40 +0200 [thread overview]
Message-ID: <200706301126.41179.ak@suse.de> (raw)
In-Reply-To: <20070630030343.31711.qmail@science.horizon.com>
On Saturday 30 June 2007 05:03, linux@horizon.com wrote:
> Anyway, the patch which introduces the problem is the aptly named 3ebad:
> 3ebad59056: [PATCH] x86: Save and restore the fixed-range MTRRs of the BSP
> when suspending
>
> 2.6.22-rc6 plus that one commit reverted successfully does APM suspend
> (and resume) for me.
Mr.Linux, Does that patch fix it?
-Andi
i386: Check if CPU has MTRRs before trying to save them
Signed-off-by: Andi Kleen <ak@suse.de>
Index: linux/arch/i386/kernel/cpu/mtrr/main.c
===================================================================
--- linux.orig/arch/i386/kernel/cpu/mtrr/main.c
+++ linux/arch/i386/kernel/cpu/mtrr/main.c
@@ -734,8 +734,11 @@ void mtrr_ap_init(void)
*/
void mtrr_save_state(void)
{
- int cpu = get_cpu();
+ int cpu;
+ if (!cpu_has_mtrr)
+ return;
+ cpu = get_cpu();
if (cpu == 0)
mtrr_save_fixed_ranges(NULL);
else
next prev parent reply other threads:[~2007-06-30 9:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-27 15:31 2.6.22-rcX Transmeta/APM regression linux
2007-06-27 21:26 ` Chuck Ebbert
2007-06-27 23:44 ` linux
2007-06-30 3:03 ` linux
2007-06-30 4:06 ` H. Peter Anvin
2007-06-30 4:06 ` H. Peter Anvin
2007-06-30 9:18 ` Andrew Morton
2007-06-30 9:18 ` Andrew Morton
2007-06-30 9:26 ` Andi Kleen [this message]
2007-06-30 9:26 ` Andi Kleen
2007-06-30 18:57 ` linux
2007-06-30 18:57 ` linux
2007-06-30 19:08 ` Andrew Morton
2007-06-30 19:08 ` Andrew Morton
2007-06-30 3:03 ` linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706301126.41179.ak@suse.de \
--to=ak@suse.de \
--cc=bk@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux@horizon.com \
--cc=michal.k.k.piotrowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.