From: Adrian Bunk <bunk@stusta.de>
To: "Hans-Jürgen Koch" <hjk@linutronix.de>,
"Mark M. Hoffman" <mhoffman@lightlink.com>
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: [lm-sensors] drivers/hwmon/lm93.c: array overruns
Date: Mon, 23 Jul 2007 00:54:53 +0000 [thread overview]
Message-ID: <20070723005453.GS26212@stusta.de> (raw)
The Coverity checker spotted the following array overruns
in drivers/hwmon/lm93.c:
<-- snip -->
...
struct lm93_data {
...
struct {
u8 min;
u8 max;
} temp_lim[3];
...
};
...
static void lm93_update_client_common(struct lm93_data *data,
struct i2c_client *client)
{
...
for (i = 0; i < 4; i++) {
data->temp_lim[i].min lm93_read_byte(client, LM93_REG_TEMP_MIN(i));
data->temp_lim[i].max lm93_read_byte(client, LM93_REG_TEMP_MAX(i));
}
...
<-- snip -->
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: "Hans-Jürgen Koch" <hjk@linutronix.de>,
"Mark M. Hoffman" <mhoffman@lightlink.com>
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: drivers/hwmon/lm93.c: array overruns
Date: Mon, 23 Jul 2007 02:54:53 +0200 [thread overview]
Message-ID: <20070723005453.GS26212@stusta.de> (raw)
The Coverity checker spotted the following array overruns
in drivers/hwmon/lm93.c:
<-- snip -->
...
struct lm93_data {
...
struct {
u8 min;
u8 max;
} temp_lim[3];
...
};
...
static void lm93_update_client_common(struct lm93_data *data,
struct i2c_client *client)
{
...
for (i = 0; i < 4; i++) {
data->temp_lim[i].min =
lm93_read_byte(client, LM93_REG_TEMP_MIN(i));
data->temp_lim[i].max =
lm93_read_byte(client, LM93_REG_TEMP_MAX(i));
}
...
<-- snip -->
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next reply other threads:[~2007-07-23 0:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 0:54 Adrian Bunk [this message]
2007-07-23 0:54 ` drivers/hwmon/lm93.c: array overruns Adrian Bunk
2007-07-23 7:36 ` [lm-sensors] " Hans-Jürgen Koch
2007-07-23 7:36 ` Hans-Jürgen Koch
2007-07-24 8:10 ` [lm-sensors] " Jean Delvare
2007-07-24 8:10 ` Jean Delvare
2007-07-24 8:26 ` Hans-Jürgen Koch
2007-07-24 8:26 ` Hans-Jürgen Koch
2007-07-24 12:00 ` Jean Delvare
2007-07-24 12:00 ` Jean Delvare
2007-07-24 13:00 ` Mark M. Hoffman
2007-07-24 13:00 ` Mark M. Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070723005453.GS26212@stusta.de \
--to=bunk@stusta.de \
--cc=hjk@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.