All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: "Hans-Jürgen Koch" <hjk@linutronix.de>
Cc: Adrian Bunk <bunk@stusta.de>,
	"Mark M. Hoffman" <mhoffman@lightlink.com>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] drivers/hwmon/lm93.c: array overruns
Date: Tue, 24 Jul 2007 08:10:20 +0000	[thread overview]
Message-ID: <20070724101020.0f1bf458@hyperion.delvare> (raw)
In-Reply-To: <200707230936.58135.hjk@linutronix.de>

Hi Hans,

On Mon, 23 Jul 2007 09:36:57 +0200, Hans-Jürgen Koch wrote:
> Am Montag 23 Juli 2007 02:54 schrieb Adrian Bunk:
> > The Coverity checker spotted the following array overruns
> > in drivers/hwmon/lm93.c:
> > 
> > <--  snip  -->
> > 
> > ...
> > struct lm93_data {
> > ...
> >         struct {
> >                 u8 min;
> >                 u8 max;
> >         } temp_lim[3];
> > ...
> > };
> > ...
> > static void lm93_update_client_common(struct lm93_data *data,
> >                                       struct i2c_client *client)
> > {
> > ...
> >         for (i = 0; i < 4; i++) {
> >                 data->temp_lim[i].min > >                         lm93_read_byte(client, LM93_REG_TEMP_MIN(i));
> >                 data->temp_lim[i].max > >                         lm93_read_byte(client, LM93_REG_TEMP_MAX(i));
> >         }
> > ...
> > 
> > <--  snip  -->
> 
> This patch should fix it. Thanks a lot, Adrian!
> 
> ----
> This fixes an array overflow bug. We have 4 pairs of min/max temperature 
> limits, not 3.
> 
> Signed-off-by: Hans J. Koch <hjk@linutronix.de>
> 
> --
> Index: linux-2.6.23-rc/drivers/hwmon/lm93.c
> =================================> --- linux-2.6.23-rc.orig/drivers/hwmon/lm93.c	2007-07-23 09:22:56.000000000 +0200
> +++ linux-2.6.23-rc/drivers/hwmon/lm93.c	2007-07-23 09:29:37.000000000 +0200
> @@ -234,7 +234,7 @@
>  	struct {
>  		u8 min;
>  		u8 max;
> -	} temp_lim[3];
> +	} temp_lim[4];
>  
>  	/* vin1 - vin16: low and high limits */
>  	struct {

This will do as a quick fix, so:

Acked-by: Jean Delvare <khali@linux-fr.org>

However, I see that temp4 (which isn't a real temperature channel) is
not exposed in sysfs. Reading and storing register values you never use
doesn't seem particularly interesting, so something needs to be done
here: either drop support for temp4 entirely, or expose the temp4
values in sysfs.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: "Hans-Jürgen Koch" <hjk@linutronix.de>
Cc: Adrian Bunk <bunk@stusta.de>,
	"Mark M. Hoffman" <mhoffman@lightlink.com>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] drivers/hwmon/lm93.c: array overruns
Date: Tue, 24 Jul 2007 10:10:20 +0200	[thread overview]
Message-ID: <20070724101020.0f1bf458@hyperion.delvare> (raw)
In-Reply-To: <200707230936.58135.hjk@linutronix.de>

Hi Hans,

On Mon, 23 Jul 2007 09:36:57 +0200, Hans-Jürgen Koch wrote:
> Am Montag 23 Juli 2007 02:54 schrieb Adrian Bunk:
> > The Coverity checker spotted the following array overruns
> > in drivers/hwmon/lm93.c:
> > 
> > <--  snip  -->
> > 
> > ...
> > struct lm93_data {
> > ...
> >         struct {
> >                 u8 min;
> >                 u8 max;
> >         } temp_lim[3];
> > ...
> > };
> > ...
> > static void lm93_update_client_common(struct lm93_data *data,
> >                                       struct i2c_client *client)
> > {
> > ...
> >         for (i = 0; i < 4; i++) {
> >                 data->temp_lim[i].min =
> >                         lm93_read_byte(client, LM93_REG_TEMP_MIN(i));
> >                 data->temp_lim[i].max =
> >                         lm93_read_byte(client, LM93_REG_TEMP_MAX(i));
> >         }
> > ...
> > 
> > <--  snip  -->
> 
> This patch should fix it. Thanks a lot, Adrian!
> 
> ----
> This fixes an array overflow bug. We have 4 pairs of min/max temperature 
> limits, not 3.
> 
> Signed-off-by: Hans J. Koch <hjk@linutronix.de>
> 
> --
> Index: linux-2.6.23-rc/drivers/hwmon/lm93.c
> ===================================================================
> --- linux-2.6.23-rc.orig/drivers/hwmon/lm93.c	2007-07-23 09:22:56.000000000 +0200
> +++ linux-2.6.23-rc/drivers/hwmon/lm93.c	2007-07-23 09:29:37.000000000 +0200
> @@ -234,7 +234,7 @@
>  	struct {
>  		u8 min;
>  		u8 max;
> -	} temp_lim[3];
> +	} temp_lim[4];
>  
>  	/* vin1 - vin16: low and high limits */
>  	struct {

This will do as a quick fix, so:

Acked-by: Jean Delvare <khali@linux-fr.org>

However, I see that temp4 (which isn't a real temperature channel) is
not exposed in sysfs. Reading and storing register values you never use
doesn't seem particularly interesting, so something needs to be done
here: either drop support for temp4 entirely, or expose the temp4
values in sysfs.

-- 
Jean Delvare

  reply	other threads:[~2007-07-24  8:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-23  0:54 [lm-sensors] drivers/hwmon/lm93.c: array overruns Adrian Bunk
2007-07-23  0:54 ` Adrian Bunk
2007-07-23  7:36 ` [lm-sensors] " Hans-Jürgen Koch
2007-07-23  7:36   ` Hans-Jürgen Koch
2007-07-24  8:10   ` Jean Delvare [this message]
2007-07-24  8:10     ` [lm-sensors] " Jean Delvare
2007-07-24  8:26     ` Hans-Jürgen Koch
2007-07-24  8:26       ` Hans-Jürgen Koch
2007-07-24 12:00       ` Jean Delvare
2007-07-24 12:00         ` Jean Delvare
2007-07-24 13:00   ` Mark M. Hoffman
2007-07-24 13:00     ` Mark M. Hoffman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070724101020.0f1bf458@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=bunk@stusta.de \
    --cc=hjk@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mhoffman@lightlink.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.