* [Ocfs2-devel] [2.6 patch] ocfs2_insert_extent(): remove dead code
@ 2007-07-23 8:01 ` Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2007-07-23 1:01 UTC (permalink / raw)
To: mark.fasheh, kurt.hackel; +Cc: ocfs2-devel, linux-kernel
This patch removes some now dead code.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/ocfs2/alloc.c | 4 ----
1 file changed, 4 deletions(-)
--- linux-2.6.22-rc6-mm1/fs/ocfs2/alloc.c.old 2007-07-23 01:29:25.000000000 +0200
+++ linux-2.6.22-rc6-mm1/fs/ocfs2/alloc.c 2007-07-23 01:29:52.000000000 +0200
@@ -3500,7 +3500,6 @@ int ocfs2_insert_extent(struct ocfs2_sup
{
int status;
struct buffer_head *last_eb_bh = NULL;
- struct buffer_head *bh = NULL;
struct ocfs2_insert_type insert = {0, };
struct ocfs2_extent_rec rec;
@@ -3552,9 +3551,6 @@ int ocfs2_insert_extent(struct ocfs2_sup
ocfs2_extent_map_insert_rec(inode, &rec);
bail:
- if (bh)
- brelse(bh);
-
if (last_eb_bh)
brelse(last_eb_bh);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] ocfs2_insert_extent(): remove dead code
@ 2007-07-23 8:01 ` Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2007-07-23 8:01 UTC (permalink / raw)
To: mark.fasheh, kurt.hackel; +Cc: ocfs2-devel, linux-kernel
This patch removes some now dead code.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/ocfs2/alloc.c | 4 ----
1 file changed, 4 deletions(-)
--- linux-2.6.22-rc6-mm1/fs/ocfs2/alloc.c.old 2007-07-23 01:29:25.000000000 +0200
+++ linux-2.6.22-rc6-mm1/fs/ocfs2/alloc.c 2007-07-23 01:29:52.000000000 +0200
@@ -3500,7 +3500,6 @@ int ocfs2_insert_extent(struct ocfs2_sup
{
int status;
struct buffer_head *last_eb_bh = NULL;
- struct buffer_head *bh = NULL;
struct ocfs2_insert_type insert = {0, };
struct ocfs2_extent_rec rec;
@@ -3552,9 +3551,6 @@ int ocfs2_insert_extent(struct ocfs2_sup
ocfs2_extent_map_insert_rec(inode, &rec);
bail:
- if (bh)
- brelse(bh);
-
if (last_eb_bh)
brelse(last_eb_bh);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Ocfs2-devel] Re: [2.6 patch] ocfs2_insert_extent(): remove dead code
2007-07-23 8:01 ` Adrian Bunk
@ 2007-07-24 12:53 ` Mark Fasheh
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Fasheh @ 2007-07-24 5:53 UTC (permalink / raw)
To: Adrian Bunk; +Cc: kurt.hackel, ocfs2-devel, linux-kernel
On Mon, Jul 23, 2007 at 10:01:21AM +0200, Adrian Bunk wrote:
> This patch removes some now dead code.
Yep - thanks Adrian.
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] ocfs2_insert_extent(): remove dead code
@ 2007-07-24 12:53 ` Mark Fasheh
0 siblings, 0 replies; 4+ messages in thread
From: Mark Fasheh @ 2007-07-24 12:53 UTC (permalink / raw)
To: Adrian Bunk; +Cc: kurt.hackel, ocfs2-devel, linux-kernel
On Mon, Jul 23, 2007 at 10:01:21AM +0200, Adrian Bunk wrote:
> This patch removes some now dead code.
Yep - thanks Adrian.
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-07-24 12:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-23 1:01 [Ocfs2-devel] [2.6 patch] ocfs2_insert_extent(): remove dead code Adrian Bunk
2007-07-23 8:01 ` Adrian Bunk
2007-07-24 5:53 ` [Ocfs2-devel] " Mark Fasheh
2007-07-24 12:53 ` Mark Fasheh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.