[rfc/patch] ntfs reduce syslog noise

[rfc/patch] ntfs reduce syslog noise

[maximilian attems]

user complained on syslog spamming by
NTFS-fs error (device hda7): ntfs_ucstonls(): Unicode name contains characters that cannot be converted to character set koi8-r.  You might want to try to use the mount option nls=utf8.
NTFS-fs warning (device hda7): ntfs_filldir(): Skipping unrepresentable inode 0x130cc.
-> http://bugs.debian.org/351009

the custom ntfs loglevel are a pain as they encode the
KERN_ERR printk level for any ntfs_warning() call

belows patch tries to tame one of the 2 complaints.

diff --git a/fs/ntfs/dir.c b/fs/ntfs/dir.c
index 34314b3..10cc8d9 100644
--- a/fs/ntfs/dir.c
+++ b/fs/ntfs/dir.c
@@ -1050,7 +1050,7 @@ static inline int ntfs_filldir(ntfs_volume *vol, loff_t fpos,
 			ie->key.file_name.file_name_length, &name,
 			NTFS_MAX_NAME_LEN * NLS_MAX_CHARSET_SIZE + 1);
 	if (name_len <= 0) {
-		ntfs_warning(vol->sb, "Skipping unrepresentable inode 0x%llx.",
+		ntfs_debug(vol->sb, "Skipping unrepresentable inode 0x%llx.",
 				(long long)MREF_LE(ie->data.dir.indexed_file));
 		return 0;
 	}

Re: [rfc/patch] ntfs reduce syslog noise

[Anton Altaparmakov]

On 28 Jul 2007, at 22:10, maximilian attems wrote:
> user complained on syslog spamming by
> NTFS-fs error (device hda7): ntfs_ucstonls(): Unicode name contains  
> characters that cannot be converted to character set koi8-r.  You  
> might want to try to use the mount option nls=utf8.
> NTFS-fs warning (device hda7): ntfs_filldir(): Skipping  
> unrepresentable inode 0x130cc.
> -> http://bugs.debian.org/351009
>
> the custom ntfs loglevel are a pain as they encode the
> KERN_ERR printk level for any ntfs_warning() call
>
> belows patch tries to tame one of the 2 complaints.
>
> diff --git a/fs/ntfs/dir.c b/fs/ntfs/dir.c
> index 34314b3..10cc8d9 100644
> --- a/fs/ntfs/dir.c
> +++ b/fs/ntfs/dir.c
> @@ -1050,7 +1050,7 @@ static inline int ntfs_filldir(ntfs_volume  
> *vol, loff_t fpos,
>  			ie->key.file_name.file_name_length, &name,
>  			NTFS_MAX_NAME_LEN * NLS_MAX_CHARSET_SIZE + 1);
>  	if (name_len <= 0) {
> -		ntfs_warning(vol->sb, "Skipping unrepresentable inode 0x%llx.",
> +		ntfs_debug(vol->sb, "Skipping unrepresentable inode 0x%llx.",
>  				(long long)MREF_LE(ie->data.dir.indexed_file));
>  		return 0;
>  	}

This patch won't even compile!  ntfs_debug() does not take a  
superblock structure as the first argument...

Also I want the inode warning to remain because it allows people to  
know which inode it is so they can go and fix it by renaming it  
something else for example.

And the message does give the user a solution to the problem.  Mount  
with nls=utf8 mount option and you will not see those error messages  
any more and everything will work just fine.

The messages are all ratelimited thus should not spam the logs too  
badly for users who choose to ignore them instead of doing something  
about it...

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer, http://www.linux-ntfs.org/

Re: [rfc/patch] ntfs reduce syslog noise

[maximilian attems]

On Sat, Jul 28, 2007 at 11:26:18PM +0100, Anton Altaparmakov wrote:
> On 28 Jul 2007, at 22:10, maximilian attems wrote:
<snipp faulty patch>
> This patch won't even compile!  ntfs_debug() does not take a  
> superblock structure as the first argument...

yup, hadn't looked up good enough those dprintk, sorry.
 
> Also I want the inode warning to remain because it allows people to  
> know which inode it is so they can go and fix it by renaming it  
> something else for example.
> 
> And the message does give the user a solution to the problem.  Mount  
> with nls=utf8 mount option and you will not see those error messages  
> any more and everything will work just fine.
> 
> The messages are all ratelimited thus should not spam the logs too  
> badly for users who choose to ignore them instead of doing something  
> about it...

thanks for quick answer!
user had asked for eventual quiet param,
but i see no such in any other fs, so..

happy weekend

-- 
maks