All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org, torvalds@linux-foundation.org
Subject: Re: [RFC PATCH] type safe allocator
Date: Wed, 1 Aug 2007 11:29:09 +0200	[thread overview]
Message-ID: <20070801092909.GN3972@stusta.de> (raw)
In-Reply-To: <E1IGAAI-0006K6-00@dorka.pomaz.szeredi.hu>

On Wed, Aug 01, 2007 at 11:06:46AM +0200, Miklos Szeredi wrote:
> I wonder why we don't have type safe object allocators a-la new() in
> C++ or g_new() in glib?
> 
>   fooptr = k_new(struct foo, GFP_KERNEL);
> 
> is nicer and more descriptive than
> 
>   fooptr = kmalloc(sizeof(*fooptr), GFP_KERNEL);
>...

But it's much more likely to break when someone converts fooptr to a 
different struct.

It might not be a common case but it sometimes happens - and your type 
safe variant introduces the possibility for really nasty bugs.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org, torvalds@linux-foundation.org
Subject: Re: [RFC PATCH] type safe allocator
Date: Wed, 1 Aug 2007 11:29:09 +0200	[thread overview]
Message-ID: <20070801092909.GN3972@stusta.de> (raw)
In-Reply-To: <E1IGAAI-0006K6-00@dorka.pomaz.szeredi.hu>

On Wed, Aug 01, 2007 at 11:06:46AM +0200, Miklos Szeredi wrote:
> I wonder why we don't have type safe object allocators a-la new() in
> C++ or g_new() in glib?
> 
>   fooptr = k_new(struct foo, GFP_KERNEL);
> 
> is nicer and more descriptive than
> 
>   fooptr = kmalloc(sizeof(*fooptr), GFP_KERNEL);
>...

But it's much more likely to break when someone converts fooptr to a 
different struct.

It might not be a common case but it sometimes happens - and your type 
safe variant introduces the possibility for really nasty bugs.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-08-01  9:29 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01  9:06 [RFC PATCH] type safe allocator Miklos Szeredi
2007-08-01  9:06 ` Miklos Szeredi
2007-08-01  9:29 ` Adrian Bunk [this message]
2007-08-01  9:29   ` Adrian Bunk
2007-08-01  9:41   ` Miklos Szeredi
2007-08-01  9:41     ` Miklos Szeredi
2007-08-01 10:44 ` Andi Kleen
2007-08-01 10:44   ` Andi Kleen
2007-08-01  9:57   ` Miklos Szeredi
2007-08-01  9:57     ` Miklos Szeredi
2007-08-01 11:34     ` Andi Kleen
2007-08-01 11:34       ` Andi Kleen
2007-08-01 10:45       ` Miklos Szeredi
2007-08-01 10:45         ` Miklos Szeredi
2007-08-01 11:44         ` Jan Engelhardt
2007-08-01 11:44           ` Jan Engelhardt
2007-08-01 11:56           ` Miklos Szeredi
2007-08-01 11:56             ` Miklos Szeredi
2007-08-02  3:56 ` Linus Torvalds
2007-08-02  3:56   ` Linus Torvalds
2007-08-02  7:27   ` Miklos Szeredi
2007-08-02  7:27     ` Miklos Szeredi
2007-08-02 12:05     ` Al Viro
2007-08-02 12:05       ` Al Viro
2007-08-02 13:05       ` Miklos Szeredi
2007-08-02 13:05         ` Miklos Szeredi
2007-08-02 17:23     ` Linus Torvalds
2007-08-02 17:23       ` Linus Torvalds
2007-08-02  5:33 ` Christoph Lameter
2007-08-02  5:33   ` Christoph Lameter
2007-08-02  7:38   ` Miklos Szeredi
2007-08-02  7:38     ` Miklos Szeredi
2007-08-02 19:16     ` Christoph Lameter
2007-08-02 19:16       ` Christoph Lameter
2007-08-02  7:37 ` Satyam Sharma
2007-08-02  7:37   ` Satyam Sharma
2007-08-02  7:40   ` Miklos Szeredi
2007-08-02  7:40     ` Miklos Szeredi
2007-08-02 11:31 ` [PATCH] " Miklos Szeredi
2007-08-02 11:31   ` Miklos Szeredi, Miklos Szeredi
2007-08-02 12:04   ` Alexey Dobriyan
2007-08-02 12:04     ` Alexey Dobriyan
2007-08-02 12:24     ` Jan Engelhardt
2007-08-02 12:24       ` Jan Engelhardt
2007-08-02 13:06       ` Miklos Szeredi
2007-08-02 13:06         ` Miklos Szeredi
2007-08-02 13:35         ` Jan Engelhardt
2007-08-02 13:35           ` Jan Engelhardt
2007-08-02 13:49           ` Miklos Szeredi
2007-08-02 13:49             ` Miklos Szeredi
2007-08-02 13:47     ` Peter Zijlstra
2007-08-02 13:47       ` Peter Zijlstra
2007-08-02 14:06       ` Bernd Petrovitsch
2007-08-02 14:06         ` Bernd Petrovitsch
2007-08-02 14:08         ` Jan Engelhardt
2007-08-02 14:08           ` Jan Engelhardt
2007-08-02 18:36   ` Andrew Morton
2007-08-02 18:36     ` Andrew Morton
2007-08-02 18:48     ` Miklos Szeredi
2007-08-02 18:48       ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070801092909.GN3972@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=miklos@szeredi.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.