All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: andi@firstfloor.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, akpm@linux-foundation.org,
	torvalds@linux-foundation.org
Subject: Re: [RFC PATCH] type safe allocator
Date: 01 Aug 2007 13:34:23 +0200	[thread overview]
Message-ID: <p73643zpjy8.fsf@bingen.suse.de> (raw)
In-Reply-To: <E1IGAx0-0006TK-00@dorka.pomaz.szeredi.hu>

Miklos Szeredi <miklos@szeredi.hu> writes:
> 
> #define k_new(type, flags) ((type *) kmalloc(sizeof(type), flags))

The cast doesn't make it more safe in any way

(at least as long as you don't care about portability to C++;
the kernel doesn't)

-Andi

WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: andi@firstfloor.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, akpm@linux-foundation.org,
	torvalds@linux-foundation.org
Subject: Re: [RFC PATCH] type safe allocator
Date: 01 Aug 2007 13:34:23 +0200	[thread overview]
Message-ID: <p73643zpjy8.fsf@bingen.suse.de> (raw)
In-Reply-To: <E1IGAx0-0006TK-00@dorka.pomaz.szeredi.hu>

Miklos Szeredi <miklos@szeredi.hu> writes:
> 
> #define k_new(type, flags) ((type *) kmalloc(sizeof(type), flags))

The cast doesn't make it more safe in any way

(at least as long as you don't care about portability to C++;
the kernel doesn't)

-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-08-01 10:39 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01  9:06 [RFC PATCH] type safe allocator Miklos Szeredi
2007-08-01  9:06 ` Miklos Szeredi
2007-08-01  9:29 ` Adrian Bunk
2007-08-01  9:29   ` Adrian Bunk
2007-08-01  9:41   ` Miklos Szeredi
2007-08-01  9:41     ` Miklos Szeredi
2007-08-01 10:44 ` Andi Kleen
2007-08-01 10:44   ` Andi Kleen
2007-08-01  9:57   ` Miklos Szeredi
2007-08-01  9:57     ` Miklos Szeredi
2007-08-01 11:34     ` Andi Kleen [this message]
2007-08-01 11:34       ` Andi Kleen
2007-08-01 10:45       ` Miklos Szeredi
2007-08-01 10:45         ` Miklos Szeredi
2007-08-01 11:44         ` Jan Engelhardt
2007-08-01 11:44           ` Jan Engelhardt
2007-08-01 11:56           ` Miklos Szeredi
2007-08-01 11:56             ` Miklos Szeredi
2007-08-02  3:56 ` Linus Torvalds
2007-08-02  3:56   ` Linus Torvalds
2007-08-02  7:27   ` Miklos Szeredi
2007-08-02  7:27     ` Miklos Szeredi
2007-08-02 12:05     ` Al Viro
2007-08-02 12:05       ` Al Viro
2007-08-02 13:05       ` Miklos Szeredi
2007-08-02 13:05         ` Miklos Szeredi
2007-08-02 17:23     ` Linus Torvalds
2007-08-02 17:23       ` Linus Torvalds
2007-08-02  5:33 ` Christoph Lameter
2007-08-02  5:33   ` Christoph Lameter
2007-08-02  7:38   ` Miklos Szeredi
2007-08-02  7:38     ` Miklos Szeredi
2007-08-02 19:16     ` Christoph Lameter
2007-08-02 19:16       ` Christoph Lameter
2007-08-02  7:37 ` Satyam Sharma
2007-08-02  7:37   ` Satyam Sharma
2007-08-02  7:40   ` Miklos Szeredi
2007-08-02  7:40     ` Miklos Szeredi
2007-08-02 11:31 ` [PATCH] " Miklos Szeredi
2007-08-02 11:31   ` Miklos Szeredi, Miklos Szeredi
2007-08-02 12:04   ` Alexey Dobriyan
2007-08-02 12:04     ` Alexey Dobriyan
2007-08-02 12:24     ` Jan Engelhardt
2007-08-02 12:24       ` Jan Engelhardt
2007-08-02 13:06       ` Miklos Szeredi
2007-08-02 13:06         ` Miklos Szeredi
2007-08-02 13:35         ` Jan Engelhardt
2007-08-02 13:35           ` Jan Engelhardt
2007-08-02 13:49           ` Miklos Szeredi
2007-08-02 13:49             ` Miklos Szeredi
2007-08-02 13:47     ` Peter Zijlstra
2007-08-02 13:47       ` Peter Zijlstra
2007-08-02 14:06       ` Bernd Petrovitsch
2007-08-02 14:06         ` Bernd Petrovitsch
2007-08-02 14:08         ` Jan Engelhardt
2007-08-02 14:08           ` Jan Engelhardt
2007-08-02 18:36   ` Andrew Morton
2007-08-02 18:36     ` Andrew Morton
2007-08-02 18:48     ` Miklos Szeredi
2007-08-02 18:48       ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73643zpjy8.fsf@bingen.suse.de \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=miklos@szeredi.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.