All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: mel@skynet.ie, akpm@linux-foundation.org,
	Lee.Schermerhorn@hp.com, kamezawa.hiroyu@jp.fujitsu.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Apply memory policies to top two highest zones when highest zone is ZONE_MOVABLE
Date: Mon, 6 Aug 2007 14:56:08 -0700	[thread overview]
Message-ID: <20070806145608.267bce88.pj@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0708021343420.10244@schroedinger.engr.sgi.com>

Christoph wrote, responding to Mel and Andrew:
> > +static inline int alloc_should_filter_zonelist(struct zonelist *zonelist)
> > +{
> > +	return !zonelist->zlcache_ptr;
> > +}
> 
> I guess Paul needs to have a look at this one.

...

> > Which Paul?
> 
> Paul Jackson. 


I'll ack that the above snippet of code, alloc_should_filter_zonelist(),
does, as its comment explains, return true iff it's a custom zonelist such
as from MPOL_BIND.

As to the more interesting issues that this patch raises ... I have no clue.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

WARNING: multiple messages have this Message-ID (diff)
From: Paul Jackson <pj@sgi.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: mel@skynet.ie, akpm@linux-foundation.org,
	Lee.Schermerhorn@hp.com, kamezawa.hiroyu@jp.fujitsu.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Apply memory policies to top two highest zones when highest zone is ZONE_MOVABLE
Date: Mon, 6 Aug 2007 14:56:08 -0700	[thread overview]
Message-ID: <20070806145608.267bce88.pj@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0708021343420.10244@schroedinger.engr.sgi.com>

Christoph wrote, responding to Mel and Andrew:
> > +static inline int alloc_should_filter_zonelist(struct zonelist *zonelist)
> > +{
> > +	return !zonelist->zlcache_ptr;
> > +}
> 
> I guess Paul needs to have a look at this one.

...

> > Which Paul?
> 
> Paul Jackson. 


I'll ack that the above snippet of code, alloc_should_filter_zonelist(),
does, as its comment explains, return true iff it's a custom zonelist such
as from MPOL_BIND.

As to the more interesting issues that this patch raises ... I have no clue.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2007-08-06 21:56 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-02 17:21 [PATCH] Apply memory policies to top two highest zones when highest zone is ZONE_MOVABLE Mel Gorman
2007-08-02 17:21 ` Mel Gorman
2007-08-02 19:41 ` Lee Schermerhorn
2007-08-02 19:41   ` Lee Schermerhorn
2007-08-02 20:45 ` Christoph Lameter
2007-08-02 20:45   ` Christoph Lameter
2007-08-06 19:44   ` Andrew Morton
2007-08-06 19:44     ` Andrew Morton
2007-08-06 20:13     ` Christoph Lameter
2007-08-06 20:13       ` Christoph Lameter
2007-08-06 21:56   ` Paul Jackson [this message]
2007-08-06 21:56     ` Paul Jackson
2007-08-03 22:02 ` Andi Kleen
2007-08-03 22:02   ` Andi Kleen
2007-08-04  0:23   ` Mel Gorman
2007-08-04  0:23     ` Mel Gorman
2007-08-04  8:51     ` Andi Kleen
2007-08-04  8:51       ` Andi Kleen
2007-08-04 16:39       ` Mel Gorman
2007-08-04 16:39         ` Mel Gorman
2007-08-06 19:15   ` Andrew Morton
2007-08-06 19:15     ` Andrew Morton
2007-08-06 19:18     ` Christoph Lameter
2007-08-06 19:18       ` Christoph Lameter
2007-08-06 20:31     ` Andi Kleen
2007-08-06 20:31       ` Andi Kleen
2007-08-06 21:55       ` Mel Gorman
2007-08-06 21:55         ` Mel Gorman
2007-08-07  5:12         ` Andrew Morton
2007-08-07  5:12           ` Andrew Morton
2007-08-07 16:55           ` Mel Gorman
2007-08-07 16:55             ` Mel Gorman
2007-08-07 18:14             ` Andrew Morton
2007-08-07 18:14               ` Andrew Morton
2007-08-07 20:37               ` Christoph Lameter
2007-08-07 20:37                 ` Christoph Lameter
2007-08-08 16:49               ` Mel Gorman
2007-08-08 16:49                 ` Mel Gorman
2007-08-08 17:03                 ` Christoph Lameter
2007-08-08 17:03                   ` Christoph Lameter
2007-08-06 21:48     ` Mel Gorman
2007-08-06 21:48       ` Mel Gorman
2007-08-06 22:31       ` Christoph Lameter
2007-08-06 22:31         ` Christoph Lameter
2007-08-06 22:57         ` Mel Gorman
2007-08-06 22:57           ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070806145608.267bce88.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@skynet.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.