Re: [PATCH] Apply memory policies to top two highest zones when highest zone is ZONE_MOVABLE

[Andrew Morton <akpm@linux-foundation.org>]

On Tue, 7 Aug 2007 17:55:47 +0100 mel@skynet.ie (Mel Gorman) wrote:

> On (06/08/07 22:12), Andrew Morton didst pronounce:
> > On Mon, 6 Aug 2007 22:55:41 +0100 mel@skynet.ie (Mel Gorman) wrote:
> > 
> > > On (06/08/07 22:31), Andi Kleen didst pronounce:
> > > > 
> > > > > If correct, I would suggest merging the horrible hack for .23 then taking
> > > > > it out when we merge "grouping pages by mobility".  But what if we don't do
> > > > > that merge?
> > > > 
> > > > Or disable ZONE_MOVABLE until it is usable?
> > > 
> > > It's usable now. The issue with policies only occurs if the user specifies
> > > kernelcore= or movablecore= on the command-line. Your language suggests
> > > that you believe policies are not applied when ZONE_MOVABLE is configured
> > > at build-time.
> > 
> > So..  the problem which we're fixing here is only present when someone
> > use kernelcore=.  This is in fact an argument for _not_ merging the
> > horrible-hack.
> > 
> 
> It's even more constrained than that. It only applies to the MPOL_BIND
> policy when kernelcore= is specified. The other policies work the same
> as they ever did.

so.. should we forget about merging the horrible-hack?