All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Snook <csnook@redhat.com>
To: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: akpm@linux-foundation.org, paulmck@linux.vnet.ibm.com,
	Segher Boessenkool <segher@kernel.crashing.org>,
	"Luck, Tony" <tony.luck@intel.com>,
	Chris Friesen <cfriesen@nortel.com>,
	"Robert P. J. Day" <rpjday@mindspring.com>
Subject: [PATCH 22/23] make atomic_read() and atomic_set() behavior consistent on x86_64
Date: Mon, 13 Aug 2007 07:44:38 -0400	[thread overview]
Message-ID: <20070813114438.GV24018@shell.boston.redhat.com> (raw)
In-Reply-To: <46C03885.7000109@redhat.com>

From: Chris Snook <csnook@redhat.com>

Use volatile consistently in atomic.h on x86_64.

Signed-off-by: Chris Snook <csnook@redhat.com>

--- linux-2.6.23-rc3-orig/include/asm-x86_64/atomic.h	2007-07-08 19:32:17.000000000 -0400
+++ linux-2.6.23-rc3/include/asm-x86_64/atomic.h	2007-08-13 06:22:43.000000000 -0400
@@ -32,7 +32,10 @@ typedef struct { int counter; } atomic_t
  * 
  * Atomically reads the value of @v.
  */ 
-#define atomic_read(v)		((v)->counter)
+static __inline__ int atomic_read(atomic_t *v)
+{
+        return *(volatile int *)&v->counter;
+}
 
 /**
  * atomic_set - set atomic variable
@@ -41,7 +44,10 @@ typedef struct { int counter; } atomic_t
  * 
  * Atomically sets the value of @v to @i.
  */ 
-#define atomic_set(v,i)		(((v)->counter) = (i))
+static __inline__ void atomic_set(atomic_t *v, int i)
+{
+        *(volatile int *)&v->counter = i;
+}
 
 /**
  * atomic_add - add integer to atomic variable
@@ -206,7 +212,7 @@ static __inline__ int atomic_sub_return(
 
 /* An 64bit atomic type */
 
-typedef struct { volatile long counter; } atomic64_t;
+typedef struct { long counter; } atomic64_t;
 
 #define ATOMIC64_INIT(i)	{ (i) }
 
@@ -217,7 +223,10 @@ typedef struct { volatile long counter; 
  * Atomically reads the value of @v.
  * Doesn't imply a read memory barrier.
  */
-#define atomic64_read(v)		((v)->counter)
+static __inline__ long atomic64_read(atomic64_t *v)
+{
+        return *(volatile long *)&v->counter;
+}
 
 /**
  * atomic64_set - set atomic64 variable
@@ -226,7 +235,10 @@ typedef struct { volatile long counter; 
  *
  * Atomically sets the value of @v to @i.
  */
-#define atomic64_set(v,i)		(((v)->counter) = (i))
+static __inline__ void atomic64_set(atomic64_t *v, long i)
+{
+        *(volatile long *)&v->counter = i;
+}
 
 /**
  * atomic64_add - add integer to atomic64 variable

  parent reply	other threads:[~2007-08-13 11:44 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-13 10:55 [PATCH 0/23] make atomic_read() and atomic_set() behavior consistent across all architectures Chris Snook
2007-08-13 11:04 ` [PATCH 1/23] document preferred use of volatile with atomic_t Chris Snook
2007-08-13 23:54   ` Paul E. McKenney
2007-08-14 22:45   ` Christoph Lameter
2007-08-14 22:53     ` Chris Snook
2007-08-14 22:56       ` Christoph Lameter
2007-08-14 22:56         ` Christoph Lameter
2007-08-14 23:25         ` Chris Snook
2007-08-14 23:28         ` Paul E. McKenney
2007-08-16 21:36       ` Segher Boessenkool
2007-08-13 11:06 ` [PATCH 2/23] make atomic_read() and atomic_set() behavior consistent on alpha Chris Snook
2007-08-13 11:09 ` [PATCH 3/23] make atomic_read() and atomic_set() behavior consistent on arm Chris Snook
2007-08-13 12:19   ` Russell King
2007-08-13 12:46     ` Chris Snook
2007-08-13 12:59       ` Russell King
2007-08-13 11:11 ` [PATCH 4/23] make atomic_read() and atomic_set() behavior consistent on avr32 Chris Snook
2007-08-13 11:12 ` [PATCH 5/23] make atomic_read() and atomic_set() behavior consistent on blackfin Chris Snook
2007-08-13 11:14 ` [PATCH 6/23] make atomic_read() and atomic_set() behavior consistent on cris Chris Snook
2007-08-13 11:15 ` [PATCH 7/23] make atomic_read() and atomic_set() behavior consistent on frv Chris Snook
2007-08-14  9:42   ` David Howells
2007-08-13 11:18 ` [PATCH 8/23] make atomic_read() and atomic_set() behavior consistent on h8300 Chris Snook
2007-08-13 11:21 ` [PATCH 9/23] make atomic_read() and atomic_set() behavior consistent on i386 Chris Snook
2007-08-13 11:23 ` [PATCH 10/23] make atomic_read() and atomic_set() behavior consistent on ia64 Chris Snook
2007-08-14 18:27   ` Luck, Tony
2007-08-14 18:27     ` Luck, Tony
2007-08-14 18:48     ` Chris Snook
2007-08-14 22:06       ` Luck, Tony
2007-08-14 22:06         ` Luck, Tony
2007-08-14 22:11         ` Christoph Lameter
2007-08-14 22:21           ` Chris Snook
2007-08-13 11:24 ` [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r Chris Snook
2007-08-22  1:56   ` Hirokazu Takata
2007-08-22  5:00     ` Hirokazu Takata
2007-08-22 14:06       ` Chris Snook
2007-08-22 14:24         ` Segher Boessenkool
2007-08-22 18:20           ` Linus Torvalds
2007-08-23 19:29             ` Segher Boessenkool
2007-08-23 20:05               ` David Howells
2007-08-23 20:12               ` Linus Torvalds
2007-08-23 20:39                 ` David Schwartz
2007-08-23 20:40               ` Valdis.Kletnieks
2007-08-13 11:26 ` [PATCH 12/23] make atomic_read() and atomic_set() behavior consistent on m68knommu Chris Snook
2007-08-13 11:28 ` [PATCH 13/23] make atomic_read() and atomic_set() behavior consistent on m68k Chris Snook
2007-08-13 11:29 ` [PATCH 14/23] make atomic_read() and atomic_set() behavior consistent on mips Chris Snook
2007-08-13 11:31 ` [PATCH 15/23] make atomic_read() and atomic_set() behavior consistent on parisc Chris Snook
2007-08-13 11:33 ` [PATCH 16/23] make atomic_read() and atomic_set() behavior consistent on s390 Chris Snook
2007-08-13 11:34 ` [PATCH 17/23] make atomic_read() and atomic_set() behavior consistent on sh64 Chris Snook
2007-08-13 11:36 ` [PATCH 18/23] make atomic_read() and atomic_set() behavior consistent on sh Chris Snook
2007-08-13 11:40 ` [PATCH 19/23] make atomic_read() and atomic_set() behavior consistent on sparc64 Chris Snook
2007-08-13 11:42 ` [PATCH 20/23] make atomic_read() and atomic_set() behavior consistent on sparc Chris Snook
2007-08-13 11:43 ` [PATCH 21/23] make atomic_read() and atomic_set() behavior consistent on v850 Chris Snook
2007-08-13 11:44 ` Chris Snook [this message]
2007-08-13 11:45 ` [PATCH 23/23] make atomic_read() and atomic_set() behavior consistent on xtensa Chris Snook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070813114438.GV24018@shell.boston.redhat.com \
    --to=csnook@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cfriesen@nortel.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rpjday@mindspring.com \
    --cc=segher@kernel.crashing.org \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.