All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Chris Snook <csnook@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	"Robert P. J. Day" <rpjday@mindspring.com>,
	paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, "Luck,
	Tony" <tony.luck@intel.com>,
	akpm@linux-foundation.org, linux-arch@vger.kernel.org,
	Christoph Lameter <clameter@sgi.com>,
	Chris Friesen <cfriesen@nortel.com>
Subject: Re: [PATCH 1/23] document preferred use of volatile with atomic_t
Date: Thu, 16 Aug 2007 23:36:49 +0200	[thread overview]
Message-ID: <7913acdd6449613c49b86bc99da0d254@kernel.crashing.org> (raw)
In-Reply-To: <46C2325C.8040900@redhat.com>

> But barriers force a flush of *everything* in scope,

Nonsense, whatever "flush" is supposed to mean here.

> If you really, *really* distrust the compiler that much, you shouldn't 
> be using barrier, since that uses volatile under the hood too.  You 
> should just go ahead and implement the atomic operations in assembler, 
> like Segher Boessenkool did for powerpc in response to my previous 
> patchset.

Puh-lease.  I DO NOT DISTRUST THE COMPILER, I just don't assume
it will do whatever I would like it to do without telling it.
It's a machine you know, and it is very well documented.

(And most barriers don't (need to) use volatile).

Implementing the atomic ops in asm loses exactly *no* semantics,
and it doesn't add restrictions either; it does allow you however
to access an atomic_t with normal loads/stores independently, if
you so choose.  The only valid issue brought up so far is Russell
King's comment that GCC cannot schedule the machine instructions
in and around an asm() perfectly, it doesn't look inside the asm()
after all; but the situation isn't quite as sever as he suggests
(GCC _does_ know you are performing loads/stores, etc.); more about
that later, when I've finished researching the current state of
that stuff.


Segher


  parent reply	other threads:[~2007-08-16 21:37 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-13 10:55 [PATCH 0/23] make atomic_read() and atomic_set() behavior consistent across all architectures Chris Snook
2007-08-13 11:04 ` [PATCH 1/23] document preferred use of volatile with atomic_t Chris Snook
2007-08-13 23:54   ` Paul E. McKenney
2007-08-14 22:45   ` Christoph Lameter
2007-08-14 22:53     ` Chris Snook
2007-08-14 22:56       ` Christoph Lameter
2007-08-14 22:56         ` Christoph Lameter
2007-08-14 23:25         ` Chris Snook
2007-08-14 23:28         ` Paul E. McKenney
2007-08-16 21:36       ` Segher Boessenkool [this message]
2007-08-13 11:06 ` [PATCH 2/23] make atomic_read() and atomic_set() behavior consistent on alpha Chris Snook
2007-08-13 11:09 ` [PATCH 3/23] make atomic_read() and atomic_set() behavior consistent on arm Chris Snook
2007-08-13 12:19   ` Russell King
2007-08-13 12:46     ` Chris Snook
2007-08-13 12:59       ` Russell King
2007-08-13 11:11 ` [PATCH 4/23] make atomic_read() and atomic_set() behavior consistent on avr32 Chris Snook
2007-08-13 11:12 ` [PATCH 5/23] make atomic_read() and atomic_set() behavior consistent on blackfin Chris Snook
2007-08-13 11:14 ` [PATCH 6/23] make atomic_read() and atomic_set() behavior consistent on cris Chris Snook
2007-08-13 11:15 ` [PATCH 7/23] make atomic_read() and atomic_set() behavior consistent on frv Chris Snook
2007-08-14  9:42   ` David Howells
2007-08-13 11:18 ` [PATCH 8/23] make atomic_read() and atomic_set() behavior consistent on h8300 Chris Snook
2007-08-13 11:21 ` [PATCH 9/23] make atomic_read() and atomic_set() behavior consistent on i386 Chris Snook
2007-08-13 11:23 ` [PATCH 10/23] make atomic_read() and atomic_set() behavior consistent on ia64 Chris Snook
2007-08-14 18:27   ` Luck, Tony
2007-08-14 18:27     ` Luck, Tony
2007-08-14 18:48     ` Chris Snook
2007-08-14 22:06       ` Luck, Tony
2007-08-14 22:06         ` Luck, Tony
2007-08-14 22:11         ` Christoph Lameter
2007-08-14 22:21           ` Chris Snook
2007-08-13 11:24 ` [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r Chris Snook
2007-08-22  1:56   ` Hirokazu Takata
2007-08-22  5:00     ` Hirokazu Takata
2007-08-22 14:06       ` Chris Snook
2007-08-22 14:24         ` Segher Boessenkool
2007-08-22 18:20           ` Linus Torvalds
2007-08-23 19:29             ` Segher Boessenkool
2007-08-23 20:05               ` David Howells
2007-08-23 20:12               ` Linus Torvalds
2007-08-23 20:39                 ` David Schwartz
2007-08-23 20:40               ` Valdis.Kletnieks
2007-08-13 11:26 ` [PATCH 12/23] make atomic_read() and atomic_set() behavior consistent on m68knommu Chris Snook
2007-08-13 11:28 ` [PATCH 13/23] make atomic_read() and atomic_set() behavior consistent on m68k Chris Snook
2007-08-13 11:29 ` [PATCH 14/23] make atomic_read() and atomic_set() behavior consistent on mips Chris Snook
2007-08-13 11:31 ` [PATCH 15/23] make atomic_read() and atomic_set() behavior consistent on parisc Chris Snook
2007-08-13 11:33 ` [PATCH 16/23] make atomic_read() and atomic_set() behavior consistent on s390 Chris Snook
2007-08-13 11:34 ` [PATCH 17/23] make atomic_read() and atomic_set() behavior consistent on sh64 Chris Snook
2007-08-13 11:36 ` [PATCH 18/23] make atomic_read() and atomic_set() behavior consistent on sh Chris Snook
2007-08-13 11:40 ` [PATCH 19/23] make atomic_read() and atomic_set() behavior consistent on sparc64 Chris Snook
2007-08-13 11:42 ` [PATCH 20/23] make atomic_read() and atomic_set() behavior consistent on sparc Chris Snook
2007-08-13 11:43 ` [PATCH 21/23] make atomic_read() and atomic_set() behavior consistent on v850 Chris Snook
2007-08-13 11:44 ` [PATCH 22/23] make atomic_read() and atomic_set() behavior consistent on x86_64 Chris Snook
2007-08-13 11:45 ` [PATCH 23/23] make atomic_read() and atomic_set() behavior consistent on xtensa Chris Snook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7913acdd6449613c49b86bc99da0d254@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=akpm@linux-foundation.org \
    --cc=cfriesen@nortel.com \
    --cc=clameter@sgi.com \
    --cc=csnook@redhat.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rpjday@mindspring.com \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.