All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Walle <bwalle@suse.de>
To: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Cc: Don Zickus <dzickus@redhat.com>, Neil Horman <nhorman@redhat.com>,
	Vivek Goyal <vgoyal@in.ibm.com>,
	kexec-ml <kexec@lists.infradead.org>,
	Dan Aloni <da-x@monatomic.org>
Subject: Re: [RFC][PATCH 3/3] Embed vmcoreinfo into kernel file
Date: Tue, 14 Aug 2007 23:59:22 +0200	[thread overview]
Message-ID: <20070814215922.GA16408@suse.de> (raw)
In-Reply-To: <20070813163934oomichi@mail.jp.nec.com>

Hello,

* Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp> [2007-08-13 09:39]:
> +#define FILENAME_VMCOREINFO		"/tmp/vmcoreinfo.tmp"

Wouldn't it be better to use mkstemp() here? It also makes sense to
copy the whole vmcore first and run makedumpfile after this in a full
featured system, e.g. before sending the dump file via FTP.

Then, you have the well-known security problems when using a temporary
file with a static name -- as well as two makedumpfile processes
running in parallel. While this all is not very likely, it's also not
guaranteed that this doesn't happen.


Thanks,
   Bernhard

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2007-08-14 21:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-13  7:32 [RFC][PATCH 0/3] Embed vmcoreinfo into kernel file Ken'ichi Ohmichi
2007-08-13  7:36 ` [RFC][PATCH 1/3] " Ken'ichi Ohmichi
2007-08-13 17:38   ` Dan Aloni
2007-08-14 22:00     ` Bernhard Walle
2007-08-16  4:20   ` Vivek Goyal
2007-08-17  6:43     ` Ken'ichi Ohmichi
2007-08-17  9:44       ` Bernhard Walle
2007-08-22  6:40         ` Ken'ichi Ohmichi
2007-08-17 12:28       ` Vivek Goyal
2007-08-22 10:54         ` Ken'ichi Ohmichi
2007-08-13  7:38 ` [RFC][PATCH 2/3] " Ken'ichi Ohmichi
2007-08-13  7:39 ` [RFC][PATCH 3/3] " Ken'ichi Ohmichi
2007-08-14 21:59   ` Bernhard Walle [this message]
2007-08-17  7:09     ` Ken'ichi Ohmichi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070814215922.GA16408@suse.de \
    --to=bwalle@suse.de \
    --cc=da-x@monatomic.org \
    --cc=dzickus@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=nhorman@redhat.com \
    --cc=oomichi@mxs.nes.nec.co.jp \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.