All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Walle <bwalle@suse.de>
To: Dan Aloni <da-x@monatomic.org>
Cc: Don Zickus <dzickus@redhat.com>,
	Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>,
	Neil Horman <nhorman@redhat.com>, Vivek Goyal <vgoyal@in.ibm.com>,
	kexec-ml <kexec@lists.infradead.org>
Subject: Re: [RFC][PATCH 1/3] Embed vmcoreinfo into kernel file
Date: Wed, 15 Aug 2007 00:00:25 +0200	[thread overview]
Message-ID: <20070814220025.GB16408@suse.de> (raw)
In-Reply-To: <20070813173811.GA14191@localdomain>

* Dan Aloni <da-x@monatomic.org> [2007-08-13 19:38]:
> On Mon, Aug 13, 2007 at 04:36:53PM +0900, Ken'ichi Ohmichi wrote:
> >[..]
> > Patches:
> > - [1/3] patch for linux-2.6.22.
> >   Changelog:
> >   * Rename "mkdfinfo" to "vmcoreinfo".
> >   * Multi memory models (FLATMEM, DISCONTIGMEM, and SPASEMEM) are
> >     supported.
> >   * The elf note typedef for vmcoreinfo is added because the original
> >     elf note size is limited to 1024.
> >   * The generation of the elf note is moved to boot time instead of
> >     crash time.
> 
> This looks very good. Just one suggestion - in order to reduce clutter 
> from kernel/kexec.c (as to avoid #ifdefs) perhaps it might be better 
> to have crash_save_vmcoreinfo_init() additionally call an arch-specific 
> arch_crash_save_vmcoreinfo_init() function and have that append all 
> the arch-specific stuff.

Because the only architecture that is really different is IA64, it may
make sense here to provide a default implementation that is used on
any architecture and declared as __attribute__((weak)). Then, any
architecture (here: IA64) can override that implementation. That would
avoid code duplication.

The rest looks good from my point of view. I'd like to see that in the
mainline kernel. :)



Thanks,
   Bernhard

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2007-08-14 22:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-13  7:32 [RFC][PATCH 0/3] Embed vmcoreinfo into kernel file Ken'ichi Ohmichi
2007-08-13  7:36 ` [RFC][PATCH 1/3] " Ken'ichi Ohmichi
2007-08-13 17:38   ` Dan Aloni
2007-08-14 22:00     ` Bernhard Walle [this message]
2007-08-16  4:20   ` Vivek Goyal
2007-08-17  6:43     ` Ken'ichi Ohmichi
2007-08-17  9:44       ` Bernhard Walle
2007-08-22  6:40         ` Ken'ichi Ohmichi
2007-08-17 12:28       ` Vivek Goyal
2007-08-22 10:54         ` Ken'ichi Ohmichi
2007-08-13  7:38 ` [RFC][PATCH 2/3] " Ken'ichi Ohmichi
2007-08-13  7:39 ` [RFC][PATCH 3/3] " Ken'ichi Ohmichi
2007-08-14 21:59   ` Bernhard Walle
2007-08-17  7:09     ` Ken'ichi Ohmichi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070814220025.GB16408@suse.de \
    --to=bwalle@suse.de \
    --cc=da-x@monatomic.org \
    --cc=dzickus@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=nhorman@redhat.com \
    --cc=oomichi@mxs.nes.nec.co.jp \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.