All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ken'ichi Ohmichi" <oomichi@mxs.nes.nec.co.jp>
To: Bernhard Walle <bwalle@suse.de>
Cc: Don Zickus <dzickus@redhat.com>, Neil Horman <nhorman@redhat.com>,
	vgoyal@in.ibm.com, kexec-ml <kexec@lists.infradead.org>,
	Dan Aloni <da-x@monatomic.org>
Subject: Re: [RFC][PATCH 1/3] Embed vmcoreinfo into kernel file
Date: Wed, 22 Aug 2007 15:40:50 +0900	[thread overview]
Message-ID: <20070822154050oomichi@mail.jp.nec.com> (raw)
In-Reply-To: <20070817094407.GA31095@suse.de>


Hi Bernhard,

2007/08/17 11:44:07 +0200, Bernhard Walle <bwalle@suse.de> wrote:
>Hi,
>
>* Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp> [2007-08-17 08:43]:
>> 
>> Thank you for good comments.
>> I updated the patch for applying your comments.
>
>Instead of providing empty implementations of arch_save_vmcoreinfo()
>for each architecture that doesn't need that hook, I'd suggest to use
>one default implementation with __attribute((weak)) that gets
>overwritten by architecture implementations. See my patch below:

Thank you for a good patch.
I'll update the patch based on yours.


Thanks
Ken'ichi Ohmichi

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2007-08-22  6:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-13  7:32 [RFC][PATCH 0/3] Embed vmcoreinfo into kernel file Ken'ichi Ohmichi
2007-08-13  7:36 ` [RFC][PATCH 1/3] " Ken'ichi Ohmichi
2007-08-13 17:38   ` Dan Aloni
2007-08-14 22:00     ` Bernhard Walle
2007-08-16  4:20   ` Vivek Goyal
2007-08-17  6:43     ` Ken'ichi Ohmichi
2007-08-17  9:44       ` Bernhard Walle
2007-08-22  6:40         ` Ken'ichi Ohmichi [this message]
2007-08-17 12:28       ` Vivek Goyal
2007-08-22 10:54         ` Ken'ichi Ohmichi
2007-08-13  7:38 ` [RFC][PATCH 2/3] " Ken'ichi Ohmichi
2007-08-13  7:39 ` [RFC][PATCH 3/3] " Ken'ichi Ohmichi
2007-08-14 21:59   ` Bernhard Walle
2007-08-17  7:09     ` Ken'ichi Ohmichi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070822154050oomichi@mail.jp.nec.com \
    --to=oomichi@mxs.nes.nec.co.jp \
    --cc=bwalle@suse.de \
    --cc=da-x@monatomic.org \
    --cc=dzickus@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=nhorman@redhat.com \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.