From: Jeff Dike <jdike@addtoit.com>
To: Satyam Sharma <satyam@infradead.org>
Cc: Joe Perches <joe@perches.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH] hostfs: Remove pointless if statement
Date: Fri, 17 Aug 2007 09:54:46 -0400 [thread overview]
Message-ID: <20070817135446.GA5725@c2.user-mode-linux.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0708171208060.3666@enigma.security.iitk.ac.in>
On Fri, Aug 17, 2007 at 12:24:23PM +0530, Satyam Sharma wrote:
> We normally use "comments" for that, not dead code that a compiler
> then elids ;-)
I'd argue that comments are for when you can't make the code
self-explanatory.
> [PATCH] hostfs: Remove pointless if statement
>
> And replace with comment saying we don't handle ctime.
> Also some codingstyle while I was there.
I'll forward this upstream.
Jeff
--
Work email - jdike at linux dot intel dot com
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: Satyam Sharma <satyam@infradead.org>
Cc: Joe Perches <joe@perches.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH] hostfs: Remove pointless if statement
Date: Fri, 17 Aug 2007 09:54:46 -0400 [thread overview]
Message-ID: <20070817135446.GA5725@c2.user-mode-linux.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0708171208060.3666@enigma.security.iitk.ac.in>
On Fri, Aug 17, 2007 at 12:24:23PM +0530, Satyam Sharma wrote:
> We normally use "comments" for that, not dead code that a compiler
> then elids ;-)
I'd argue that comments are for when you can't make the code
self-explanatory.
> [PATCH] hostfs: Remove pointless if statement
>
> And replace with comment saying we don't handle ctime.
> Also some codingstyle while I was there.
I'll forward this upstream.
Jeff
--
Work email - jdike at linux dot intel dot com
next prev parent reply other threads:[~2007-08-17 13:54 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 23:58 drivers/infiniband/mlx/mad.c misplaced ; Dave Jones
2007-08-16 0:40 ` Joe Perches
2007-08-16 0:40 ` [uml-devel] " Joe Perches
2007-08-16 2:19 ` Kok, Auke
2007-08-16 2:19 ` [uml-devel] " Kok, Auke
2007-08-16 3:17 ` Joe Perches
2007-08-16 4:20 ` Kok, Auke
2007-08-16 10:21 ` [netfilter-core] " Patrick McHardy
2007-08-16 14:05 ` Andy Whitcroft
2007-08-16 14:05 ` [uml-devel] " Andy Whitcroft
2007-08-16 8:46 ` Heiko Carstens
2007-08-16 8:46 ` [uml-devel] " Heiko Carstens
2007-08-16 10:22 ` Ilpo Järvinen
2007-08-16 10:22 ` [uml-devel] " Ilpo Järvinen
2007-08-16 11:01 ` Karsten Keil
2007-08-16 11:01 ` [uml-devel] " Karsten Keil
2007-08-18 15:14 ` Daniel Schaffrath
2007-08-18 15:14 ` [uml-devel] " Daniel Schaffrath
2007-08-16 12:41 ` Satyam Sharma
2007-08-16 12:41 ` [uml-devel] " Satyam Sharma
2007-08-16 14:52 ` Jeff Dike
2007-08-16 14:52 ` [uml-devel] " Jeff Dike
2007-08-17 6:54 ` [uml-devel] [PATCH] hostfs: Remove pointless if statement Satyam Sharma
2007-08-17 6:54 ` Satyam Sharma
2007-08-17 13:54 ` Jeff Dike [this message]
2007-08-17 13:54 ` Jeff Dike
2007-08-16 16:19 ` drivers/infiniband/mlx/mad.c misplaced ; Paul Mundt
2007-08-16 16:19 ` [uml-devel] " Paul Mundt
2007-08-16 3:39 ` Roland Dreier
2007-08-16 13:18 ` [PATCH 0/6] checkpatch checks for trailing semicolons on conditionals Andy Whitcroft
2007-08-16 13:18 ` [PATCH 1/6] mips: irix_getcontext will always fail EFAULT Andy Whitcroft
2007-08-16 13:18 ` Andy Whitcroft
2007-08-22 22:35 ` Ralf Baechle
2007-08-16 13:18 ` [PATCH 2/6] powerpc: hash_preload fails to preload under CONFIG_PPC_MM_SLICES Andy Whitcroft
2007-08-16 13:18 ` Andy Whitcroft
2007-08-16 13:18 ` [PATCH 3/6] sh: remove extraneous ; on scif_sercon_putc wait loop Andy Whitcroft
2007-08-16 16:27 ` Paul Mundt
2007-08-16 13:19 ` [PATCH 4/6] infiniband: mlx4_MAD_IFC copies out response unconditionally Andy Whitcroft
2007-08-16 15:01 ` Roland Dreier
2007-08-16 13:19 ` [PATCH 5/6] irda_nl_get_mode: always results in failure Andy Whitcroft
2007-08-16 13:19 ` [PATCH 6/6] netfilter: xt_u32: fix length checks in u32_match_it Andy Whitcroft
2007-08-16 13:19 ` Andy Whitcroft
2007-08-16 14:32 ` Patrick McHardy
2007-08-16 14:21 ` [PATCH 0/6] checkpatch checks for trailing semicolons on conditionals Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070817135446.GA5725@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=satyam@infradead.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.