* [PATCH] rtc: Make rtc-rs5c348 driver hotplug-aware (take 2)
@ 2007-08-19 13:32 Atsushi Nemoto
2007-08-20 1:49 ` David Brownell
0 siblings, 1 reply; 3+ messages in thread
From: Atsushi Nemoto @ 2007-08-19 13:32 UTC (permalink / raw)
To: a.zummo; +Cc: linux-kernel, rtc-linux, dbrownell, ralf
The rtc-rs5c348 SPI driver name doesn't match its module name, which
prevents it from properly hotplugging. There is only one in-tree user
of its driver, which is fixed by this patch too.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
arch/mips/tx4938/toshiba_rbtx4938/setup.c | 2 +-
drivers/rtc/rtc-rs5c348.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/tx4938/toshiba_rbtx4938/setup.c b/arch/mips/tx4938/toshiba_rbtx4938/setup.c
index 57f3c70..84ebff7 100644
--- a/arch/mips/tx4938/toshiba_rbtx4938/setup.c
+++ b/arch/mips/tx4938/toshiba_rbtx4938/setup.c
@@ -1115,7 +1115,7 @@ static void __init txx9_spi_init(unsigned long base, int irq)
static int __init rbtx4938_spi_init(void)
{
struct spi_board_info srtc_info = {
- .modalias = "rs5c348",
+ .modalias = "rtc-rs5c348",
.max_speed_hz = 1000000, /* 1.0Mbps @ Vdd 2.0V */
.bus_num = 0,
.chip_select = 16 + SRTC_CS,
diff --git a/drivers/rtc/rtc-rs5c348.c b/drivers/rtc/rtc-rs5c348.c
index f50f3fc..8394626 100644
--- a/drivers/rtc/rtc-rs5c348.c
+++ b/drivers/rtc/rtc-rs5c348.c
@@ -226,7 +226,7 @@ static int __devexit rs5c348_remove(struct spi_device *spi)
static struct spi_driver rs5c348_driver = {
.driver = {
- .name = "rs5c348",
+ .name = "rtc-rs5c348",
.bus = &spi_bus_type,
.owner = THIS_MODULE,
},
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtc: Make rtc-rs5c348 driver hotplug-aware (take 2)
2007-08-19 13:32 [PATCH] rtc: Make rtc-rs5c348 driver hotplug-aware (take 2) Atsushi Nemoto
@ 2007-08-20 1:49 ` David Brownell
2007-08-20 10:44 ` Ralf Baechle
0 siblings, 1 reply; 3+ messages in thread
From: David Brownell @ 2007-08-20 1:49 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: a.zummo, linux-kernel, rtc-linux, ralf
On Sunday 19 August 2007, Atsushi Nemoto wrote:
> The rtc-rs5c348 SPI driver name doesn't match its module name, which
> prevents it from properly hotplugging. There is only one in-tree user
> of its driver, which is fixed by this patch too.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
ACK.
> ---
> arch/mips/tx4938/toshiba_rbtx4938/setup.c | 2 +-
> drivers/rtc/rtc-rs5c348.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/tx4938/toshiba_rbtx4938/setup.c b/arch/mips/tx4938/toshiba_rbtx4938/setup.c
> index 57f3c70..84ebff7 100644
> --- a/arch/mips/tx4938/toshiba_rbtx4938/setup.c
> +++ b/arch/mips/tx4938/toshiba_rbtx4938/setup.c
> @@ -1115,7 +1115,7 @@ static void __init txx9_spi_init(unsigned long base, int irq)
> static int __init rbtx4938_spi_init(void)
> {
> struct spi_board_info srtc_info = {
> - .modalias = "rs5c348",
> + .modalias = "rtc-rs5c348",
> .max_speed_hz = 1000000, /* 1.0Mbps @ Vdd 2.0V */
> .bus_num = 0,
> .chip_select = 16 + SRTC_CS,
> diff --git a/drivers/rtc/rtc-rs5c348.c b/drivers/rtc/rtc-rs5c348.c
> index f50f3fc..8394626 100644
> --- a/drivers/rtc/rtc-rs5c348.c
> +++ b/drivers/rtc/rtc-rs5c348.c
> @@ -226,7 +226,7 @@ static int __devexit rs5c348_remove(struct spi_device *spi)
>
> static struct spi_driver rs5c348_driver = {
> .driver = {
> - .name = "rs5c348",
> + .name = "rtc-rs5c348",
> .bus = &spi_bus_type,
> .owner = THIS_MODULE,
> },
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtc: Make rtc-rs5c348 driver hotplug-aware (take 2)
2007-08-20 1:49 ` David Brownell
@ 2007-08-20 10:44 ` Ralf Baechle
0 siblings, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2007-08-20 10:44 UTC (permalink / raw)
To: David Brownell; +Cc: Atsushi Nemoto, a.zummo, linux-kernel, rtc-linux
On Sun, Aug 19, 2007 at 06:49:16PM -0700, David Brownell wrote:
> On Sunday 19 August 2007, Atsushi Nemoto wrote:
> > The rtc-rs5c348 SPI driver name doesn't match its module name, which
> > prevents it from properly hotplugging. There is only one in-tree user
> > of its driver, which is fixed by this patch too.
> >
> > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
>
> ACK.
Okay, will merge this one.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-20 10:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-19 13:32 [PATCH] rtc: Make rtc-rs5c348 driver hotplug-aware (take 2) Atsushi Nemoto
2007-08-20 1:49 ` David Brownell
2007-08-20 10:44 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.